* [PATCH] mmc: meson-gx: fix error path when driver initialization fails before enabling clocks
@ 2017-02-18 17:06 ` Michał Zegan
0 siblings, 0 replies; 12+ messages in thread
From: Michał Zegan @ 2017-02-18 17:06 UTC (permalink / raw)
To: Kevin Hilman, Carlo Caione
Cc: linux-kernel, linux-amlogic, linux-mmc, Ulf Hansson,
Michał Zegan
This patch fixes the case where meson_mmc_probe function fails before
core_clk is enabled.
Originally, that would result in a try to disable the core clock, and if
it was not already enabled, it would result in a kernel warning.
This issue is similar to the one with div_clk.
Fix it by introducing another error path used only between successfully
enabling the core clock, and successfully enabling the div clock.
That would ensure that core clock is disabled only if it was enabled before.
Signed-off-by: Michał Zegan <webczat@webczatnet.pl>
---
applies on top of Heiner's patchset v3
https://patchwork.kernel.org/patch/9581057/
That in turn applies on top of https://patchwork.kernel.org/patch/9561215/
drivers/mmc/host/meson-gx-mmc.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/mmc/host/meson-gx-mmc.c b/drivers/mmc/host/meson-gx-mmc.c
index 336b6a2e94c6..7917a3fe51ad 100644
--- a/drivers/mmc/host/meson-gx-mmc.c
+++ b/drivers/mmc/host/meson-gx-mmc.c
@@ -752,7 +752,7 @@ static int meson_mmc_probe(struct platform_device *pdev)
ret = meson_mmc_clk_init(host);
if (ret)
- goto free_host;
+ goto err_core_clk;
ret = devm_request_threaded_irq(&pdev->dev, irq, meson_mmc_irq,
meson_mmc_irq_thread, IRQF_SHARED,
@@ -781,8 +781,9 @@ static int meson_mmc_probe(struct platform_device *pdev)
err_div_clk:
clk_disable_unprepare(host->cfg_div_clk);
-free_host:
+err_core_clk:
clk_disable_unprepare(host->core_clk);
+free_host:
mmc_free_host(mmc);
return ret;
}
--
2.11.0
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH v2] mmc: meson-gx: remove mmc host on device removal
2017-02-18 17:06 ` Michał Zegan
@ 2017-02-18 17:06 ` Michał Zegan
-1 siblings, 0 replies; 12+ messages in thread
From: Michał Zegan @ 2017-02-18 17:06 UTC (permalink / raw)
To: linus-amlogic
The mmc host was added in meson_mmc_probe, but never removed in
meson_mmc_remove.
Fix that by removing the host before deallocating other resources.
Signed-off-by: Micha? Zegan <webczat@webczatnet.pl>
Tested-by: Micha? Zegan <webczat@webczatnet.pl>
---
changes since v1:
rebased on top of patchset at
https://patchwork.kernel.org/patch/9581057/
This is in turn based on patchset at
https://patchwork.kernel.org/patch/9561215/
drivers/mmc/host/meson-gx-mmc.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/mmc/host/meson-gx-mmc.c b/drivers/mmc/host/meson-gx-mmc.c
index e759e4c2e4a0..336b6a2e94c6 100644
--- a/drivers/mmc/host/meson-gx-mmc.c
+++ b/drivers/mmc/host/meson-gx-mmc.c
@@ -791,6 +791,8 @@ static int meson_mmc_remove(struct platform_device *pdev)
{
struct meson_host *host = dev_get_drvdata(&pdev->dev);
+ mmc_remove_host(host->mmc);
+
/* disable interrupts */
writel(0, host->regs + SD_EMMC_IRQ_EN);
--
2.11.0
^ permalink raw reply related [flat|nested] 12+ messages in thread* [PATCH v2] mmc: meson-gx: remove mmc host on device removal
@ 2017-02-18 17:06 ` Michał Zegan
0 siblings, 0 replies; 12+ messages in thread
From: Michał Zegan @ 2017-02-18 17:06 UTC (permalink / raw)
To: Kevin Hilman, Carlo Caione
Cc: linux-kernel, linux-amlogic, linux-mmc, Ulf Hansson,
Michał Zegan
The mmc host was added in meson_mmc_probe, but never removed in
meson_mmc_remove.
Fix that by removing the host before deallocating other resources.
Signed-off-by: Michał Zegan <webczat@webczatnet.pl>
Tested-by: Michał Zegan <webczat@webczatnet.pl>
---
changes since v1:
rebased on top of patchset at
https://patchwork.kernel.org/patch/9581057/
This is in turn based on patchset at
https://patchwork.kernel.org/patch/9561215/
drivers/mmc/host/meson-gx-mmc.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/mmc/host/meson-gx-mmc.c b/drivers/mmc/host/meson-gx-mmc.c
index e759e4c2e4a0..336b6a2e94c6 100644
--- a/drivers/mmc/host/meson-gx-mmc.c
+++ b/drivers/mmc/host/meson-gx-mmc.c
@@ -791,6 +791,8 @@ static int meson_mmc_remove(struct platform_device *pdev)
{
struct meson_host *host = dev_get_drvdata(&pdev->dev);
+ mmc_remove_host(host->mmc);
+
/* disable interrupts */
writel(0, host->regs + SD_EMMC_IRQ_EN);
--
2.11.0
^ permalink raw reply related [flat|nested] 12+ messages in thread* [PATCH v2] mmc: meson-gx: remove mmc host on device removal
2017-02-18 17:06 ` Michał Zegan
@ 2017-02-28 3:09 ` Kevin Hilman
-1 siblings, 0 replies; 12+ messages in thread
From: Kevin Hilman @ 2017-02-28 3:09 UTC (permalink / raw)
To: linus-amlogic
Micha? Zegan <webczat@webczatnet.pl> writes:
> The mmc host was added in meson_mmc_probe, but never removed in
> meson_mmc_remove.
> Fix that by removing the host before deallocating other resources.
>
> Signed-off-by: Micha? Zegan <webczat@webczatnet.pl>
> Tested-by: Micha? Zegan <webczat@webczatnet.pl>
Acked-by: Kevin Hilman <khilman@baylibre.com>
> ---
> changes since v1:
> rebased on top of patchset at
> https://patchwork.kernel.org/patch/9581057/
> This is in turn based on patchset at
> https://patchwork.kernel.org/patch/9561215/
>
> drivers/mmc/host/meson-gx-mmc.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/mmc/host/meson-gx-mmc.c b/drivers/mmc/host/meson-gx-mmc.c
> index e759e4c2e4a0..336b6a2e94c6 100644
> --- a/drivers/mmc/host/meson-gx-mmc.c
> +++ b/drivers/mmc/host/meson-gx-mmc.c
> @@ -791,6 +791,8 @@ static int meson_mmc_remove(struct platform_device *pdev)
> {
> struct meson_host *host = dev_get_drvdata(&pdev->dev);
>
> + mmc_remove_host(host->mmc);
> +
> /* disable interrupts */
> writel(0, host->regs + SD_EMMC_IRQ_EN);
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [PATCH v2] mmc: meson-gx: remove mmc host on device removal
@ 2017-02-28 3:09 ` Kevin Hilman
0 siblings, 0 replies; 12+ messages in thread
From: Kevin Hilman @ 2017-02-28 3:09 UTC (permalink / raw)
To: Michał Zegan
Cc: Carlo Caione, linux-kernel, linux-amlogic, linux-mmc, Ulf Hansson
Michał Zegan <webczat@webczatnet.pl> writes:
> The mmc host was added in meson_mmc_probe, but never removed in
> meson_mmc_remove.
> Fix that by removing the host before deallocating other resources.
>
> Signed-off-by: Michał Zegan <webczat@webczatnet.pl>
> Tested-by: Michał Zegan <webczat@webczatnet.pl>
Acked-by: Kevin Hilman <khilman@baylibre.com>
> ---
> changes since v1:
> rebased on top of patchset at
> https://patchwork.kernel.org/patch/9581057/
> This is in turn based on patchset at
> https://patchwork.kernel.org/patch/9561215/
>
> drivers/mmc/host/meson-gx-mmc.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/mmc/host/meson-gx-mmc.c b/drivers/mmc/host/meson-gx-mmc.c
> index e759e4c2e4a0..336b6a2e94c6 100644
> --- a/drivers/mmc/host/meson-gx-mmc.c
> +++ b/drivers/mmc/host/meson-gx-mmc.c
> @@ -791,6 +791,8 @@ static int meson_mmc_remove(struct platform_device *pdev)
> {
> struct meson_host *host = dev_get_drvdata(&pdev->dev);
>
> + mmc_remove_host(host->mmc);
> +
> /* disable interrupts */
> writel(0, host->regs + SD_EMMC_IRQ_EN);
^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH v2] mmc: meson-gx: remove mmc host on device removal
2017-02-18 17:06 ` Michał Zegan
@ 2017-03-14 16:21 ` Ulf Hansson
-1 siblings, 0 replies; 12+ messages in thread
From: Ulf Hansson @ 2017-03-14 16:21 UTC (permalink / raw)
To: linus-amlogic
On 18 February 2017 at 18:06, Micha? Zegan <webczat@webczatnet.pl> wrote:
> The mmc host was added in meson_mmc_probe, but never removed in
> meson_mmc_remove.
> Fix that by removing the host before deallocating other resources.
>
> Signed-off-by: Micha? Zegan <webczat@webczatnet.pl>
> Tested-by: Micha? Zegan <webczat@webczatnet.pl>
Thanks, applied for next!
Kind regards
Uffe
> ---
> changes since v1:
> rebased on top of patchset at
> https://patchwork.kernel.org/patch/9581057/
> This is in turn based on patchset at
> https://patchwork.kernel.org/patch/9561215/
>
> drivers/mmc/host/meson-gx-mmc.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/mmc/host/meson-gx-mmc.c b/drivers/mmc/host/meson-gx-mmc.c
> index e759e4c2e4a0..336b6a2e94c6 100644
> --- a/drivers/mmc/host/meson-gx-mmc.c
> +++ b/drivers/mmc/host/meson-gx-mmc.c
> @@ -791,6 +791,8 @@ static int meson_mmc_remove(struct platform_device *pdev)
> {
> struct meson_host *host = dev_get_drvdata(&pdev->dev);
>
> + mmc_remove_host(host->mmc);
> +
> /* disable interrupts */
> writel(0, host->regs + SD_EMMC_IRQ_EN);
>
> --
> 2.11.0
>
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [PATCH v2] mmc: meson-gx: remove mmc host on device removal
@ 2017-03-14 16:21 ` Ulf Hansson
0 siblings, 0 replies; 12+ messages in thread
From: Ulf Hansson @ 2017-03-14 16:21 UTC (permalink / raw)
To: Michał Zegan
Cc: Kevin Hilman, Carlo Caione, linux-kernel@vger.kernel.org,
linux-amlogic, linux-mmc@vger.kernel.org
On 18 February 2017 at 18:06, Michał Zegan <webczat@webczatnet.pl> wrote:
> The mmc host was added in meson_mmc_probe, but never removed in
> meson_mmc_remove.
> Fix that by removing the host before deallocating other resources.
>
> Signed-off-by: Michał Zegan <webczat@webczatnet.pl>
> Tested-by: Michał Zegan <webczat@webczatnet.pl>
Thanks, applied for next!
Kind regards
Uffe
> ---
> changes since v1:
> rebased on top of patchset at
> https://patchwork.kernel.org/patch/9581057/
> This is in turn based on patchset at
> https://patchwork.kernel.org/patch/9561215/
>
> drivers/mmc/host/meson-gx-mmc.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/mmc/host/meson-gx-mmc.c b/drivers/mmc/host/meson-gx-mmc.c
> index e759e4c2e4a0..336b6a2e94c6 100644
> --- a/drivers/mmc/host/meson-gx-mmc.c
> +++ b/drivers/mmc/host/meson-gx-mmc.c
> @@ -791,6 +791,8 @@ static int meson_mmc_remove(struct platform_device *pdev)
> {
> struct meson_host *host = dev_get_drvdata(&pdev->dev);
>
> + mmc_remove_host(host->mmc);
> +
> /* disable interrupts */
> writel(0, host->regs + SD_EMMC_IRQ_EN);
>
> --
> 2.11.0
>
^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH] mmc: meson-gx: fix error path when driver initialization fails before enabling clocks
2017-02-18 17:06 ` Michał Zegan
@ 2017-02-28 3:08 ` Kevin Hilman
-1 siblings, 0 replies; 12+ messages in thread
From: Kevin Hilman @ 2017-02-28 3:08 UTC (permalink / raw)
To: linus-amlogic
Micha? Zegan <webczat@webczatnet.pl> writes:
> This patch fixes the case where meson_mmc_probe function fails before
> core_clk is enabled.
> Originally, that would result in a try to disable the core clock, and if
> it was not already enabled, it would result in a kernel warning.
> This issue is similar to the one with div_clk.
> Fix it by introducing another error path used only between successfully
> enabling the core clock, and successfully enabling the div clock.
> That would ensure that core clock is disabled only if it was enabled before.
>
> Signed-off-by: Micha? Zegan <webczat@webczatnet.pl>
Acked-by: Kevin Hilman <khilman@baylibre.com>
> ---
> applies on top of Heiner's patchset v3
> https://patchwork.kernel.org/patch/9581057/
> That in turn applies on top of https://patchwork.kernel.org/patch/9561215/
>
> drivers/mmc/host/meson-gx-mmc.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mmc/host/meson-gx-mmc.c b/drivers/mmc/host/meson-gx-mmc.c
> index 336b6a2e94c6..7917a3fe51ad 100644
> --- a/drivers/mmc/host/meson-gx-mmc.c
> +++ b/drivers/mmc/host/meson-gx-mmc.c
> @@ -752,7 +752,7 @@ static int meson_mmc_probe(struct platform_device *pdev)
>
> ret = meson_mmc_clk_init(host);
> if (ret)
> - goto free_host;
> + goto err_core_clk;
>
> ret = devm_request_threaded_irq(&pdev->dev, irq, meson_mmc_irq,
> meson_mmc_irq_thread, IRQF_SHARED,
> @@ -781,8 +781,9 @@ static int meson_mmc_probe(struct platform_device *pdev)
>
> err_div_clk:
> clk_disable_unprepare(host->cfg_div_clk);
> -free_host:
> +err_core_clk:
> clk_disable_unprepare(host->core_clk);
> +free_host:
> mmc_free_host(mmc);
> return ret;
> }
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] mmc: meson-gx: fix error path when driver initialization fails before enabling clocks
@ 2017-02-28 3:08 ` Kevin Hilman
0 siblings, 0 replies; 12+ messages in thread
From: Kevin Hilman @ 2017-02-28 3:08 UTC (permalink / raw)
To: Michał Zegan
Cc: Carlo Caione, linux-kernel, linux-amlogic, linux-mmc, Ulf Hansson
Michał Zegan <webczat@webczatnet.pl> writes:
> This patch fixes the case where meson_mmc_probe function fails before
> core_clk is enabled.
> Originally, that would result in a try to disable the core clock, and if
> it was not already enabled, it would result in a kernel warning.
> This issue is similar to the one with div_clk.
> Fix it by introducing another error path used only between successfully
> enabling the core clock, and successfully enabling the div clock.
> That would ensure that core clock is disabled only if it was enabled before.
>
> Signed-off-by: Michał Zegan <webczat@webczatnet.pl>
Acked-by: Kevin Hilman <khilman@baylibre.com>
> ---
> applies on top of Heiner's patchset v3
> https://patchwork.kernel.org/patch/9581057/
> That in turn applies on top of https://patchwork.kernel.org/patch/9561215/
>
> drivers/mmc/host/meson-gx-mmc.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mmc/host/meson-gx-mmc.c b/drivers/mmc/host/meson-gx-mmc.c
> index 336b6a2e94c6..7917a3fe51ad 100644
> --- a/drivers/mmc/host/meson-gx-mmc.c
> +++ b/drivers/mmc/host/meson-gx-mmc.c
> @@ -752,7 +752,7 @@ static int meson_mmc_probe(struct platform_device *pdev)
>
> ret = meson_mmc_clk_init(host);
> if (ret)
> - goto free_host;
> + goto err_core_clk;
>
> ret = devm_request_threaded_irq(&pdev->dev, irq, meson_mmc_irq,
> meson_mmc_irq_thread, IRQF_SHARED,
> @@ -781,8 +781,9 @@ static int meson_mmc_probe(struct platform_device *pdev)
>
> err_div_clk:
> clk_disable_unprepare(host->cfg_div_clk);
> -free_host:
> +err_core_clk:
> clk_disable_unprepare(host->core_clk);
> +free_host:
> mmc_free_host(mmc);
> return ret;
> }
^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH] mmc: meson-gx: fix error path when driver initialization fails before enabling clocks
2017-02-18 17:06 ` Michał Zegan
@ 2017-03-14 16:21 ` Ulf Hansson
-1 siblings, 0 replies; 12+ messages in thread
From: Ulf Hansson @ 2017-03-14 16:21 UTC (permalink / raw)
To: linus-amlogic
On 18 February 2017 at 18:06, Micha? Zegan <webczat@webczatnet.pl> wrote:
> This patch fixes the case where meson_mmc_probe function fails before
> core_clk is enabled.
> Originally, that would result in a try to disable the core clock, and if
> it was not already enabled, it would result in a kernel warning.
> This issue is similar to the one with div_clk.
> Fix it by introducing another error path used only between successfully
> enabling the core clock, and successfully enabling the div clock.
> That would ensure that core clock is disabled only if it was enabled before.
>
> Signed-off-by: Micha? Zegan <webczat@webczatnet.pl>
This one didn't apply on my next branch after applying Heiner's
series. Can please re-base and send a new version.
Kind regards
Uffe
> ---
> applies on top of Heiner's patchset v3
> https://patchwork.kernel.org/patch/9581057/
> That in turn applies on top of https://patchwork.kernel.org/patch/9561215/
>
> drivers/mmc/host/meson-gx-mmc.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mmc/host/meson-gx-mmc.c b/drivers/mmc/host/meson-gx-mmc.c
> index 336b6a2e94c6..7917a3fe51ad 100644
> --- a/drivers/mmc/host/meson-gx-mmc.c
> +++ b/drivers/mmc/host/meson-gx-mmc.c
> @@ -752,7 +752,7 @@ static int meson_mmc_probe(struct platform_device *pdev)
>
> ret = meson_mmc_clk_init(host);
> if (ret)
> - goto free_host;
> + goto err_core_clk;
>
> ret = devm_request_threaded_irq(&pdev->dev, irq, meson_mmc_irq,
> meson_mmc_irq_thread, IRQF_SHARED,
> @@ -781,8 +781,9 @@ static int meson_mmc_probe(struct platform_device *pdev)
>
> err_div_clk:
> clk_disable_unprepare(host->cfg_div_clk);
> -free_host:
> +err_core_clk:
> clk_disable_unprepare(host->core_clk);
> +free_host:
> mmc_free_host(mmc);
> return ret;
> }
> --
> 2.11.0
>
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] mmc: meson-gx: fix error path when driver initialization fails before enabling clocks
@ 2017-03-14 16:21 ` Ulf Hansson
0 siblings, 0 replies; 12+ messages in thread
From: Ulf Hansson @ 2017-03-14 16:21 UTC (permalink / raw)
To: Michał Zegan
Cc: Kevin Hilman, Carlo Caione, linux-kernel@vger.kernel.org,
linux-amlogic, linux-mmc@vger.kernel.org
On 18 February 2017 at 18:06, Michał Zegan <webczat@webczatnet.pl> wrote:
> This patch fixes the case where meson_mmc_probe function fails before
> core_clk is enabled.
> Originally, that would result in a try to disable the core clock, and if
> it was not already enabled, it would result in a kernel warning.
> This issue is similar to the one with div_clk.
> Fix it by introducing another error path used only between successfully
> enabling the core clock, and successfully enabling the div clock.
> That would ensure that core clock is disabled only if it was enabled before.
>
> Signed-off-by: Michał Zegan <webczat@webczatnet.pl>
This one didn't apply on my next branch after applying Heiner's
series. Can please re-base and send a new version.
Kind regards
Uffe
> ---
> applies on top of Heiner's patchset v3
> https://patchwork.kernel.org/patch/9581057/
> That in turn applies on top of https://patchwork.kernel.org/patch/9561215/
>
> drivers/mmc/host/meson-gx-mmc.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mmc/host/meson-gx-mmc.c b/drivers/mmc/host/meson-gx-mmc.c
> index 336b6a2e94c6..7917a3fe51ad 100644
> --- a/drivers/mmc/host/meson-gx-mmc.c
> +++ b/drivers/mmc/host/meson-gx-mmc.c
> @@ -752,7 +752,7 @@ static int meson_mmc_probe(struct platform_device *pdev)
>
> ret = meson_mmc_clk_init(host);
> if (ret)
> - goto free_host;
> + goto err_core_clk;
>
> ret = devm_request_threaded_irq(&pdev->dev, irq, meson_mmc_irq,
> meson_mmc_irq_thread, IRQF_SHARED,
> @@ -781,8 +781,9 @@ static int meson_mmc_probe(struct platform_device *pdev)
>
> err_div_clk:
> clk_disable_unprepare(host->cfg_div_clk);
> -free_host:
> +err_core_clk:
> clk_disable_unprepare(host->core_clk);
> +free_host:
> mmc_free_host(mmc);
> return ret;
> }
> --
> 2.11.0
>
^ permalink raw reply [flat|nested] 12+ messages in thread