* Re: [PATCH] ARM64: dts: meson-gx: Fix sensors reporting from SCP
@ 2017-06-05 21:54 ` Kevin Hilman
0 siblings, 0 replies; 9+ messages in thread
From: Kevin Hilman @ 2017-06-05 21:54 UTC (permalink / raw)
To: Carlo Caione
Cc: robh+dt-DgEjT+Ai2ygdnm+yROfE0A, mark.rutland-5wv7dgnIgG8,
devicetree-u79uwXL29TY76Z2rM5mHXA,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
linux-amlogic-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
linux-6IF/jdPJHihWk0Htik3J/w, Carlo Caione
Carlo Caione <carlo-KA+7E9HrN00dnm+yROfE0A@public.gmane.org> writes:
> From: Carlo Caione <carlo-6IF/jdPJHihWk0Htik3J/w@public.gmane.org>
>
> Switch to use the new compatible for the SCPI sensors so that the
> sensor readings are reported using the correct scale.
>
> Signed-off-by: Carlo Caione <carlo-6IF/jdPJHihWk0Htik3J/w@public.gmane.org>
> ---
> arch/arm64/boot/dts/amlogic/meson-gx.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/amlogic/meson-gx.dtsi b/arch/arm64/boot/dts/amlogic/meson-gx.dtsi
> index 436b875..3128fa5 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-gx.dtsi
> +++ b/arch/arm64/boot/dts/amlogic/meson-gx.dtsi
> @@ -200,7 +200,7 @@
> };
>
> scpi_sensors: sensors {
> - compatible = "arm,scpi-sensors";
> + compatible = "amlogic,meson-gxbb-scpi-sensors";
Shouldn't this be:
compatible = "amlogic,meson-gxbb-scpi-sensors", "arm,scpi-sensors";
For a safe fallback on kernels without the new compatible?
Kevin
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 9+ messages in thread* [PATCH] ARM64: dts: meson-gx: Fix sensors reporting from SCP
@ 2017-06-05 21:54 ` Kevin Hilman
0 siblings, 0 replies; 9+ messages in thread
From: Kevin Hilman @ 2017-06-05 21:54 UTC (permalink / raw)
To: linux-arm-kernel
Carlo Caione <carlo@caione.org> writes:
> From: Carlo Caione <carlo@endlessm.com>
>
> Switch to use the new compatible for the SCPI sensors so that the
> sensor readings are reported using the correct scale.
>
> Signed-off-by: Carlo Caione <carlo@endlessm.com>
> ---
> arch/arm64/boot/dts/amlogic/meson-gx.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/amlogic/meson-gx.dtsi b/arch/arm64/boot/dts/amlogic/meson-gx.dtsi
> index 436b875..3128fa5 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-gx.dtsi
> +++ b/arch/arm64/boot/dts/amlogic/meson-gx.dtsi
> @@ -200,7 +200,7 @@
> };
>
> scpi_sensors: sensors {
> - compatible = "arm,scpi-sensors";
> + compatible = "amlogic,meson-gxbb-scpi-sensors";
Shouldn't this be:
compatible = "amlogic,meson-gxbb-scpi-sensors", "arm,scpi-sensors";
For a safe fallback on kernels without the new compatible?
Kevin
^ permalink raw reply [flat|nested] 9+ messages in thread* [PATCH] ARM64: dts: meson-gx: Fix sensors reporting from SCP
2017-06-05 21:54 ` Kevin Hilman
(?)
@ 2017-06-06 6:20 ` Carlo Caione
-1 siblings, 0 replies; 9+ messages in thread
From: Carlo Caione @ 2017-06-06 6:20 UTC (permalink / raw)
To: linus-amlogic
On Mon, Jun 5, 2017 at 11:54 PM, Kevin Hilman <khilman@baylibre.com> wrote:
> Carlo Caione <carlo@caione.org> writes:
>
>> From: Carlo Caione <carlo@endlessm.com>
>>
>> Switch to use the new compatible for the SCPI sensors so that the
>> sensor readings are reported using the correct scale.
>>
>> Signed-off-by: Carlo Caione <carlo@endlessm.com>
>> ---
>> arch/arm64/boot/dts/amlogic/meson-gx.dtsi | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/arm64/boot/dts/amlogic/meson-gx.dtsi b/arch/arm64/boot/dts/amlogic/meson-gx.dtsi
>> index 436b875..3128fa5 100644
>> --- a/arch/arm64/boot/dts/amlogic/meson-gx.dtsi
>> +++ b/arch/arm64/boot/dts/amlogic/meson-gx.dtsi
>> @@ -200,7 +200,7 @@
>> };
>>
>> scpi_sensors: sensors {
>> - compatible = "arm,scpi-sensors";
>> + compatible = "amlogic,meson-gxbb-scpi-sensors";
>
> Shouldn't this be:
>
> compatible = "amlogic,meson-gxbb-scpi-sensors", "arm,scpi-sensors";
>
> For a safe fallback on kernels without the new compatible?
Yeah, it should.
--
Carlo Caione
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH] ARM64: dts: meson-gx: Fix sensors reporting from SCP
@ 2017-06-06 6:20 ` Carlo Caione
0 siblings, 0 replies; 9+ messages in thread
From: Carlo Caione @ 2017-06-06 6:20 UTC (permalink / raw)
To: Kevin Hilman
Cc: Carlo Caione, Mark Rutland, devicetree,
robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, Carlo Caione,
open list:ARM/Amlogic Meson..., Linux Upstreaming Team,
linux-arm-kernel
On Mon, Jun 5, 2017 at 11:54 PM, Kevin Hilman <khilman-rdvid1DuHRBWk0Htik3J/w@public.gmane.org> wrote:
> Carlo Caione <carlo-KA+7E9HrN00dnm+yROfE0A@public.gmane.org> writes:
>
>> From: Carlo Caione <carlo-6IF/jdPJHihWk0Htik3J/w@public.gmane.org>
>>
>> Switch to use the new compatible for the SCPI sensors so that the
>> sensor readings are reported using the correct scale.
>>
>> Signed-off-by: Carlo Caione <carlo-6IF/jdPJHihWk0Htik3J/w@public.gmane.org>
>> ---
>> arch/arm64/boot/dts/amlogic/meson-gx.dtsi | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/arm64/boot/dts/amlogic/meson-gx.dtsi b/arch/arm64/boot/dts/amlogic/meson-gx.dtsi
>> index 436b875..3128fa5 100644
>> --- a/arch/arm64/boot/dts/amlogic/meson-gx.dtsi
>> +++ b/arch/arm64/boot/dts/amlogic/meson-gx.dtsi
>> @@ -200,7 +200,7 @@
>> };
>>
>> scpi_sensors: sensors {
>> - compatible = "arm,scpi-sensors";
>> + compatible = "amlogic,meson-gxbb-scpi-sensors";
>
> Shouldn't this be:
>
> compatible = "amlogic,meson-gxbb-scpi-sensors", "arm,scpi-sensors";
>
> For a safe fallback on kernels without the new compatible?
Yeah, it should.
--
Carlo Caione
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 9+ messages in thread* [PATCH] ARM64: dts: meson-gx: Fix sensors reporting from SCP
@ 2017-06-06 6:20 ` Carlo Caione
0 siblings, 0 replies; 9+ messages in thread
From: Carlo Caione @ 2017-06-06 6:20 UTC (permalink / raw)
To: linux-arm-kernel
On Mon, Jun 5, 2017 at 11:54 PM, Kevin Hilman <khilman@baylibre.com> wrote:
> Carlo Caione <carlo@caione.org> writes:
>
>> From: Carlo Caione <carlo@endlessm.com>
>>
>> Switch to use the new compatible for the SCPI sensors so that the
>> sensor readings are reported using the correct scale.
>>
>> Signed-off-by: Carlo Caione <carlo@endlessm.com>
>> ---
>> arch/arm64/boot/dts/amlogic/meson-gx.dtsi | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/arm64/boot/dts/amlogic/meson-gx.dtsi b/arch/arm64/boot/dts/amlogic/meson-gx.dtsi
>> index 436b875..3128fa5 100644
>> --- a/arch/arm64/boot/dts/amlogic/meson-gx.dtsi
>> +++ b/arch/arm64/boot/dts/amlogic/meson-gx.dtsi
>> @@ -200,7 +200,7 @@
>> };
>>
>> scpi_sensors: sensors {
>> - compatible = "arm,scpi-sensors";
>> + compatible = "amlogic,meson-gxbb-scpi-sensors";
>
> Shouldn't this be:
>
> compatible = "amlogic,meson-gxbb-scpi-sensors", "arm,scpi-sensors";
>
> For a safe fallback on kernels without the new compatible?
Yeah, it should.
--
Carlo Caione
^ permalink raw reply [flat|nested] 9+ messages in thread