* [PATCH] irqdomain: fix typo in IRQ_BITMAP_BITS definition
@ 2012-04-19 16:14 Andreas Schwab
2012-04-19 16:55 ` Grant Likely
0 siblings, 1 reply; 3+ messages in thread
From: Andreas Schwab @ 2012-04-19 16:14 UTC (permalink / raw)
To: Grant Likely; +Cc: Thomas Gleixner, linux-kernel
8196 is an odd number, change it to the intended 8192.
Signed-off-by: Andreas Schwab <schwab@linux-m68k.org>
---
Shouldn't it actually be just 8192 or maybe max(NR_IRQS, 8192)?
kernel/irq/internals.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/irq/internals.h b/kernel/irq/internals.h
index 8e5c56b..6430d0f 100644
--- a/kernel/irq/internals.h
+++ b/kernel/irq/internals.h
@@ -8,7 +8,7 @@
#include <linux/irqdesc.h>
#ifdef CONFIG_SPARSE_IRQ
-# define IRQ_BITMAP_BITS (NR_IRQS + 8196)
+# define IRQ_BITMAP_BITS (NR_IRQS + 8192)
#else
# define IRQ_BITMAP_BITS NR_IRQS
#endif
--
1.7.10
--
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] irqdomain: fix typo in IRQ_BITMAP_BITS definition
2012-04-19 16:14 [PATCH] irqdomain: fix typo in IRQ_BITMAP_BITS definition Andreas Schwab
@ 2012-04-19 16:55 ` Grant Likely
2012-04-19 19:02 ` Thomas Gleixner
0 siblings, 1 reply; 3+ messages in thread
From: Grant Likely @ 2012-04-19 16:55 UTC (permalink / raw)
To: Andreas Schwab; +Cc: Thomas Gleixner, linux-kernel
On Thu, Apr 19, 2012 at 10:14 AM, Andreas Schwab <schwab@linux-m68k.org> wrote:
> 8196 is an odd number, change it to the intended 8192.
>
> Signed-off-by: Andreas Schwab <schwab@linux-m68k.org>
> ---
> Shouldn't it actually be just 8192 or maybe max(NR_IRQS, 8192)?
The number is completely arbitrary. It doesn't actually matter.
g.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] irqdomain: fix typo in IRQ_BITMAP_BITS definition
2012-04-19 16:55 ` Grant Likely
@ 2012-04-19 19:02 ` Thomas Gleixner
0 siblings, 0 replies; 3+ messages in thread
From: Thomas Gleixner @ 2012-04-19 19:02 UTC (permalink / raw)
To: Grant Likely; +Cc: Andreas Schwab, linux-kernel
On Thu, 19 Apr 2012, Grant Likely wrote:
> On Thu, Apr 19, 2012 at 10:14 AM, Andreas Schwab <schwab@linux-m68k.org> wrote:
> > 8196 is an odd number, change it to the intended 8192.
> >
> > Signed-off-by: Andreas Schwab <schwab@linux-m68k.org>
> > ---
> > Shouldn't it actually be just 8192 or maybe max(NR_IRQS, 8192)?
>
> The number is completely arbitrary. It doesn't actually matter.
Right, it just makes sure that the bitmap is way larger than the
NR_IRQS value, so we can deal with all the dynamic allocated
interrupts.
Thanks,
tglx
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-04-19 19:02 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-04-19 16:14 [PATCH] irqdomain: fix typo in IRQ_BITMAP_BITS definition Andreas Schwab
2012-04-19 16:55 ` Grant Likely
2012-04-19 19:02 ` Thomas Gleixner
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.