From: khilman@baylibre.com (Kevin Hilman)
To: linus-amlogic@lists.infradead.org
Subject: [PATCH] phy: meson-usb2: Fix build dependency
Date: Mon, 19 Sep 2016 09:44:08 -0700 [thread overview]
Message-ID: <m2r38fhmav.fsf@baylibre.com> (raw)
In-Reply-To: <CAFBinCBJPHMkYneKKU+KYVve3u3Svvcbu0Ux-L8VC21DvxWZng@mail.gmail.com> (Martin Blumenstingl's message of "Sun, 18 Sep 2016 23:41:43 +0200")
Martin Blumenstingl <martin.blumenstingl@googlemail.com> writes:
> Hi Axel,
>
> On Fri, Sep 16, 2016 at 4:07 AM, Axel Lin <axel.lin@ingics.com> wrote:
>> of_usb_get_dr_mode_by_phy will not be compiled if !USB_COMMON, fix below
>> build error:
>>
>> drivers/built-in.o: In function `phy_meson_usb2_probe':
>> debugfs.c:(.text+0x76b4): undefined reference to `of_usb_get_dr_mode_by_phy'
>> Makefile:961: recipe for target 'vmlinux' failed
>> make: *** [vmlinux] Error 1
>>
>> Signed-off-by: Axel Lin <axel.lin@ingics.com>
>> ---
>> drivers/phy/Kconfig | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/drivers/phy/Kconfig b/drivers/phy/Kconfig
>> index 6ad87ec..cc27c12 100644
>> --- a/drivers/phy/Kconfig
>> +++ b/drivers/phy/Kconfig
>> @@ -458,6 +458,8 @@ config PHY_MESON_USB2
>> tristate "Meson USB2 PHY driver"
>> default ARCH_MESON
>> depends on OF && (ARCH_MESON || COMPILE_TEST)
>> + depends on USB_SUPPORT
>> + select USB_COMMON
>> select GENERIC_PHY
>> help
>> Enable this to support the Meson USB2 PHYs found in Meson8b
>> --
>> 2.7.4
>>
> thanks for this patch!
>
> How do we handle patches for drivers which will (unfortunately) not
> land in the linux 4.8 - should I integrate that into v3 of the patch
> (which I'll have to send anyways) or do we keep them separate?
> Maybe Kishon and/or Kevin can share their opinion on this.
It's up to Kishon if he wants a v3, or if he can fold in the fix
himself.
Kevin
WARNING: multiple messages have this Message-ID (diff)
From: Kevin Hilman <khilman@baylibre.com>
To: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Cc: Axel Lin <axel.lin@ingics.com>,
Kishon Vijay Abraham I <kishon@ti.com>,
Jerome Brunet <jbrunet@baylibre.com>,
linux-kernel@vger.kernel.org, linux-amlogic@lists.infradead.org
Subject: Re: [PATCH] phy: meson-usb2: Fix build dependency
Date: Mon, 19 Sep 2016 09:44:08 -0700 [thread overview]
Message-ID: <m2r38fhmav.fsf@baylibre.com> (raw)
In-Reply-To: <CAFBinCBJPHMkYneKKU+KYVve3u3Svvcbu0Ux-L8VC21DvxWZng@mail.gmail.com> (Martin Blumenstingl's message of "Sun, 18 Sep 2016 23:41:43 +0200")
Martin Blumenstingl <martin.blumenstingl@googlemail.com> writes:
> Hi Axel,
>
> On Fri, Sep 16, 2016 at 4:07 AM, Axel Lin <axel.lin@ingics.com> wrote:
>> of_usb_get_dr_mode_by_phy will not be compiled if !USB_COMMON, fix below
>> build error:
>>
>> drivers/built-in.o: In function `phy_meson_usb2_probe':
>> debugfs.c:(.text+0x76b4): undefined reference to `of_usb_get_dr_mode_by_phy'
>> Makefile:961: recipe for target 'vmlinux' failed
>> make: *** [vmlinux] Error 1
>>
>> Signed-off-by: Axel Lin <axel.lin@ingics.com>
>> ---
>> drivers/phy/Kconfig | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/drivers/phy/Kconfig b/drivers/phy/Kconfig
>> index 6ad87ec..cc27c12 100644
>> --- a/drivers/phy/Kconfig
>> +++ b/drivers/phy/Kconfig
>> @@ -458,6 +458,8 @@ config PHY_MESON_USB2
>> tristate "Meson USB2 PHY driver"
>> default ARCH_MESON
>> depends on OF && (ARCH_MESON || COMPILE_TEST)
>> + depends on USB_SUPPORT
>> + select USB_COMMON
>> select GENERIC_PHY
>> help
>> Enable this to support the Meson USB2 PHYs found in Meson8b
>> --
>> 2.7.4
>>
> thanks for this patch!
>
> How do we handle patches for drivers which will (unfortunately) not
> land in the linux 4.8 - should I integrate that into v3 of the patch
> (which I'll have to send anyways) or do we keep them separate?
> Maybe Kishon and/or Kevin can share their opinion on this.
It's up to Kishon if he wants a v3, or if he can fold in the fix
himself.
Kevin
next prev parent reply other threads:[~2016-09-19 16:44 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-16 2:07 [PATCH] phy: meson-usb2: Fix build dependency Axel Lin
2016-09-18 21:41 ` Martin Blumenstingl
2016-09-18 21:41 ` Martin Blumenstingl
2016-09-19 16:44 ` Kevin Hilman [this message]
2016-09-19 16:44 ` Kevin Hilman
2016-09-21 4:06 ` Kishon Vijay Abraham I
2016-09-21 4:06 ` Kishon Vijay Abraham I
2016-09-21 4:13 ` Axel Lin
2016-09-21 4:13 ` Axel Lin
2016-09-21 5:11 ` Kevin Hilman
2016-09-21 5:11 ` Kevin Hilman
2016-09-26 5:03 ` Kishon Vijay Abraham I
2016-09-26 5:03 ` Kishon Vijay Abraham I
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2r38fhmav.fsf@baylibre.com \
--to=khilman@baylibre.com \
--cc=linus-amlogic@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.