From: Kevin Hilman <khilman@baylibre.com>
To: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
alsa-devel@alsa-project.org, Sekhar Nori <nsekhar@ti.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ASoC: simple-card-utils: add missing MODULE_xxx()
Date: Tue, 02 Aug 2016 11:50:48 -0700 [thread overview]
Message-ID: <m2r3a7qa2f.fsf@baylibre.com> (raw)
In-Reply-To: <8760rjj20g.wl%kuninori.morimoto.gx@renesas.com> (Kuninori Morimoto's message of "Tue, 2 Aug 2016 03:22:08 +0000")
Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> writes:
> From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
>
> simple-card-utils might be used as module, but MODULE_xxx()
> information was missed. This patch adds it.
> Otherwise, we will have below error, and can't use it.
> Specil thanks to Kevin.
>
>> insmod simple-card-utils.ko
> simple_card_utils: module license 'unspecified' taints kernel.
> Disabling lock debugging due to kernel taint
> simple_card_utils: Unknown symbol snd_soc_of_parse_daifmt (err 0)
> simple_card_utils: Unknown symbol snd_soc_of_parse_card_name (err 0)
> insmod: can't insert 'simple-card-utils.ko': \
> unknown symbol in module, or unknown parameter
>
> Reported-by: Kevin Hilman <khilman@baylibre.com>
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> ---
>
>>> Kevin
>
> Thank you for your report. I think this patch can solve your issue.
> Can you check this ?
Your patch works, but as Mark pointed out, I didn't think that this was
the right fix as this isn't a module, but just library.
Kevin
WARNING: multiple messages have this Message-ID (diff)
From: Kevin Hilman <khilman@baylibre.com>
To: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, <alsa-devel@alsa-project.org>,
Sekhar Nori <nsekhar@ti.com>, Jaroslav Kysela <perex@perex.cz>,
Takashi Iwai <tiwai@suse.com>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ASoC: simple-card-utils: add missing MODULE_xxx()
Date: Tue, 02 Aug 2016 11:50:48 -0700 [thread overview]
Message-ID: <m2r3a7qa2f.fsf@baylibre.com> (raw)
In-Reply-To: <8760rjj20g.wl%kuninori.morimoto.gx@renesas.com> (Kuninori Morimoto's message of "Tue, 2 Aug 2016 03:22:08 +0000")
Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> writes:
> From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
>
> simple-card-utils might be used as module, but MODULE_xxx()
> information was missed. This patch adds it.
> Otherwise, we will have below error, and can't use it.
> Specil thanks to Kevin.
>
>> insmod simple-card-utils.ko
> simple_card_utils: module license 'unspecified' taints kernel.
> Disabling lock debugging due to kernel taint
> simple_card_utils: Unknown symbol snd_soc_of_parse_daifmt (err 0)
> simple_card_utils: Unknown symbol snd_soc_of_parse_card_name (err 0)
> insmod: can't insert 'simple-card-utils.ko': \
> unknown symbol in module, or unknown parameter
>
> Reported-by: Kevin Hilman <khilman@baylibre.com>
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> ---
>
>>> Kevin
>
> Thank you for your report. I think this patch can solve your issue.
> Can you check this ?
Your patch works, but as Mark pointed out, I didn't think that this was
the right fix as this isn't a module, but just library.
Kevin
next prev parent reply other threads:[~2016-08-02 18:50 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-01 23:36 [PATCH] ASoC: simple-card: fix module load "unknown symbol" issue Kevin Hilman
2016-08-01 23:36 ` Kevin Hilman
2016-08-02 1:13 ` Kuninori Morimoto
2016-08-02 1:13 ` Kuninori Morimoto
2016-08-02 2:40 ` Kevin Hilman
2016-08-02 3:22 ` [PATCH] ASoC: simple-card-utils: add missing MODULE_xxx() Kuninori Morimoto
2016-08-02 3:22 ` Kuninori Morimoto
2016-08-02 18:11 ` Mark Brown
2016-08-02 18:11 ` Mark Brown
2016-08-02 18:50 ` Kevin Hilman [this message]
2016-08-02 18:50 ` Kevin Hilman
2016-08-02 19:41 ` Mark Brown
2016-08-02 19:41 ` Mark Brown
2016-08-08 14:18 ` [PATCH] ASoC: simple-card: fix module load "unknown symbol" issue Sekhar Nori
2016-08-08 14:18 ` Sekhar Nori
2016-08-09 0:26 ` Kuninori Morimoto
2016-08-09 0:26 ` Kuninori Morimoto
2016-08-09 6:49 ` Sekhar Nori
2016-08-09 6:49 ` Sekhar Nori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2r3a7qa2f.fsf@baylibre.com \
--to=khilman@baylibre.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nsekhar@ti.com \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.