All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andreas Schwab <schwab@linux-m68k.org>
To: "H. Peter Anvin" <hpa@zytor.com>
Cc: Sam Ravnborg <sam@ravnborg.org>,
	linux-mips@linux-mips.org, linux-m68k@vger.kernel.org,
	linux-ia64@vger.kernel.org, linux-sh@vger.kernel.org,
	Denys Vlasenko <vda.linux@googlemail.com>,
	Tim Abbott <tabbott@MIT.EDU>,
	Heiko Carstens <heiko.carstens@de.ibm.com>,
	linuxppc-dev@ozlabs.org, Paul Mackerras <paulus@samba.org>,
	Greg Ungerer <gerg@uclinux.org>,
	sparclinux@vger.kernel.org, Thomas Gleixner <tglx@linutronix.de>,
	linux-s390@vger.kernel.org,
	Jesper Nilsson <jesper.nilsson@axis.com>,
	Yoshinori Sato <ysato@users.sourceforge.jp>,
	Helge Deller <deller@gmx.de>, Ingo Molnar <mingo@redhat.com>,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	Russell King <rmk+kernel@arm.linux.org.uk>,
	user-mode-linux-devel@lists.sourceforge.net,
	microblaze-uclinux@itee.uq.edu.au, Jeff Dike <jdike@addtoit.com>,
	Jeff Arnold <jbarnold@MIT.EDU>,
	dev-etrax@axis.com, Mikael Starvik <starvik@axis.com>
Subject: Re: [PATCH v2 1/6] Add new macros for page-aligned data and bss sections.
Date: Sat, 02 May 2009 01:02:12 +0200	[thread overview]
Message-ID: <m2tz44o2a3.fsf@igel.home> (raw)
In-Reply-To: <49FB35C4.6060107@zytor.com> (H. Peter Anvin's message of "Fri, 01 May 2009 10:47:48 -0700")

"H. Peter Anvin" <hpa@zytor.com> writes:

> Sam Ravnborg wrote:
>>>
>>> What's wrong with @?
>> arm does not support it :-(
>> I recall it denote a comment in arm assembler.
>> 
>> I could do some magic to detect the ARM case but I'm reluctant to do so.
>> I could also ignore the arm issue for now as it is not used by arm,
>> but that strikes me as the wrong approach.
>> 
>
> If we really have to use different tokens, I would say:
>
> #ifdef __ARM__
> # define _PROGBITS %progbits	/* or whatever */
> # define _NOBITS   %nobits
> #else
> # define _PROGBITS @progbits
> # define _NOBITS   @nobits
> #endif

GAS has always supported both '@' and '%', so '%' can be used
everywhere.

Andreas.

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."


WARNING: multiple messages have this Message-ID (diff)
From: Andreas Schwab <schwab@linux-m68k.org>
To: "H. Peter Anvin" <hpa@zytor.com>
Cc: Sam Ravnborg <sam@ravnborg.org>,
	linux-mips@linux-mips.org, linux-m68k@vger.kernel.org,
	linux-ia64@vger.kernel.org, linux-sh@vger.kernel.org,
	Denys Vlasenko <vda.linux@googlemail.com>,
	Tim Abbott <tabbott@MIT.EDU>,
	Heiko Carstens <heiko.carstens@de.ibm.com>,
	linuxppc-dev@ozlabs.org, Paul Mackerras <paulus@samba.org>,
	Greg Ungerer <gerg@uclinux.org>,
	sparclinux@vger.kernel.org, Thomas Gleixner <tglx@linutronix.de>,
	linux-s390@vger.kernel.org,
	Jesper Nilsson <jesper.nilsson@axis.com>,
	Yoshinori Sato <ysato@users.sourceforge.jp>,
	Helge Deller <deller@gmx.de>, Ingo Molnar <mingo@redhat.com>,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	Russell King <rmk+kernel@arm.linux.org.uk>,
	user-mode-linux-devel@lists.sourceforge.net,
	microblaze-uclinux@itee.uq.edu.au, Jeff Dike <jdike@addtoit.com>,
	Jeff Arnold <jbarnold@MIT.EDU>,
	dev-etrax@axis.com, Mikael Starvik <starvik@axis.com>,
	Cyrill Gorcunov <gorcunov@openvz.org>,
	Michal Simek <monstr@monstr.eu>, Waseem Daher <wdaher@MIT.EDU>,
	Richard Henderson <rth@twiddle.net>,
	Chris Zankel <chris@zankel.net>, Bryan Wu <cooloney@kernel.org>,
	Tony Luck <tony.luck@intel.com>,
	linux-parisc@vger.kernel.org,
	Haavard Skinnemoen <hskinnemoen@atmel.com>,
	Hirokazu Takata <takata@linux-m32r.org>,
	Linux kernel mailing list <linux-kernel@vger.kernel.org>,
	Ralf Baechle <ralf@linux-mips.org>,
	Anders Kaseorg <andersk@MIT.EDU>,
	Kyle McMartin <kyle@mcmartin.ca>,
	Paul Mundt <lethal@linux-sh.org>,
	linux-alpha@vger.kernel.org,
	Martin Schwidefsky <schwidefsky@de.ibm.com>,
	uclinux-dist-devel@blackfin.uclinux.org,
	Linus Torvalds <torvalds@linux-foundation.org>,
	"David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH v2 1/6] Add new macros for page-aligned data and bss sections.
Date: Sat, 02 May 2009 01:02:12 +0200	[thread overview]
Message-ID: <m2tz44o2a3.fsf@igel.home> (raw)
In-Reply-To: <49FB35C4.6060107@zytor.com> (H. Peter Anvin's message of "Fri, 01 May 2009 10:47:48 -0700")

"H. Peter Anvin" <hpa@zytor.com> writes:

> Sam Ravnborg wrote:
>>>
>>> What's wrong with @?
>> arm does not support it :-(
>> I recall it denote a comment in arm assembler.
>> 
>> I could do some magic to detect the ARM case but I'm reluctant to do so.
>> I could also ignore the arm issue for now as it is not used by arm,
>> but that strikes me as the wrong approach.
>> 
>
> If we really have to use different tokens, I would say:
>
> #ifdef __ARM__
> # define _PROGBITS %progbits	/* or whatever */
> # define _NOBITS   %nobits
> #else
> # define _PROGBITS @progbits
> # define _NOBITS   @nobits
> #endif

GAS has always supported both '@' and '%', so '%' can be used
everywhere.

Andreas.

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."

WARNING: multiple messages have this Message-ID (diff)
From: Andreas Schwab <schwab@linux-m68k.org>
To: "H. Peter Anvin" <hpa@zytor.com>
Cc: linux-mips@linux-mips.org, linux-m68k@vger.kernel.org,
	linux-ia64@vger.kernel.org, linux-sh@vger.kernel.org,
	Denys Vlasenko <vda.linux@googlemail.com>,
	Tim Abbott <tabbott@MIT.EDU>,
	Heiko Carstens <heiko.carstens@de.ibm.com>,
	linuxppc-dev@ozlabs.org, Waseem,
	Paul Mackerras <paulus@samba.org>,
	Greg Ungerer <gerg@uclinux.org>,
	sparclinux@vger.kernel.org, Sam Ravnborg <sam@ravnborg.org>,
	Bryan Wu <cooloney@kernel.org>,
	linux-s390@vger.kernel.org,
	Jesper Nilsson <jesper.nilsson@axis.com>,
	Yoshinori Sato <ysato@users.sourceforge.jp>,
	"David S. Miller" <davem@davemloft.net>,
	Helge Deller <deller@gmx.de>, Ingo Molnar <mingo@redhat.com>,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	Russell King <rmk+kernel@arm.linux.org.uk>,
	user-mode-linux-devel@lists.sourceforge.net,
	microblaze-uclinux@itee.uq.edu.au, Jeff Dike <jdike@addtoit.com>,
	Jeff Arnold <jbarnold@MIT.EDU>, Michal Simek <monstr@monstr.eu>,
	Mikael Starvik <starvik@axis.com>,
	Cyrill Gorcunov <gorcunov@openvz.org>,
	Thomas Gleixner <tglx@linutronix.de>, Daher <wdaher@MIT.EDU>,
	Richard Henderson <rth@twiddle.net>,
	Chris Zankel <chris@zankel.net>,
	dev-etrax@axis.com, Tony Luck <tony.luck@intel.com>,
	Haavard Skinnemoen <hskinnemoen@atmel.com>,
	linux-parisc@vger.kernel.org,
	Linux kernel mailing list <linux-kernel@vger.kernel.org>,
	Ralf Baechle <ralf@linux-mips.org>,
	Anders Kaseorg <andersk@MIT.EDU>,
	Kyle McMartin <kyle@mcmartin.ca>,
	Paul Mundt <lethal@linux-sh.org>,
	linux-alpha@vger.kernel.org,
	Martin Schwidefsky <schwidefsky@de.ibm.com>,
	uclinux-dist-devel@blackfin.uclinux.org,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Hirokazu Takata <takata@linux-m32r.org>
Subject: Re: [PATCH v2 1/6] Add new macros for page-aligned data and bss sections.
Date: Sat, 02 May 2009 01:02:12 +0200	[thread overview]
Message-ID: <m2tz44o2a3.fsf@igel.home> (raw)
In-Reply-To: <49FB35C4.6060107@zytor.com> (H. Peter Anvin's message of "Fri, 01 May 2009 10:47:48 -0700")

"H. Peter Anvin" <hpa@zytor.com> writes:

> Sam Ravnborg wrote:
>>>
>>> What's wrong with @?
>> arm does not support it :-(
>> I recall it denote a comment in arm assembler.
>> 
>> I could do some magic to detect the ARM case but I'm reluctant to do so.
>> I could also ignore the arm issue for now as it is not used by arm,
>> but that strikes me as the wrong approach.
>> 
>
> If we really have to use different tokens, I would say:
>
> #ifdef __ARM__
> # define _PROGBITS %progbits	/* or whatever */
> # define _NOBITS   %nobits
> #else
> # define _PROGBITS @progbits
> # define _NOBITS   @nobits
> #endif

GAS has always supported both '@' and '%', so '%' can be used
everywhere.

Andreas.

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."

  reply	other threads:[~2009-05-01 23:02 UTC|newest]

Thread overview: 95+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-30 19:54 [PATCH v2 0/6] macros for section name cleanup Tim Abbott
2009-04-30 19:54 ` Tim Abbott
2009-04-30 19:54 ` Tim Abbott
2009-04-30 19:54 ` Tim Abbott
2009-04-30 19:54 ` Tim Abbott
     [not found] ` <1241121253-32341-1-git-send-email-tabbott-3s7WtUTddSA@public.gmane.org>
2009-04-30 19:54   ` [PATCH v2 1/6] Add new macros for page-aligned data and bss sections Tim Abbott
2009-04-30 19:54     ` Tim Abbott
2009-04-30 19:54     ` Tim Abbott
2009-04-30 19:54     ` Tim Abbott
2009-04-30 19:54     ` Tim Abbott
     [not found]     ` <1241121253-32341-2-git-send-email-tabbott-3s7WtUTddSA@public.gmane.org>
2009-04-30 19:54       ` [PATCH v2 2/6] Add new NOSAVE_DATA linker script macro Tim Abbott
2009-04-30 19:54         ` Tim Abbott
2009-04-30 19:54         ` Tim Abbott
2009-04-30 19:54         ` Tim Abbott
2009-04-30 19:54         ` Tim Abbott
2009-04-30 19:54         ` [PATCH v2 3/6] Add new CACHELINE_ALIGNED_DATA " Tim Abbott
2009-04-30 19:54           ` Tim Abbott
2009-04-30 19:54           ` Tim Abbott
2009-04-30 19:54           ` Tim Abbott
2009-04-30 19:54           ` Tim Abbott
2009-04-30 19:54           ` Tim Abbott
2009-04-30 19:54           ` [PATCH v2 4/6] Add new INIT_TASK_DATA() " Tim Abbott
2009-04-30 19:54             ` Tim Abbott
2009-04-30 19:54             ` Tim Abbott
2009-04-30 19:54             ` Tim Abbott
2009-04-30 19:54             ` Tim Abbott
2009-04-30 19:54             ` Tim Abbott
2009-04-30 19:54             ` [PATCH v2 5/6] Add new READ_MOSTLY_DATA(align) " Tim Abbott
2009-04-30 19:54               ` Tim Abbott
2009-04-30 19:54               ` Tim Abbott
2009-04-30 19:54               ` Tim Abbott
2009-04-30 19:54               ` Tim Abbott
2009-04-30 19:54               ` Tim Abbott
2009-04-30 19:54               ` [PATCH v2 6/6] Add support for __read_mostly to linux/cache.h Tim Abbott
2009-04-30 19:54                 ` Tim Abbott
2009-04-30 19:54                 ` Tim Abbott
2009-04-30 19:54                 ` Tim Abbott
2009-04-30 19:54                 ` Tim Abbott
2009-05-01  9:21         ` [PATCH v2 2/6] Add new NOSAVE_DATA linker script macro Sam Ravnborg
2009-05-01  9:21           ` Sam Ravnborg
2009-05-01  9:21           ` Sam Ravnborg
2009-05-01  9:21           ` Sam Ravnborg
2009-05-01  9:21           ` Sam Ravnborg
2009-05-01  9:18     ` [PATCH v2 1/6] Add new macros for page-aligned data and bss sections Sam Ravnborg
2009-05-01  9:18       ` Sam Ravnborg
2009-05-01  9:18       ` Sam Ravnborg
2009-05-01  9:18       ` Sam Ravnborg
2009-05-01  9:18       ` Sam Ravnborg
2009-05-01 13:54       ` Tim Abbott
2009-05-01 13:54         ` Tim Abbott
2009-05-01 13:54         ` Tim Abbott
2009-05-01 13:54         ` Tim Abbott
2009-05-01 13:54         ` Tim Abbott
     [not found]         ` <alpine.DEB.1.10.0905010951100.3955-KERi1O17UK+7LhyUQnA0IJVzexx5G7lz@public.gmane.org>
2009-05-01 16:33           ` H. Peter Anvin
2009-05-01 16:33             ` H. Peter Anvin
2009-05-01 16:33             ` H. Peter Anvin
2009-05-01 16:33             ` H. Peter Anvin
2009-05-01 17:17             ` Sam Ravnborg
2009-05-01 17:17               ` Sam Ravnborg
2009-05-01 17:17               ` Sam Ravnborg
2009-05-01 17:17               ` Sam Ravnborg
     [not found]               ` <20090501171717.GA26401-QabhHTsIXMSnlFQ6Q1D1Y0B+6BGkLq7r@public.gmane.org>
2009-05-01 17:18                 ` H. Peter Anvin
2009-05-01 17:18                   ` H. Peter Anvin
2009-05-01 17:18                   ` H. Peter Anvin
2009-05-01 17:18                   ` H. Peter Anvin
2009-05-01 17:44                   ` Sam Ravnborg
2009-05-01 17:44                     ` Sam Ravnborg
2009-05-01 17:44                     ` Sam Ravnborg
2009-05-01 17:44                     ` Sam Ravnborg
     [not found]                     ` <20090501174457.GA26559-QabhHTsIXMSnlFQ6Q1D1Y0B+6BGkLq7r@public.gmane.org>
2009-05-01 17:47                       ` H. Peter Anvin
2009-05-01 17:47                         ` H. Peter Anvin
2009-05-01 17:47                         ` H. Peter Anvin
2009-05-01 17:47                         ` H. Peter Anvin
2009-05-01 23:02                         ` Andreas Schwab [this message]
2009-05-01 23:02                           ` Andreas Schwab
2009-05-01 23:02                           ` Andreas Schwab
2009-05-01  9:04 ` [PATCH v2 0/6] macros for section name cleanup Sam Ravnborg
2009-05-01  9:04   ` Sam Ravnborg
2009-05-01  9:04   ` Sam Ravnborg
2009-05-01  9:04   ` Sam Ravnborg
2009-05-01  9:04   ` Sam Ravnborg
2009-05-01 14:21 ` Sam Ravnborg
2009-05-01 14:21   ` Sam Ravnborg
2009-05-01 14:21   ` Sam Ravnborg
2009-05-01 14:21   ` Sam Ravnborg
2009-05-01 14:21   ` Sam Ravnborg
2009-05-01 21:31 ` Sam Ravnborg
2009-05-02  0:48   ` Tim Abbott
2009-05-02 22:01     ` Sam Ravnborg
2009-05-04 14:27       ` Sam Ravnborg
2009-05-04 14:30         ` [PATCH/RFC] Sample conversion of powerpc Sam Ravnborg
2009-05-04 16:32         ` [PATCH v2 0/6] macros for section name cleanup Tim Abbott
2009-05-04 17:42           ` Mike Frysinger
2009-05-04 17:42             ` Mike Frysinger
2009-05-04 17:54             ` Sam Ravnborg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m2tz44o2a3.fsf@igel.home \
    --to=schwab@linux-m68k.org \
    --cc=deller@gmx.de \
    --cc=dev-etrax@axis.com \
    --cc=geert@linux-m68k.org \
    --cc=gerg@uclinux.org \
    --cc=heiko.carstens@de.ibm.com \
    --cc=hpa@zytor.com \
    --cc=jbarnold@MIT.EDU \
    --cc=jdike@addtoit.com \
    --cc=jesper.nilsson@axis.com \
    --cc=linux-ia64@vger.kernel.org \
    --cc=linux-m68k@vger.kernel.org \
    --cc=linux-mips@linux-mips.org \
    --cc=linux-s390@vger.kernel.org \
    --cc=linux-sh@vger.kernel.org \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=microblaze-uclinux@itee.uq.edu.au \
    --cc=mingo@redhat.com \
    --cc=paulus@samba.org \
    --cc=rmk+kernel@arm.linux.org.uk \
    --cc=sam@ravnborg.org \
    --cc=sparclinux@vger.kernel.org \
    --cc=starvik@axis.com \
    --cc=tabbott@MIT.EDU \
    --cc=tglx@linutronix.de \
    --cc=user-mode-linux-devel@lists.sourceforge.net \
    --cc=vda.linux@googlemail.com \
    --cc=ysato@users.sourceforge.jp \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.