All of lore.kernel.org
 help / color / mirror / Atom feed
From: khilman@baylibre.com (Kevin Hilman)
To: linus-amlogic@lists.infradead.org
Subject: [PATCH 2/2] ARM64: dts: meson-gxm-rbox-pro: Enable Bluetooth
Date: Wed, 18 Jan 2017 14:29:58 -0800	[thread overview]
Message-ID: <m2y3y8xaqh.fsf@baylibre.com> (raw)
In-Reply-To: <20170117030611.23827-3-afaerber@suse.de> ("Andreas Färber"'s message of "Tue, 17 Jan 2017 04:06:11 +0100")

Andreas F?rber <afaerber@suse.de> writes:

> Add an SDIO reset GPIO and enable the serial used by the AP6255
> Bluetooth module. Based on work by Martin Blumenstingl.
>
> Signed-off-by: Andreas F?rber <afaerber@suse.de>
> ---
>  arch/arm64/boot/dts/amlogic/meson-gxm-rbox-pro.dts | 11 ++++++++++-
>  1 file changed, 10 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/amlogic/meson-gxm-rbox-pro.dts b/arch/arm64/boot/dts/amlogic/meson-gxm-rbox-pro.dts
> index 9f04fa4e5aec..6ea225f584bd 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-gxm-rbox-pro.dts
> +++ b/arch/arm64/boot/dts/amlogic/meson-gxm-rbox-pro.dts
> @@ -58,6 +58,7 @@
>  
>  	aliases {
>  		serial0 = &uart_AO;
> +		serial1 = &uart_A;
>  	};
>  
>  	chosen {
> @@ -122,7 +123,8 @@
>  
>  	sdio_pwrseq: sdio-pwrseq {
>  		compatible = "mmc-pwrseq-simple";
> -		reset-gpios = <&gpio GPIOX_6 GPIO_ACTIVE_LOW>;
> +		reset-gpios = <&gpio GPIOX_6 GPIO_ACTIVE_LOW>,
> +				<&gpio GPIOX_17 GPIO_ACTIVE_LOW>;
>  		clocks = <&wifi32k>;
>  		clock-names = "ext_clock";

c.f. thread on Martin's series.   I don't like this (ab)use of
reset-gpios for sdio-pwrseq, and there's some work coming that will make
this much cleaner.

So, I'll hold off on this until the other solution is ready.

Kevin 

WARNING: multiple messages have this Message-ID (diff)
From: khilman@baylibre.com (Kevin Hilman)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] ARM64: dts: meson-gxm-rbox-pro: Enable Bluetooth
Date: Wed, 18 Jan 2017 14:29:58 -0800	[thread overview]
Message-ID: <m2y3y8xaqh.fsf@baylibre.com> (raw)
In-Reply-To: <20170117030611.23827-3-afaerber@suse.de> ("Andreas Färber"'s message of "Tue, 17 Jan 2017 04:06:11 +0100")

Andreas F?rber <afaerber@suse.de> writes:

> Add an SDIO reset GPIO and enable the serial used by the AP6255
> Bluetooth module. Based on work by Martin Blumenstingl.
>
> Signed-off-by: Andreas F?rber <afaerber@suse.de>
> ---
>  arch/arm64/boot/dts/amlogic/meson-gxm-rbox-pro.dts | 11 ++++++++++-
>  1 file changed, 10 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/amlogic/meson-gxm-rbox-pro.dts b/arch/arm64/boot/dts/amlogic/meson-gxm-rbox-pro.dts
> index 9f04fa4e5aec..6ea225f584bd 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-gxm-rbox-pro.dts
> +++ b/arch/arm64/boot/dts/amlogic/meson-gxm-rbox-pro.dts
> @@ -58,6 +58,7 @@
>  
>  	aliases {
>  		serial0 = &uart_AO;
> +		serial1 = &uart_A;
>  	};
>  
>  	chosen {
> @@ -122,7 +123,8 @@
>  
>  	sdio_pwrseq: sdio-pwrseq {
>  		compatible = "mmc-pwrseq-simple";
> -		reset-gpios = <&gpio GPIOX_6 GPIO_ACTIVE_LOW>;
> +		reset-gpios = <&gpio GPIOX_6 GPIO_ACTIVE_LOW>,
> +				<&gpio GPIOX_17 GPIO_ACTIVE_LOW>;
>  		clocks = <&wifi32k>;
>  		clock-names = "ext_clock";

c.f. thread on Martin's series.   I don't like this (ab)use of
reset-gpios for sdio-pwrseq, and there's some work coming that will make
this much cleaner.

So, I'll hold off on this until the other solution is ready.

Kevin 

WARNING: multiple messages have this Message-ID (diff)
From: Kevin Hilman <khilman@baylibre.com>
To: "Andreas Färber" <afaerber@suse.de>
Cc: Mark Rutland <mark.rutland@arm.com>,
	devicetree@vger.kernel.org,
	Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will.deacon@arm.com>,
	linux-kernel@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
	Carlo Caione <carlo@caione.org>,
	linux-amlogic@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/2] ARM64: dts: meson-gxm-rbox-pro: Enable Bluetooth
Date: Wed, 18 Jan 2017 14:29:58 -0800	[thread overview]
Message-ID: <m2y3y8xaqh.fsf@baylibre.com> (raw)
In-Reply-To: <20170117030611.23827-3-afaerber@suse.de> ("Andreas Färber"'s message of "Tue, 17 Jan 2017 04:06:11 +0100")

Andreas Färber <afaerber@suse.de> writes:

> Add an SDIO reset GPIO and enable the serial used by the AP6255
> Bluetooth module. Based on work by Martin Blumenstingl.
>
> Signed-off-by: Andreas Färber <afaerber@suse.de>
> ---
>  arch/arm64/boot/dts/amlogic/meson-gxm-rbox-pro.dts | 11 ++++++++++-
>  1 file changed, 10 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/amlogic/meson-gxm-rbox-pro.dts b/arch/arm64/boot/dts/amlogic/meson-gxm-rbox-pro.dts
> index 9f04fa4e5aec..6ea225f584bd 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-gxm-rbox-pro.dts
> +++ b/arch/arm64/boot/dts/amlogic/meson-gxm-rbox-pro.dts
> @@ -58,6 +58,7 @@
>  
>  	aliases {
>  		serial0 = &uart_AO;
> +		serial1 = &uart_A;
>  	};
>  
>  	chosen {
> @@ -122,7 +123,8 @@
>  
>  	sdio_pwrseq: sdio-pwrseq {
>  		compatible = "mmc-pwrseq-simple";
> -		reset-gpios = <&gpio GPIOX_6 GPIO_ACTIVE_LOW>;
> +		reset-gpios = <&gpio GPIOX_6 GPIO_ACTIVE_LOW>,
> +				<&gpio GPIOX_17 GPIO_ACTIVE_LOW>;
>  		clocks = <&wifi32k>;
>  		clock-names = "ext_clock";

c.f. thread on Martin's series.   I don't like this (ab)use of
reset-gpios for sdio-pwrseq, and there's some work coming that will make
this much cleaner.

So, I'll hold off on this until the other solution is ready.

Kevin 

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Kevin Hilman <khilman@baylibre.com>
To: "Andreas Färber" <afaerber@suse.de>
Cc: linux-amlogic@lists.infradead.org,
	Carlo Caione <carlo@caione.org>,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will.deacon@arm.com>,
	devicetree@vger.kernel.org
Subject: Re: [PATCH 2/2] ARM64: dts: meson-gxm-rbox-pro: Enable Bluetooth
Date: Wed, 18 Jan 2017 14:29:58 -0800	[thread overview]
Message-ID: <m2y3y8xaqh.fsf@baylibre.com> (raw)
In-Reply-To: <20170117030611.23827-3-afaerber@suse.de> ("Andreas Färber"'s message of "Tue, 17 Jan 2017 04:06:11 +0100")

Andreas Färber <afaerber@suse.de> writes:

> Add an SDIO reset GPIO and enable the serial used by the AP6255
> Bluetooth module. Based on work by Martin Blumenstingl.
>
> Signed-off-by: Andreas Färber <afaerber@suse.de>
> ---
>  arch/arm64/boot/dts/amlogic/meson-gxm-rbox-pro.dts | 11 ++++++++++-
>  1 file changed, 10 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/amlogic/meson-gxm-rbox-pro.dts b/arch/arm64/boot/dts/amlogic/meson-gxm-rbox-pro.dts
> index 9f04fa4e5aec..6ea225f584bd 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-gxm-rbox-pro.dts
> +++ b/arch/arm64/boot/dts/amlogic/meson-gxm-rbox-pro.dts
> @@ -58,6 +58,7 @@
>  
>  	aliases {
>  		serial0 = &uart_AO;
> +		serial1 = &uart_A;
>  	};
>  
>  	chosen {
> @@ -122,7 +123,8 @@
>  
>  	sdio_pwrseq: sdio-pwrseq {
>  		compatible = "mmc-pwrseq-simple";
> -		reset-gpios = <&gpio GPIOX_6 GPIO_ACTIVE_LOW>;
> +		reset-gpios = <&gpio GPIOX_6 GPIO_ACTIVE_LOW>,
> +				<&gpio GPIOX_17 GPIO_ACTIVE_LOW>;
>  		clocks = <&wifi32k>;
>  		clock-names = "ext_clock";

c.f. thread on Martin's series.   I don't like this (ab)use of
reset-gpios for sdio-pwrseq, and there's some work coming that will make
this much cleaner.

So, I'll hold off on this until the other solution is ready.

Kevin 

  reply	other threads:[~2017-01-18 22:29 UTC|newest]

Thread overview: 72+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-17  3:06 [PATCH 0/2] ARM64: meson-gxm: R-Box Pro enablement Andreas Färber
2017-01-17  3:06 ` Andreas Färber
2017-01-17  3:06 ` Andreas Färber
2017-01-17  3:06 ` Andreas Färber
2017-01-17  3:06 ` [PATCH 1/2] ARM64: dts: meson-gxm: Add R-Box Pro Andreas Färber
2017-01-17  3:06   ` Andreas Färber
2017-01-17  3:06   ` Andreas Färber
2017-01-17  3:35   ` Andreas Färber
2017-01-17  3:35     ` Andreas Färber
2017-01-17  3:35     ` Andreas Färber
2017-01-17  3:35     ` Andreas Färber
2017-01-18 22:18     ` Kevin Hilman
2017-01-18 22:18       ` Kevin Hilman
2017-01-18 22:18       ` Kevin Hilman
2017-01-18 22:18       ` Kevin Hilman
2017-01-17 22:54   ` [PATCH 1/3] Documentation: devicetree: Add Kingnovel vendor prefix Andreas Färber
2017-01-17 22:54     ` Andreas Färber
2017-01-17 22:54     ` Andreas Färber
2017-01-17 22:54     ` Andreas Färber
2017-01-17 22:54     ` [PATCH 2/3] Documentation: devicetree: amlogic: Add R-Box Pro Andreas Färber
2017-01-17 22:54       ` Andreas Färber
2017-01-17 22:54       ` Andreas Färber
2017-01-18  9:35       ` Neil Armstrong
2017-01-18  9:35         ` Neil Armstrong
2017-01-18  9:35         ` Neil Armstrong
2017-01-18  9:35         ` Neil Armstrong
2017-01-18 22:38         ` Andreas Färber
2017-01-18 22:38           ` Andreas Färber
2017-01-18 22:38           ` Andreas Färber
2017-01-18 22:38           ` Andreas Färber
2017-01-18 23:38           ` Kevin Hilman
2017-01-18 23:38             ` Kevin Hilman
2017-01-18 23:38             ` Kevin Hilman
2017-01-18 23:38             ` Kevin Hilman
2017-01-21 20:02       ` Rob Herring
2017-01-21 20:02         ` Rob Herring
2017-01-21 20:02         ` Rob Herring
2017-01-21 20:02         ` Rob Herring
2017-01-17 22:54     ` [PATCH 3/3] ARM64: dts: meson-gxm-rbox-pro: Add board compatible string Andreas Färber
2017-01-17 22:54       ` Andreas Färber
2017-01-17 22:54       ` Andreas Färber
2017-01-17 22:54       ` Andreas Färber
2017-01-23 18:21       ` Kevin Hilman
2017-01-23 18:21         ` Kevin Hilman
2017-01-23 18:21         ` Kevin Hilman
2017-01-23 18:21         ` Kevin Hilman
2017-01-23 18:32         ` Andreas Färber
2017-01-23 18:32           ` Andreas Färber
2017-01-23 18:32           ` Andreas Färber
2017-01-23 18:32           ` Andreas Färber
2017-01-21 20:01     ` [PATCH 1/3] Documentation: devicetree: Add Kingnovel vendor prefix Rob Herring
2017-01-21 20:01       ` Rob Herring
2017-01-21 20:01       ` Rob Herring
2017-01-21 20:01       ` Rob Herring
2017-01-17 23:06   ` [PATCH 1/2] ARM64: dts: meson-gxm: Add R-Box Pro Andreas Färber
2017-01-17 23:06     ` Andreas Färber
2017-01-17 23:06     ` Andreas Färber
2017-01-17 23:06     ` Andreas Färber
2017-01-18 22:27     ` Kevin Hilman
2017-01-18 22:27       ` Kevin Hilman
2017-01-18 22:27       ` Kevin Hilman
2017-01-19  8:10       ` Neil Armstrong
2017-01-19  8:10         ` Neil Armstrong
2017-01-19  8:10         ` Neil Armstrong
2017-01-17  3:06 ` [PATCH 2/2] ARM64: dts: meson-gxm-rbox-pro: Enable Bluetooth Andreas Färber
2017-01-17  3:06   ` Andreas Färber
2017-01-17  3:06   ` Andreas Färber
2017-01-17  3:06   ` Andreas Färber
2017-01-18 22:29   ` Kevin Hilman [this message]
2017-01-18 22:29     ` Kevin Hilman
2017-01-18 22:29     ` Kevin Hilman
2017-01-18 22:29     ` Kevin Hilman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m2y3y8xaqh.fsf@baylibre.com \
    --to=khilman@baylibre.com \
    --cc=linus-amlogic@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.