All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nathan Lynch <ntl-e+AXbWqSrlAAvxtiuMwx3w@public.gmane.org>
To: "Serge E. Hallyn" <serue-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
Cc: Linux Containers <containers-qjLDD68F18O7TbgM5vRIOg@public.gmane.org>
Subject: Re: [PATCH 1/1] s390: cr: fix unterminated #ifndef
Date: Thu, 07 May 2009 16:17:27 -0500	[thread overview]
Message-ID: <m31vr0395k.fsf@pobox.com> (raw)
In-Reply-To: <20090507203033.GA22542-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org> (Serge E. Hallyn's message of "Thu\, 7 May 2009 15\:30\:33 -0500")

"Serge E. Hallyn" <serue-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org> writes:
> With this, v15 compiles and does checkpoint/restart just fine
> on s390.
>
> Signed-off-by: Serge E. Hallyn <serue-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
> ---
>  arch/s390/include/asm/checkpoint_hdr.h |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/arch/s390/include/asm/checkpoint_hdr.h b/arch/s390/include/asm/checkpoint_hdr.h
> index 292dc33..48ee296 100644
> --- a/arch/s390/include/asm/checkpoint_hdr.h
> +++ b/arch/s390/include/asm/checkpoint_hdr.h
> @@ -80,4 +80,5 @@ struct ckpt_hdr_header_arch {
>  	struct ckpt_hdr h;
>  };
>  
> +#endif /* __s390x__ */

I suggest just removing the #ifdef __s390x__.  32-bit builds may not be
supported or tested yet, but just having the declarations isn't going to
break things.  And it's one less thing to stumble over if someone does
implement 32-bit support.

  parent reply	other threads:[~2009-05-07 21:17 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-07 20:30 [PATCH 1/1] s390: cr: fix unterminated #ifndef Serge E. Hallyn
     [not found] ` <20090507203033.GA22542-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2009-05-07 21:17   ` Nathan Lynch [this message]
     [not found]     ` <m31vr0395k.fsf-e+AXbWqSrlAAvxtiuMwx3w@public.gmane.org>
2009-05-07 21:30       ` Serge E. Hallyn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m31vr0395k.fsf@pobox.com \
    --to=ntl-e+axbwqsrlaavxtiumwx3w@public.gmane.org \
    --cc=containers-qjLDD68F18O7TbgM5vRIOg@public.gmane.org \
    --cc=serue-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.