* [PATCH 1/1] s390: cr: fix unterminated #ifndef
@ 2009-05-07 20:30 Serge E. Hallyn
[not found] ` <20090507203033.GA22542-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
0 siblings, 1 reply; 3+ messages in thread
From: Serge E. Hallyn @ 2009-05-07 20:30 UTC (permalink / raw)
To: Oren Laadan; +Cc: Linux Containers
With this, v15 compiles and does checkpoint/restart just fine
on s390.
Signed-off-by: Serge E. Hallyn <serue-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
---
arch/s390/include/asm/checkpoint_hdr.h | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/arch/s390/include/asm/checkpoint_hdr.h b/arch/s390/include/asm/checkpoint_hdr.h
index 292dc33..48ee296 100644
--- a/arch/s390/include/asm/checkpoint_hdr.h
+++ b/arch/s390/include/asm/checkpoint_hdr.h
@@ -80,4 +80,5 @@ struct ckpt_hdr_header_arch {
struct ckpt_hdr h;
};
+#endif /* __s390x__ */
#endif /* __ASM_S390_CKPT_HDR__H */
--
1.6.1
^ permalink raw reply related [flat|nested] 3+ messages in thread[parent not found: <20090507203033.GA22542-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>]
* Re: [PATCH 1/1] s390: cr: fix unterminated #ifndef [not found] ` <20090507203033.GA22542-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org> @ 2009-05-07 21:17 ` Nathan Lynch [not found] ` <m31vr0395k.fsf-e+AXbWqSrlAAvxtiuMwx3w@public.gmane.org> 0 siblings, 1 reply; 3+ messages in thread From: Nathan Lynch @ 2009-05-07 21:17 UTC (permalink / raw) To: Serge E. Hallyn; +Cc: Linux Containers "Serge E. Hallyn" <serue-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org> writes: > With this, v15 compiles and does checkpoint/restart just fine > on s390. > > Signed-off-by: Serge E. Hallyn <serue-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org> > --- > arch/s390/include/asm/checkpoint_hdr.h | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/arch/s390/include/asm/checkpoint_hdr.h b/arch/s390/include/asm/checkpoint_hdr.h > index 292dc33..48ee296 100644 > --- a/arch/s390/include/asm/checkpoint_hdr.h > +++ b/arch/s390/include/asm/checkpoint_hdr.h > @@ -80,4 +80,5 @@ struct ckpt_hdr_header_arch { > struct ckpt_hdr h; > }; > > +#endif /* __s390x__ */ I suggest just removing the #ifdef __s390x__. 32-bit builds may not be supported or tested yet, but just having the declarations isn't going to break things. And it's one less thing to stumble over if someone does implement 32-bit support. ^ permalink raw reply [flat|nested] 3+ messages in thread
[parent not found: <m31vr0395k.fsf-e+AXbWqSrlAAvxtiuMwx3w@public.gmane.org>]
* Re: [PATCH 1/1] s390: cr: fix unterminated #ifndef [not found] ` <m31vr0395k.fsf-e+AXbWqSrlAAvxtiuMwx3w@public.gmane.org> @ 2009-05-07 21:30 ` Serge E. Hallyn 0 siblings, 0 replies; 3+ messages in thread From: Serge E. Hallyn @ 2009-05-07 21:30 UTC (permalink / raw) To: Nathan Lynch; +Cc: Linux Containers Quoting Nathan Lynch (ntl-e+AXbWqSrlAAvxtiuMwx3w@public.gmane.org): > "Serge E. Hallyn" <serue-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org> writes: > > With this, v15 compiles and does checkpoint/restart just fine > > on s390. > > > > Signed-off-by: Serge E. Hallyn <serue-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org> > > --- > > arch/s390/include/asm/checkpoint_hdr.h | 1 + > > 1 files changed, 1 insertions(+), 0 deletions(-) > > > > diff --git a/arch/s390/include/asm/checkpoint_hdr.h b/arch/s390/include/asm/checkpoint_hdr.h > > index 292dc33..48ee296 100644 > > --- a/arch/s390/include/asm/checkpoint_hdr.h > > +++ b/arch/s390/include/asm/checkpoint_hdr.h > > @@ -80,4 +80,5 @@ struct ckpt_hdr_header_arch { > > struct ckpt_hdr h; > > }; > > > > +#endif /* __s390x__ */ > > I suggest just removing the #ifdef __s390x__. 32-bit builds may not be > supported or tested yet, but just having the declarations isn't going to > break things. And it's one less thing to stumble over if someone does > implement 32-bit support. Actually, you're more right than you know - CONFIG_CHECKPOINT already is off if not 64bit :) So yeah, the ifdef should just be removed. thanks, -serge ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2009-05-07 21:30 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-05-07 20:30 [PATCH 1/1] s390: cr: fix unterminated #ifndef Serge E. Hallyn
[not found] ` <20090507203033.GA22542-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2009-05-07 21:17 ` Nathan Lynch
[not found] ` <m31vr0395k.fsf-e+AXbWqSrlAAvxtiuMwx3w@public.gmane.org>
2009-05-07 21:30 ` Serge E. Hallyn
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.