HDMI Audio screwed up w/ recent kernels

HDMI Audio screwed up w/ recent kernels

[James Cloos]

I haven't paid as close attention to Xorg issues sine the stroke last
year, and I hadn't needed to reboot the box in the living room in
several months.

When I did need to, I found that hdmi audio was unlistenable.  It
sounded like it was mixed witht white noise.

If I boot vmlinuz-3.19.0 is works fine.  I had compiled 4.1.0 and 4.5.0,
as well as its current default kernel, 4.9.0 (all from Linus' git).  All
of those 4. kernels show the crappy audio.

In 4.9 I then tried switching to amdgpu.  That did not help.

The box has a Kaveri apu (ChipID 0x1313).

Firmware is from linux-firmware.git and is compiled into the kernel via
CONFIG_EXTRA_FIRMWARE.

With radeon the kernel command line has:  radeon.modeset=1 radeon.audio=1
With amdgpu I switched to:  amdgpu.audio=1 amdgpu.exp_hw_support=1

Any thoughs on where to look?

I find it hard to believe that a bug like this could persist for so
long.

-JimC
-- 
James Cloos <cloos@jhcloos.com>         OpenPGP: 0x997A9F17ED7DAEA6
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: HDMI Audio screwed up w/ recent kernels

[Daniel Vetter]

On Thu, Dec 22, 2016 at 07:49:57PM -0500, James Cloos wrote:
> I haven't paid as close attention to Xorg issues sine the stroke last
> year, and I hadn't needed to reboot the box in the living room in
> several months.
> 
> When I did need to, I found that hdmi audio was unlistenable.  It
> sounded like it was mixed witht white noise.
> 
> If I boot vmlinuz-3.19.0 is works fine.  I had compiled 4.1.0 and 4.5.0,
> as well as its current default kernel, 4.9.0 (all from Linus' git).  All
> of those 4. kernels show the crappy audio.
> 
> In 4.9 I then tried switching to amdgpu.  That did not help.
> 
> The box has a Kaveri apu (ChipID 0x1313).
> 
> Firmware is from linux-firmware.git and is compiled into the kernel via
> CONFIG_EXTRA_FIRMWARE.
> 
> With radeon the kernel command line has:  radeon.modeset=1 radeon.audio=1
> With amdgpu I switched to:  amdgpu.audio=1 amdgpu.exp_hw_support=1
> 
> Any thoughs on where to look?
> 
> I find it hard to believe that a bug like this could persist for so
> long.

amdgpu doesn't yet support hdmi audio. No idea about what broke for
radeon, bisecting is probably going to be the most effective way forward
(since 3.19->4.0 is so long ago no one will remember what happened back
then).
-Daniel

> 
> -JimC
> -- 
> James Cloos <cloos@jhcloos.com>         OpenPGP: 0x997A9F17ED7DAEA6
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: HDMI Audio screwed up w/ recent kernels

[James Cloos]

>>>>> "DV" == Daniel Vetter <daniel@ffwll.ch> writes:

DV> amdgpu doesn't yet support hdmi audio.

Then why does it support the amdgpu.audio command line option, and why
does booting an amdgpu kernel with amdgpu.audio=1 sound the same as
booting a radeon kernel w/ radeon.audio=1?

In linux/drivers/gpu/drm/amd/amdgpu:

  :; grep -l audio_enable *.c|xargs
  dce_v10_0.c dce_v11_0.c dce_v6_0.c dce_v8_0.c

  :; grep -l amdgpu_audio *.c |xargs
  amdgpu_connectors.c amdgpu_display.c amdgpu_drv.c atombios_encoders.c
  dce_v10_0.c dce_v11_0.c dce_v6_0.c dce_v8_0.c

-JimC
-- 
James Cloos <cloos@jhcloos.com>         OpenPGP: 0x997A9F17ED7DAEA6
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: HDMI Audio screwed up w/ recent kernels

[Daniel Vetter]

On Tue, Dec 27, 2016 at 12:17:43PM -0500, James Cloos wrote:
> >>>>> "DV" == Daniel Vetter <daniel@ffwll.ch> writes:
> 
> DV> amdgpu doesn't yet support hdmi audio.
> 
> Then why does it support the amdgpu.audio command line option, and why
> does booting an amdgpu kernel with amdgpu.audio=1 sound the same as
> booting a radeon kernel w/ radeon.audio=1?

Hm, I thought there was in issue there still. Anyway, was just a drive-by
comment, please ignore me ;-)
-Daniel

> 
> In linux/drivers/gpu/drm/amd/amdgpu:
> 
>   :; grep -l audio_enable *.c|xargs
>   dce_v10_0.c dce_v11_0.c dce_v6_0.c dce_v8_0.c
> 
>   :; grep -l amdgpu_audio *.c |xargs
>   amdgpu_connectors.c amdgpu_display.c amdgpu_drv.c atombios_encoders.c
>   dce_v10_0.c dce_v11_0.c dce_v6_0.c dce_v8_0.c
> 
> -JimC
> -- 
> James Cloos <cloos@jhcloos.com>         OpenPGP: 0x997A9F17ED7DAEA6

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: HDMI Audio screwed up w/ recent kernels

[Bridgman, John]

[-- Attachment #1.1: Type: text/plain, Size: 1517 bytes --]

IIRC it depends on the chip generation - for example amdgpu does not yet include HDMI audio support on SI parts.

________________________________
From: dri-devel <dri-devel-bounces@lists.freedesktop.org> on behalf of Daniel Vetter <daniel@ffwll.ch>
Sent: December 27, 2016 1:20 PM
To: James Cloos
Cc: dri-devel@lists.freedesktop.org
Subject: Re: HDMI Audio screwed up w/ recent kernels

On Tue, Dec 27, 2016 at 12:17:43PM -0500, James Cloos wrote:
> >>>>> "DV" == Daniel Vetter <daniel@ffwll.ch> writes:
>
> DV> amdgpu doesn't yet support hdmi audio.
>
> Then why does it support the amdgpu.audio command line option, and why
> does booting an amdgpu kernel with amdgpu.audio=1 sound the same as
> booting a radeon kernel w/ radeon.audio=1?

Hm, I thought there was in issue there still. Anyway, was just a drive-by
comment, please ignore me ;-)
-Daniel

>
> In linux/drivers/gpu/drm/amd/amdgpu:
>
>   :; grep -l audio_enable *.c|xargs
>   dce_v10_0.c dce_v11_0.c dce_v6_0.c dce_v8_0.c
>
>   :; grep -l amdgpu_audio *.c |xargs
>   amdgpu_connectors.c amdgpu_display.c amdgpu_drv.c atombios_encoders.c
>   dce_v10_0.c dce_v11_0.c dce_v6_0.c dce_v8_0.c
>
> -JimC
> --
> James Cloos <cloos@jhcloos.com>         OpenPGP: 0x997A9F17ED7DAEA6

--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[-- Attachment #1.2: Type: text/html, Size: 2726 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: HDMI Audio screwed up w/ recent kernels

[James Cloos]

>>>>> "DV" == Daniel Vetter <daniel@ffwll.ch> writes:

DV> Hm, I thought there was in issue there still. Anyway, was just a drive-by
DV> comment, please ignore me ;-)

Any and all help is always appreciated.

-JimC
-- 
James Cloos <cloos@jhcloos.com>         OpenPGP: 0x997A9F17ED7DAEA6
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: HDMI Audio screwed up w/ recent kernels

[Alex Deucher]

On Tue, Dec 27, 2016 at 12:17 PM, James Cloos <cloos@jhcloos.com> wrote:
>>>>>> "DV" == Daniel Vetter <daniel@ffwll.ch> writes:
>
> DV> amdgpu doesn't yet support hdmi audio.
>
> Then why does it support the amdgpu.audio command line option, and why
> does booting an amdgpu kernel with amdgpu.audio=1 sound the same as
> booting a radeon kernel w/ radeon.audio=1?

That option is just a carry over from when the amdgpu was copied from
radeon.  There is some code for older asics left over from when the
code was originally ported from radeon.  If you want hdmi audio
support you need to use the new dc modesetting code we are working on:
https://cgit.freedesktop.org/~agd5f/linux/log/?h=amd-staging-4.7

As for radeon, a bisection would help.  If both drivers worked before
and now both have issues, I'd suggest looking at the hda audio driver.

Alex
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: HDMI Audio screwed up w/ recent kernels

[James Cloos]

>>>>> "AD" == Alex Deucher <alexdeucher@gmail.com> writes:

AD> That option is just a carry over from when the amdgpu was copied from
AD> radeon.  There is some code for older asics left over from when the
AD> code was originally ported from radeon.  If you want hdmi audio
AD> support you need to use the new dc modesetting code we are working on:
AD> https://cgit.freedesktop.org/~agd5f/linux/log/?h=amd-staging-4.7

AD> As for radeon, a bisection would help.  If both drivers worked before
AD> and now both have issues, I'd suggest looking at the hda audio driver.

All I know is that radeon audio worked fine in 3.x and stopped working
in 4.x  Where stopped working means fairly recognizable audio which
sounds mixed with white noise.

I doubt I can bisect.  The screen it uses is in almost constant use....

In order for the fb to be there from boot, the firmware is all compiled
into the kernels via CONFIG_EXTRA_FIRMWARE.

Given that, with 4.9, the audio has exactly the same problem with amdgpu
as with radeon, I suspect the actual problem is in the firmware.  If so,
and since I do not have whatever firmware files were installed back when
I compiled the 3. kernels, I doubt bisecting the kernel would help.

-JimC
-- 
James Cloos <cloos@jhcloos.com>         OpenPGP: 0x997A9F17ED7DAEA6
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: HDMI Audio screwed up w/ recent kernels

[Alex Deucher]

On Sat, Dec 31, 2016 at 2:55 AM, James Cloos <cloos@jhcloos.com> wrote:
>>>>>> "AD" == Alex Deucher <alexdeucher@gmail.com> writes:
>
> AD> That option is just a carry over from when the amdgpu was copied from
> AD> radeon.  There is some code for older asics left over from when the
> AD> code was originally ported from radeon.  If you want hdmi audio
> AD> support you need to use the new dc modesetting code we are working on:
> AD> https://cgit.freedesktop.org/~agd5f/linux/log/?h=amd-staging-4.7
>
> AD> As for radeon, a bisection would help.  If both drivers worked before
> AD> and now both have issues, I'd suggest looking at the hda audio driver.
>
> All I know is that radeon audio worked fine in 3.x and stopped working
> in 4.x  Where stopped working means fairly recognizable audio which
> sounds mixed with white noise.
>
> I doubt I can bisect.  The screen it uses is in almost constant use....
>
> In order for the fb to be there from boot, the firmware is all compiled
> into the kernels via CONFIG_EXTRA_FIRMWARE.
>
> Given that, with 4.9, the audio has exactly the same problem with amdgpu
> as with radeon, I suspect the actual problem is in the firmware.  If so,
> and since I do not have whatever firmware files were installed back when
> I compiled the 3. kernels, I doubt bisecting the kernel would help.

The GPU firmware is not involved in display or audio at all.

Alex
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: HDMI Audio screwed up w/ recent kernels

[James Cloos]

>>>>> "AD" == Alex Deucher <alexdeucher@gmail.com> writes:

AD> The GPU firmware is not involved in display or audio at all.

Oh.  Thanks for that!

In that case the bug showed up some time between 3.19.0 and 4.1.0.

git tag tells me 3.19 was the last 3.

Only 14.56+ bits worth of commits between those two tags. ;)

-JimC
-- 
James Cloos <cloos@jhcloos.com>         OpenPGP: 0x997A9F17ED7DAEA6

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel