All of lore.kernel.org
 help / color / mirror / Atom feed
From: Markus Armbruster <armbru@redhat.com>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: Peter Maydell <peter.maydell@linaro.org>,
	Lai Jiangshan <eag0628@gmail.com>,
	Jiangshan <laijs@cn.fujitsu.com>, Gleb Natapov <gleb@redhat.com>,
	Jan Kiszka <jan.kiszka@siemens.com>,
	qemu-devel@nongnu.org, Luiz Capitulino <lcapitulino@redhat.com>,
	Avi Kivity <avi@redhat.com>,
	kvm@vger.kernel.org
Subject: Re: [PATCH 2/2 V7] qemu, qmp: add inject-nmi qmp command
Date: Thu, 14 Apr 2011 08:41:44 +0200	[thread overview]
Message-ID: <m38vvduyfr.fsf@blackfin.pond.sub.org> (raw)
In-Reply-To: <BANLkTi=c7P=OzNKB1+36T4da04nZgZAZ5A@mail.gmail.com> (Blue Swirl's message of "Wed, 13 Apr 2011 22:56:21 +0300")

Blue Swirl <blauwirbel@gmail.com> writes:

> On Wed, Apr 13, 2011 at 4:08 PM, Luiz Capitulino <lcapitulino@redhat.com> wrote:
>> On Tue, 12 Apr 2011 21:31:18 +0300
>> Blue Swirl <blauwirbel@gmail.com> wrote:
>>
>>> On Tue, Apr 12, 2011 at 10:52 AM, Avi Kivity <avi@redhat.com> wrote:
>>> > On 04/11/2011 08:15 PM, Blue Swirl wrote:
>>> >>
>>> >> On Mon, Apr 11, 2011 at 10:01 AM, Markus Armbruster<armbru@redhat.com>
>>> >>  wrote:
>>> >> >  Avi Kivity<avi@redhat.com>  writes:
>>> >> >
>>> >> >>  On 04/08/2011 12:41 AM, Anthony Liguori wrote:
>>> >> >>>
>>> >> >>>  And it's a good thing to have, but exposing this as the only API to
>>> >> >>>  do something as simple as generating a guest crash dump is not the
>>> >> >>>  friendliest thing in the world to do to users.
>>> >> >>
>>> >> >>  nmi is a fine name for something that corresponds to a real-life nmi
>>> >> >>  button (often labeled "NMI").
>>> >> >
>>> >> >  Agree.
>>> >>
>>> >> We could also introduce an alias mechanism for user friendly names, so
>>> >> nmi could be used in addition of full path. Aliases could be useful
>>> >> for device paths as well.
>>> >
>>> > Yes.  Perhaps limited to the human monitor.
>>>
>>> I'd limit all debugging commands (including NMI) to the human monitor.
>>
>> Why?
>
> Do they have any real use in production environment? Also, we should
> have the freedom to change the debugging facilities (for example, to
> improve some internal implementation) as we want without regard to
> compatibility to previous versions.

For what it's worth, Lai (original poster) has been trying for many
months to get inject-nmi into QMP, and I suspect he has a really good
reason for his super-human persistence.

  reply	other threads:[~2011-04-14  6:41 UTC|newest]

Thread overview: 60+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-07  9:43 [PATCH 0/2 V7] add inject-nmi qmp command Lai Jiangshan
2011-03-07  9:45 ` [PATCH 1/2] qemu,qmp: QError: New QERR_UNSUPPORTED Lai Jiangshan
2011-03-07  9:46 ` [PATCH 2/2 V7] qemu,qmp: add inject-nmi qmp command Lai Jiangshan
2011-04-04 10:59   ` [Qemu-devel] " Daniel P. Berrange
2011-04-04 12:19     ` Markus Armbruster
2011-04-04 13:04       ` Luiz Capitulino
2011-04-04 13:09       ` Anthony Liguori
2011-04-04 13:34         ` Luiz Capitulino
2011-04-20  1:53         ` Lai Jiangshan
2011-04-20  3:02           ` Lai Jiangshan
2011-04-25 15:00           ` [PATCH 2/2 V7] qemu, qmp: " Luiz Capitulino
2011-04-04 12:54     ` [Qemu-devel] [PATCH 2/2 V7] qemu,qmp: " Avi Kivity
2011-04-04 13:05       ` Anthony Liguori
2011-04-06 17:47         ` Luiz Capitulino
2011-04-06 18:03           ` Anthony Liguori
2011-04-06 18:08             ` Luiz Capitulino
2011-04-06 18:17               ` Jan Kiszka
2011-04-06 19:00                 ` Luiz Capitulino
2011-04-06 19:27                   ` Peter Maydell
2011-04-06 19:34                     ` Anthony Liguori
2011-04-07  7:29                       ` Jan Kiszka
2011-04-07 18:10                       ` Peter Maydell
2011-04-07 18:32                         ` Anthony Liguori
2011-04-07 18:51                           ` Gleb Natapov
2011-04-07 19:04                             ` Blue Swirl
2011-04-07 19:17                               ` Gleb Natapov
2011-04-07 21:41                                 ` Anthony Liguori
2011-04-08  6:04                                   ` Gleb Natapov
2011-04-08 19:17                                     ` Blue Swirl
2011-04-08 19:32                                       ` Anthony Liguori
2011-04-08 20:07                                         ` Blue Swirl
2011-05-03 10:01                                       ` Jamie Lokier
2011-04-10  8:52                                   ` Avi Kivity
2011-04-11  7:01                                     ` Markus Armbruster
2011-04-11 17:15                                       ` Blue Swirl
2011-04-12  7:52                                         ` Avi Kivity
2011-04-12 18:31                                           ` Blue Swirl
2011-04-13 13:08                                             ` Luiz Capitulino
2011-04-13 19:56                                               ` [PATCH 2/2 V7] qemu, qmp: " Blue Swirl
2011-04-14  6:41                                                 ` Markus Armbruster [this message]
2011-04-14  9:55                                                 ` [Qemu-devel] [PATCH 2/2 V7] qemu,qmp: " Daniel P. Berrange
2011-04-15 16:37                                                   ` [PATCH 2/2 V7] qemu, qmp: " Blue Swirl
2011-04-07 21:39                             ` [Qemu-devel] [PATCH 2/2 V7] qemu,qmp: " Anthony Liguori
2011-04-08  5:54                               ` Gleb Natapov
2011-05-03  9:54                                 ` [PATCH 2/2 V7] qemu, qmp: " Jamie Lokier
2011-04-10  8:57                               ` [Qemu-devel] [PATCH 2/2 V7] qemu,qmp: " Avi Kivity
2011-04-20  6:19               ` [RFC PATCH 0/3 V8] QAPI: " Lai Jiangshan
2011-04-21  3:23                 ` Lai Jiangshan
2011-04-26 13:26                   ` Luiz Capitulino
2011-04-26 13:29                     ` [Qemu-devel] " Anthony Liguori
2011-04-27  1:54                       ` Lai Jiangshan
2011-04-27 14:33                         ` Luiz Capitulino
2011-04-28  3:35                           ` [PATCH 0/2 V9] hmp,qmp: add inject-nmi Lai Jiangshan
2011-04-29 22:24                             ` Luiz Capitulino
2011-04-28  3:35                           ` [PATCH 1/2 V9] qemu,qmp: QError: New QERR_UNSUPPORTED Lai Jiangshan
2011-04-28  3:35                           ` [PATCH 2/2 V9] qmp,inject-nmi: convert do_inject_nmi() to QObject Lai Jiangshan
2011-04-25 17:07                 ` [Qemu-devel] [RFC PATCH 0/3 V8] QAPI: add inject-nmi qmp command Michael Roth
2011-04-20  6:19               ` [RFC PATCH 1/3 V8] QError: Introduce QERR_UNSUPPORTED Lai Jiangshan
2011-04-20  6:19               ` [RFC PATCH 2/3 V8] qapi,nmi: add inject-nmi qmp command Lai Jiangshan
2011-04-20  6:19               ` [RFC PATCH 3/3 V8] qapi-hmp: Convert HMP nmi to use QMP Lai Jiangshan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m38vvduyfr.fsf@blackfin.pond.sub.org \
    --to=armbru@redhat.com \
    --cc=avi@redhat.com \
    --cc=blauwirbel@gmail.com \
    --cc=eag0628@gmail.com \
    --cc=gleb@redhat.com \
    --cc=jan.kiszka@siemens.com \
    --cc=kvm@vger.kernel.org \
    --cc=laijs@cn.fujitsu.com \
    --cc=lcapitulino@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.