Re: [Qemu-devel] [PATCH 2/2 V7] qemu,qmp: add inject-nmi qmp command

[Lai Jiangshan <laijs@cn.fujitsu.com>]

On 04/20/2011 09:53 AM, Lai Jiangshan wrote:
> On 04/04/2011 09:09 PM, Anthony Liguori wrote:
>> On 04/04/2011 07:19 AM, Markus Armbruster wrote:
>>> [Note cc: Anthony]
>>>
>>> "Daniel P. Berrange"<berrange@redhat.com>  writes:
>>>
>>>> On Mon, Mar 07, 2011 at 05:46:28PM +0800, Lai Jiangshan wrote:
>>>>> From: Lai Jiangshan<laijs@cn.fujitsu.com>
>>>>> Date: Mon, 7 Mar 2011 17:05:15 +0800
>>>>> Subject: [PATCH 2/2] qemu,qmp: add inject-nmi qmp command
>>>>>
>>>>> inject-nmi command injects an NMI on all CPUs of guest.
>>>>> It is only supported for x86 guest currently, it will
>>>>> returns "Unsupported" error for non-x86 guest.
>>>>>
>>>>> ---
>>>>>   hmp-commands.hx |    2 +-
>>>>>   monitor.c       |   18 +++++++++++++++++-
>>>>>   qmp-commands.hx |   29 +++++++++++++++++++++++++++++
>>>>>   3 files changed, 47 insertions(+), 2 deletions(-)
>>>> Does anyone have any feedback on this addition, or are all new
>>>> QMP patch proposals blocked pending Anthony's QAPI work ?
>>> That would be bad.  Anthony, what's holding this back?
>>
>> It doesn't pass checkpath.pl.
>>
>> But I'd also expect this to come through Luiz's QMP tree.
>>
>> Regards,
>>
>> Anthony Liguori
>>
> 
> Hi, Anthony,
> 
> I cannot find checkpath.pl in the source tree.

Sorry, I found it in the mainline tree.

> And how/where to write errors descriptions? Is the following description
> suitable?
> 
> ##
> # @inject-nmi:
> #
> # Inject an NMI on the guest.
> #
> # Returns: Nothing on success.
> #          If the guest(non-x86) does not support NMI injection, Unsupported
> #
> # Since: 0.15.0
> ##
> { 'command': 'inject-nmi' }
> 
> 
> Thanks,
> Lai
> --
> To unsubscribe from this list: send the line "unsubscribe kvm" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>