All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chris Ball <cjb@laptop.org>
To: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Cc: linux-sh@vger.kernel.org, linux-mmc@vger.kernel.org,
	Ian Molton <ian@mnementh.co.uk>
Subject: Re: [PATCH] mmc: tmio: fix address in kunmap_atomic() calls
Date: Mon, 14 Mar 2011 18:12:11 -0400	[thread overview]
Message-ID: <m38vwhuzb8.fsf@pullcord.laptop.org> (raw)
In-Reply-To: <Pine.LNX.4.64.1103110822160.23675@axis700.grange> (Guennadi Liakhovetski's message of "Fri, 11 Mar 2011 08:30:14 +0100 (CET)")

Hi Guennadi,

On Fri, Mar 11 2011, Guennadi Liakhovetski wrote:
> Currently kunmap_atomic() doesn't take into account the offset, used
> with kmap_atomic(). On platforms, where kunmap_atomic() is not a NOP,
> this will lead to problems, when offset != 0.
>
> Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
> ---
>
> No, I've never seen this bug trigger, so, not sure whether we need it for 
> .38 / stable.

Thanks, I've pushed this to mmc-next for .39.

Could I get your ACK on the sh/tmio patches in Linus W's "[PATCH 00/11]
MMC DMA-API/dmaengine fixups" patchset, please?

- Chris.
-- 
Chris Ball   <cjb@laptop.org>   <http://printf.net/>
One Laptop Per Child

WARNING: multiple messages have this Message-ID (diff)
From: Chris Ball <cjb@laptop.org>
To: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Cc: linux-sh@vger.kernel.org, linux-mmc@vger.kernel.org,
	Ian Molton <ian@mnementh.co.uk>
Subject: Re: [PATCH] mmc: tmio: fix address in kunmap_atomic() calls
Date: Mon, 14 Mar 2011 22:12:11 +0000	[thread overview]
Message-ID: <m38vwhuzb8.fsf@pullcord.laptop.org> (raw)
In-Reply-To: <Pine.LNX.4.64.1103110822160.23675@axis700.grange> (Guennadi Liakhovetski's message of "Fri, 11 Mar 2011 08:30:14 +0100 (CET)")

Hi Guennadi,

On Fri, Mar 11 2011, Guennadi Liakhovetski wrote:
> Currently kunmap_atomic() doesn't take into account the offset, used
> with kmap_atomic(). On platforms, where kunmap_atomic() is not a NOP,
> this will lead to problems, when offset != 0.
>
> Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
> ---
>
> No, I've never seen this bug trigger, so, not sure whether we need it for 
> .38 / stable.

Thanks, I've pushed this to mmc-next for .39.

Could I get your ACK on the sh/tmio patches in Linus W's "[PATCH 00/11]
MMC DMA-API/dmaengine fixups" patchset, please?

- Chris.
-- 
Chris Ball   <cjb@laptop.org>   <http://printf.net/>
One Laptop Per Child

  reply	other threads:[~2011-03-14 22:14 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-11  7:30 [PATCH] mmc: tmio: fix address in kunmap_atomic() calls Guennadi Liakhovetski
2011-03-11  7:30 ` Guennadi Liakhovetski
2011-03-14 22:12 ` Chris Ball [this message]
2011-03-14 22:12   ` Chris Ball
2011-03-14 22:54   ` Guennadi Liakhovetski
2011-03-14 22:54     ` Guennadi Liakhovetski
2011-03-18 20:35     ` Chris Ball
2011-03-18 20:35       ` Chris Ball

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m38vwhuzb8.fsf@pullcord.laptop.org \
    --to=cjb@laptop.org \
    --cc=g.liakhovetski@gmx.de \
    --cc=ian@mnementh.co.uk \
    --cc=linux-mmc@vger.kernel.org \
    --cc=linux-sh@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.