All of lore.kernel.org
 help / color / mirror / Atom feed
From: Markus Armbruster <armbru@redhat.com>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] fdc: fix drive property handling.
Date: Wed, 16 Dec 2009 15:45:32 +0100	[thread overview]
Message-ID: <m38wd3565v.fsf@crossbow.pond.sub.org> (raw)
In-Reply-To: <4B28E0C7.3010605@redhat.com> (Gerd Hoffmann's message of "Wed, 16 Dec 2009 14:29:43 +0100")

Gerd Hoffmann <kraxel@redhat.com> writes:

> On 12/16/09 11:03, Markus Armbruster wrote:
>> This fixes "-global isa-fdc,driveB=DRIVE-ID" for me, but problems
>> remain:
>>
>> * -drive if=none,id=fd,file=fd.img -global isa-fdc.driveA=fd
>>
>>            dev: isa-fdc, id ""
>>              dev-prop: driveA = floppy0
>>              dev-prop: driveB =<null>
>>              isa irq 6
>
> Patch is on the list.

Subject: [Qemu-devel] [FOR 0.12 PATCH 1/2] defaults: split default_drive
Subject: [Qemu-devel] [FOR 0.12 PATCH 2/2] defaults: update device_list[]

Works fine for me, just one oddity: setting any of the fdc's two drives
kills the default, i.e. setting driveB makes driveA empty.

>> * -drive if=none,id=fd,file=fd.img -global isa-fdc.driveA=fd,driveB=fd
>
> Oh, -global works like -set, i.e. you can't set multiple properties in
> one go.  Should be '-global isa-fdc.driveA=fd -global
> isa-fdc.driveB=fd'.
>
> The error reporting is *ahem*, well, not perfect.  Patch is on the list.

Subject: [Qemu-devel] [FOR 0.12 PATCH] qdev: improve property error reporting.

Works fine now.

  reply	other threads:[~2009-12-16 14:45 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-12-15 15:09 [Qemu-devel] [PATCH] fdc: fix drive property handling Gerd Hoffmann
2009-12-16 10:03 ` Markus Armbruster
2009-12-16 13:29   ` Gerd Hoffmann
2009-12-16 14:45     ` Markus Armbruster [this message]
  -- strict thread matches above, loose matches on Subject: below --
2010-03-10 16:30 Gerd Hoffmann
2010-03-13 11:16 ` Aurelien Jarno

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m38wd3565v.fsf@crossbow.pond.sub.org \
    --to=armbru@redhat.com \
    --cc=kraxel@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.