From: Chris Ball <cjb@laptop.org>
To: Tetsuyuki Kobayashi <koba@kmckk.co.jp>
Cc: linux-mmc@vger.kernel.org,
Guennadi Liakhovetski <g.liakhovetski@gmx.de>,
yusuke.goda.sx@renesas.com,
Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
Paul Mundt <lethal@linux-sh.org>, Magnus <magnus.damm@gmail.com>,
linux-sh@vger.kernel.org,
Kuninori Morimoto <kuninori.morimoto.gx@gmail.com>
Subject: Re: [PATCH] mmc: sh-mmcif: avoid Oops on spurious interrupts
Date: Wed, 26 Sep 2012 06:04:51 -0400 [thread overview]
Message-ID: <m3a9wdksl8.fsf@pullcord.laptop.org> (raw)
In-Reply-To: <50625ECB.6020601@kmckk.co.jp> (Tetsuyuki Kobayashi's message of "Wed, 26 Sep 2012 10:47:55 +0900")
Hi Kobayashi,
On Tue, Sep 25 2012, Tetsuyuki Kobayashi wrote:
> (09/19/2012 11:50 AM), Tetsuyuki Kobayashi wrote:
>> (2012/08/22 15:49), Guennadi Liakhovetski wrote:
>>> On some systems, e.g., kzm9g, MMCIF interfaces can produce spurious
>>> interrupts without any active request. To prevent the Oops, that results
>>> in such cases, don't dereference the mmc request pointer until we make
>>> sure, that we are indeed processing such a request.
>>>
>>> Reported-by: Tetsuyuki Kobayashi <koba@kmckk.co.jp>
>>> Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
>>
>> I verified on kzm9g.
>> This works with
>> [PATCH] mmc: sh-mmcif: properly handle MMC_WRITE_MULTIPLE_BLOCK
>> completion IRQ
>>
>> Tested-by: Tetsuyuki Kobayashi <koba@kmckk.co.jp>
>
> Without this patch, the following Oops occurs. (kzm9g on v3.6-rc7)
> Please push this to v3.6, not only 3.7-next.
I'm traveling from Shanghai to Boston (home) at the moment, so I can't
push this immediately. I'll either get it into 3.6, or 3.7 with a tag
for 3.6-stable.
Thanks,
- Chris.
--
Chris Ball <cjb@laptop.org> <http://printf.net/>
One Laptop Per Child
WARNING: multiple messages have this Message-ID (diff)
From: Chris Ball <cjb@laptop.org>
To: Tetsuyuki Kobayashi <koba@kmckk.co.jp>
Cc: linux-mmc@vger.kernel.org,
Guennadi Liakhovetski <g.liakhovetski@gmx.de>,
yusuke.goda.sx@renesas.com,
Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
Paul Mundt <lethal@linux-sh.org>, Magnus <magnus.damm@gmail.com>,
linux-sh@vger.kernel.org,
Kuninori Morimoto <kuninori.morimoto.gx@gmail.com>
Subject: Re: [PATCH] mmc: sh-mmcif: avoid Oops on spurious interrupts
Date: Wed, 26 Sep 2012 10:04:51 +0000 [thread overview]
Message-ID: <m3a9wdksl8.fsf@pullcord.laptop.org> (raw)
In-Reply-To: <50625ECB.6020601@kmckk.co.jp> (Tetsuyuki Kobayashi's message of "Wed, 26 Sep 2012 10:47:55 +0900")
Hi Kobayashi,
On Tue, Sep 25 2012, Tetsuyuki Kobayashi wrote:
> (09/19/2012 11:50 AM), Tetsuyuki Kobayashi wrote:
>> (2012/08/22 15:49), Guennadi Liakhovetski wrote:
>>> On some systems, e.g., kzm9g, MMCIF interfaces can produce spurious
>>> interrupts without any active request. To prevent the Oops, that results
>>> in such cases, don't dereference the mmc request pointer until we make
>>> sure, that we are indeed processing such a request.
>>>
>>> Reported-by: Tetsuyuki Kobayashi <koba@kmckk.co.jp>
>>> Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
>>
>> I verified on kzm9g.
>> This works with
>> [PATCH] mmc: sh-mmcif: properly handle MMC_WRITE_MULTIPLE_BLOCK
>> completion IRQ
>>
>> Tested-by: Tetsuyuki Kobayashi <koba@kmckk.co.jp>
>
> Without this patch, the following Oops occurs. (kzm9g on v3.6-rc7)
> Please push this to v3.6, not only 3.7-next.
I'm traveling from Shanghai to Boston (home) at the moment, so I can't
push this immediately. I'll either get it into 3.6, or 3.7 with a tag
for 3.6-stable.
Thanks,
- Chris.
--
Chris Ball <cjb@laptop.org> <http://printf.net/>
One Laptop Per Child
next prev parent reply other threads:[~2012-09-26 10:04 UTC|newest]
Thread overview: 61+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-02 9:50 irqdomain breaks ap4 boot kuninori.morimoto.gx
2012-08-03 5:00 ` Paul Mundt
2012-08-09 4:28 ` Paul Mundt
2012-08-09 4:53 ` Kuninori Morimoto
2012-08-10 6:10 ` Kuninori Morimoto
2012-08-10 12:38 ` Paul Mundt
2012-08-17 5:54 ` kzm9g boot fail (was Re: irqdomain breaks ap4 boot) Tetsuyuki Kobayashi
2012-08-20 1:14 ` Kuninori Morimoto
2012-08-20 3:13 ` Paul Mundt
2012-08-20 4:19 ` Kuninori Morimoto
2012-08-20 4:19 ` Tetsuyuki Kobayashi
2012-08-20 4:38 ` Paul Mundt
2012-08-20 4:45 ` Kuninori Morimoto
2012-08-20 5:24 ` Paul Mundt
2012-08-20 5:33 ` Tetsuyuki Kobayashi
2012-08-20 6:13 ` Kuninori Morimoto
2012-08-20 6:24 ` Kuninori Morimoto
2012-08-20 6:30 ` Paul Mundt
2012-08-20 6:32 ` Tetsuyuki Kobayashi
2012-08-22 6:49 ` [PATCH] mmc: sh-mmcif: avoid Oops on spurious interrupts Guennadi Liakhovetski
2012-08-22 6:49 ` Guennadi Liakhovetski
2012-08-22 12:16 ` Tetsuyuki Kobayashi
2012-08-22 12:16 ` Tetsuyuki Kobayashi
2012-08-23 7:11 ` Guennadi Liakhovetski
2012-08-23 7:11 ` Guennadi Liakhovetski
2012-09-04 7:40 ` Tetsuyuki Kobayashi
2012-09-04 7:40 ` Tetsuyuki Kobayashi
2012-08-31 3:05 ` Tetsuyuki Kobayashi
2012-08-31 3:05 ` Tetsuyuki Kobayashi
2012-09-18 6:13 ` Tetsuyuki Kobayashi
2012-09-18 6:13 ` Tetsuyuki Kobayashi
2012-09-18 6:42 ` Guennadi Liakhovetski
2012-09-18 6:42 ` Guennadi Liakhovetski
2012-09-18 8:02 ` Tetsuyuki Kobayashi
2012-09-18 8:02 ` Tetsuyuki Kobayashi
2012-09-18 8:44 ` Tetsuyuki Kobayashi
2012-09-18 8:44 ` Tetsuyuki Kobayashi
2012-09-18 8:56 ` Guennadi Liakhovetski
2012-09-18 8:56 ` Guennadi Liakhovetski
2012-09-19 2:50 ` Tetsuyuki Kobayashi
2012-09-19 2:50 ` Tetsuyuki Kobayashi
2012-09-26 1:47 ` Tetsuyuki Kobayashi
2012-09-26 1:47 ` Tetsuyuki Kobayashi
2012-09-26 10:04 ` Chris Ball [this message]
2012-09-26 10:04 ` Chris Ball
2012-09-19 6:24 ` Chris Ball
2012-09-19 6:24 ` Chris Ball
2012-09-21 2:35 ` Tetsuyuki Kobayashi
2012-09-21 2:35 ` Tetsuyuki Kobayashi
2012-08-20 7:18 ` kzm9g boot fail (was Re: irqdomain breaks ap4 boot) Magnus Damm
2012-08-20 7:40 ` Paul Mundt
2012-08-20 7:41 ` Kuninori Morimoto
2012-08-20 7:54 ` Paul Mundt
2012-08-20 8:12 ` Kuninori Morimoto
2012-08-20 8:35 ` Kuninori Morimoto
2012-08-21 2:31 ` Kuninori Morimoto
2012-08-21 4:22 ` Tetsuyuki Kobayashi
2012-08-31 6:55 ` irqdomain breaks ap4 boot Tetsuyuki Kobayashi
2012-08-31 7:17 ` Simon Horman
2012-08-31 10:36 ` Paul Mundt
2012-09-18 2:15 ` Tetsuyuki Kobayashi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3a9wdksl8.fsf@pullcord.laptop.org \
--to=cjb@laptop.org \
--cc=g.liakhovetski@gmx.de \
--cc=koba@kmckk.co.jp \
--cc=kuninori.morimoto.gx@gmail.com \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=lethal@linux-sh.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=yusuke.goda.sx@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.