From: Markus Armbruster <armbru@redhat.com>
To: "Hervé Poussineau" <hpoussin@reactos.org>
Cc: Kevin Wolf <kwolf@redhat.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v3 7/9] fdc: check if media rate is correct before doing any transfer
Date: Fri, 27 Jan 2012 09:56:05 +0100 [thread overview]
Message-ID: <m3aa59msm2.fsf@blackfin.pond.sub.org> (raw)
In-Reply-To: <1327308641-14736-8-git-send-email-hpoussin@reactos.org> ("Hervé Poussineau"'s message of "Mon, 23 Jan 2012 09:50:38 +0100")
Hervé Poussineau <hpoussin@reactos.org> writes:
> The programmed rate has to be the same as the required rate for the
> floppy format ; if that's not the case, the transfer should abort.
>
> Revalidate floppy after migration, so media_rate field doesn't have
> to be saved/restored.
I'm not at all sure that's a good idea.
The rate is guest state. It's value depends on the media. We guess the
media to use for a particular image. Same thing as for the geometry
(heads, tracks, sectors per track). We do migrate the geometry, see
vmstate_fdrive.
Why is it a good idea to treat rate differently?
Doesn't your fd_revalidate() in fdc_post_load() clobber the migrated
geometry?
next prev parent reply other threads:[~2012-01-27 9:10 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-23 8:50 [Qemu-devel] [PATCH v3 0/9] Misc fixes for floppy emulation Hervé Poussineau
2012-01-23 8:50 ` [Qemu-devel] [PATCH v3 1/9] fdc: take side count into account Hervé Poussineau
2012-01-27 8:38 ` Markus Armbruster
2012-01-27 20:11 ` Hervé Poussineau
2012-01-31 9:28 ` Markus Armbruster
2012-01-31 22:24 ` Hervé Poussineau
2012-01-23 8:50 ` [Qemu-devel] [PATCH v3 2/9] fdc: set busy bit when starting a command Hervé Poussineau
2012-01-23 8:50 ` [Qemu-devel] [PATCH v3 3/9] fdc: most control commands do not generate interrupts Hervé Poussineau
2012-01-23 8:50 ` [Qemu-devel] [PATCH v3 4/9] fdc: handle read-only floppies (abort early on write commands) Hervé Poussineau
2012-01-23 8:50 ` [Qemu-devel] [PATCH v3 5/9] fdc: add CCR (Configuration Control Register) write register Hervé Poussineau
2012-01-27 8:43 ` Markus Armbruster
2012-01-27 20:03 ` Hervé Poussineau
2012-01-31 9:31 ` Markus Armbruster
2012-01-31 22:16 ` Hervé Poussineau
2012-01-23 8:50 ` [Qemu-devel] [PATCH v3 6/9] block: add a transfer rate for floppy types Hervé Poussineau
2012-01-23 8:50 ` [Qemu-devel] [PATCH v3 7/9] fdc: check if media rate is correct before doing any transfer Hervé Poussineau
2012-01-27 8:56 ` Markus Armbruster [this message]
2012-01-23 8:50 ` [Qemu-devel] [PATCH v3 8/9] fdc: fix seek command, which shouldn't check tracks Hervé Poussineau
2012-01-23 8:50 ` [Qemu-devel] [PATCH v3 9/9] fdc: DIR (Digital Input Register) should return status of current drive Hervé Poussineau
2012-01-27 8:57 ` Markus Armbruster
2012-01-31 9:34 ` [Qemu-devel] [PATCH v3 0/9] Misc fixes for floppy emulation Markus Armbruster
2012-01-31 22:22 ` Hervé Poussineau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3aa59msm2.fsf@blackfin.pond.sub.org \
--to=armbru@redhat.com \
--cc=hpoussin@reactos.org \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.