From: Markus Armbruster <armbru@redhat.com>
To: Luiz Capitulino <lcapitulino@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 12/13] QMP: Introduce qmp_check_input_obj()
Date: Wed, 23 Jun 2010 19:20:14 +0200 [thread overview]
Message-ID: <m3aaqlpsxd.fsf@blackfin.pond.sub.org> (raw)
In-Reply-To: <20100623132904.79d8e424@redhat.com> (Luiz Capitulino's message of "Wed, 23 Jun 2010 13:29:04 -0300")
Luiz Capitulino <lcapitulino@redhat.com> writes:
> On Wed, 23 Jun 2010 17:23:54 +0200
> Markus Armbruster <armbru@redhat.com> wrote:
>
>> Luiz Capitulino <lcapitulino@redhat.com> writes:
[...]
>> > + qerror_report(QERR_QMP_UNEXPECTED_INPUT_OBJECT_MEMBER, arg_name);
>>
>> Identifier's a bit on the long side, isn't it?
>
> Yes, suggestions?
What about omitting INPUT_OBJECT or at least OBJECT?
EXTRA instead of UNEXPECTED?
We could have
QERR_QMP_EXTRA_MEMBER
QERR_QMP_MISSING_MEMBER now: QERR_QMP_BAD_INPUT_OBJECT (I think)
QERR_QMP_BAD_MEMBER now: QERR_QMP_BAD_INPUT_OBJECT_MEMBER
[...]
next prev parent reply other threads:[~2010-06-23 17:20 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-22 17:40 [Qemu-devel] [PATCH v2 00/13]: QMP: Replace client argument checker Luiz Capitulino
2010-06-22 17:40 ` [Qemu-devel] [PATCH 01/13] QDict: Rename 'err_value' Luiz Capitulino
2010-06-22 17:40 ` [Qemu-devel] [PATCH 02/13] QDict: Small terminology change Luiz Capitulino
2010-06-22 17:40 ` [Qemu-devel] [PATCH 03/13] QDict: Introduce functions to retrieve QDictEntry values Luiz Capitulino
2010-06-22 17:40 ` [Qemu-devel] [PATCH 04/13] QDict: Introduce new iteration API Luiz Capitulino
2010-06-22 17:40 ` [Qemu-devel] [PATCH 05/13] check-qdict: Introduce test for the " Luiz Capitulino
2010-06-22 17:40 ` [Qemu-devel] [PATCH 06/13] QDict: Introduce qdict_get_try_bool() Luiz Capitulino
2010-06-22 17:40 ` [Qemu-devel] [PATCH 07/13] Monitor: handle optional '-' arg as a bool Luiz Capitulino
2010-06-23 15:05 ` Markus Armbruster
2010-06-23 16:14 ` Luiz Capitulino
2010-06-23 16:31 ` Markus Armbruster
2010-06-23 16:43 ` Luiz Capitulino
2010-06-22 17:40 ` [Qemu-devel] [PATCH 08/13] QMP: New argument checker (first part) Luiz Capitulino
2010-06-22 17:40 ` [Qemu-devel] [PATCH 09/13] QMP: New argument checker (second part) Luiz Capitulino
2010-06-23 15:21 ` Markus Armbruster
2010-06-23 16:28 ` Luiz Capitulino
2010-06-23 17:16 ` Markus Armbruster
2010-06-22 17:40 ` [Qemu-devel] [PATCH 10/13] QMP: Drop old client argument checker Luiz Capitulino
2010-06-22 17:40 ` [Qemu-devel] [PATCH 11/13] QError: Introduce QERR_QMP_UNEXPECTED_INPUT_OBJECT_MEMBER Luiz Capitulino
2010-06-22 17:40 ` [Qemu-devel] [PATCH 12/13] QMP: Introduce qmp_check_input_obj() Luiz Capitulino
2010-06-23 15:23 ` Markus Armbruster
2010-06-23 16:29 ` Luiz Capitulino
2010-06-23 17:20 ` Markus Armbruster [this message]
2010-06-22 17:40 ` [Qemu-devel] [PATCH 13/13] QMP: Drop old input object checking Luiz Capitulino
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3aaqlpsxd.fsf@blackfin.pond.sub.org \
--to=armbru@redhat.com \
--cc=lcapitulino@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.