All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] Fix cosmetic issue in powernow-k8 error handling
@ 2004-08-09 18:26 Andi Kleen
  0 siblings, 0 replies; only message in thread
From: Andi Kleen @ 2004-08-09 18:26 UTC (permalink / raw)
  To: paul.devriendt, cpufreq


I tried to load the new SMP capable powernow k8 driver on a machine
with an too old BIOS. I got a lot of cryptic "init not cpu 0"
messages until the "MP systems not supported by PSB ..." message.

This patch switches the order of the checks around to print the
other message first. It will be still printed multiple times
because the cpufreq setup will probe all CPUs, but that's probably
ok.

BTW I also looked at converting the code to smp_call_function 
(because Paul complained about the set_cpus_allowed in his OLS
presentation). But the code would have been more complicated with
this change so I left it like it is.

-Andi

diff -u linux-2.6.8rc3-amd64/arch/i386/kernel/cpu/cpufreq/powernow-k8.c-o linux-2.6.8rc3-amd64/arch/i386/kernel/cpu/cpufreq/powernow-k8.c
--- linux-2.6.8rc3-amd64/arch/i386/kernel/cpu/cpufreq/powernow-k8.c-o	2004-06-16 12:22:43.000000000 +0200
+++ linux-2.6.8rc3-amd64/arch/i386/kernel/cpu/cpufreq/powernow-k8.c	2004-08-09 19:52:17.000000000 +0200
@@ -948,13 +948,13 @@
 		 * an UP version, and is deprecated by AMD.
 		 */
 
-		if (pol->cpu != 0) {
-			printk(KERN_ERR PFX "init not cpu 0\n");
+		if ((num_online_cpus() != 1) || (num_possible_cpus() != 1)) {
+			printk(KERN_INFO PFX "MP systems not supported by PSB BIOS structure\n");
 			kfree(data);
 			return -ENODEV;
 		}
-		if ((num_online_cpus() != 1) || (num_possible_cpus() != 1)) {
-			printk(KERN_INFO PFX "MP systems not supported by PSB BIOS structure\n");
+		if (pol->cpu != 0) {
+			printk(KERN_ERR PFX "init not cpu 0\n");
 			kfree(data);
 			return -ENODEV;
 		}

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2004-08-09 18:26 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-08-09 18:26 [PATCH] Fix cosmetic issue in powernow-k8 error handling Andi Kleen

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.