From: Chris Ball <cjb@laptop.org>
To: Lauri Hintsala <lauri.hintsala@bluegiga.com>
Cc: Matt Sealey <matt@genesi-usa.com>,
Shawn Guo <shawn.guo@linaro.org>,
veli-pekka.peltola@bluegiga.com, linux-mmc@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] mmc: mxs-mmc: implement broken-cd
Date: Mon, 17 Sep 2012 10:01:00 -0400 [thread overview]
Message-ID: <m3boh4n3z7.fsf@pullcord.laptop.org> (raw)
In-Reply-To: <50572907.6000700@bluegiga.com> (Lauri Hintsala's message of "Mon, 17 Sep 2012 16:43:35 +0300")
Hi,
On Mon, Sep 17 2012, Lauri Hintsala wrote:
> Is it OK to use broken-cd? broken-cd feature is documented as "There
> is no card detection available; polling must be used". In this case
> the card detect is not broken but it is unrouted so it is unavailable.
>
> Documentation about broken-cd has been added by commit:
> https://git.kernel.org/?p=linux/kernel/git/cjb/mmc.git;a=commitdiff;h=abe1e05da365350ac282ba5f6831aae13d97074e
I'm having trouble following the problem; it sounds like perhaps all you
need is:
if (of_find_property(np, "non-removable", NULL))
mmc->caps |= MMC_CAP_NONREMOVABLE;
Have you tried that?
- Chris.
--
Chris Ball <cjb@laptop.org> <http://printf.net/>
One Laptop Per Child
WARNING: multiple messages have this Message-ID (diff)
From: cjb@laptop.org (Chris Ball)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] mmc: mxs-mmc: implement broken-cd
Date: Mon, 17 Sep 2012 10:01:00 -0400 [thread overview]
Message-ID: <m3boh4n3z7.fsf@pullcord.laptop.org> (raw)
In-Reply-To: <50572907.6000700@bluegiga.com> (Lauri Hintsala's message of "Mon, 17 Sep 2012 16:43:35 +0300")
Hi,
On Mon, Sep 17 2012, Lauri Hintsala wrote:
> Is it OK to use broken-cd? broken-cd feature is documented as "There
> is no card detection available; polling must be used". In this case
> the card detect is not broken but it is unrouted so it is unavailable.
>
> Documentation about broken-cd has been added by commit:
> https://git.kernel.org/?p=linux/kernel/git/cjb/mmc.git;a=commitdiff;h=abe1e05da365350ac282ba5f6831aae13d97074e
I'm having trouble following the problem; it sounds like perhaps all you
need is:
if (of_find_property(np, "non-removable", NULL))
mmc->caps |= MMC_CAP_NONREMOVABLE;
Have you tried that?
- Chris.
--
Chris Ball <cjb@laptop.org> <http://printf.net/>
One Laptop Per Child
next prev parent reply other threads:[~2012-09-17 14:00 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-07 11:45 [PATCH] mmc: mxs-mmc: implement broken-cd Lauri Hintsala
2012-09-07 11:45 ` Lauri Hintsala
2012-09-10 6:08 ` Shawn Guo
2012-09-10 6:08 ` Shawn Guo
2012-09-10 10:04 ` Lauri Hintsala
2012-09-10 10:04 ` Lauri Hintsala
2012-09-10 13:50 ` Shawn Guo
2012-09-10 13:50 ` Shawn Guo
2012-09-20 4:45 ` Lauri Hintsala
2012-09-20 4:45 ` Lauri Hintsala
2012-09-10 14:58 ` Matt Sealey
2012-09-10 14:58 ` Matt Sealey
2012-09-12 14:06 ` Lauri Hintsala
2012-09-12 14:06 ` Lauri Hintsala
2012-09-17 13:43 ` Lauri Hintsala
2012-09-17 13:43 ` Lauri Hintsala
2012-09-17 14:01 ` Chris Ball [this message]
2012-09-17 14:01 ` Chris Ball
2012-09-17 14:40 ` Lauri Hintsala
2012-09-17 14:40 ` Lauri Hintsala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3boh4n3z7.fsf@pullcord.laptop.org \
--to=cjb@laptop.org \
--cc=lauri.hintsala@bluegiga.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mmc@vger.kernel.org \
--cc=matt@genesi-usa.com \
--cc=shawn.guo@linaro.org \
--cc=veli-pekka.peltola@bluegiga.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.