From: Chris Ball <cjb@laptop.org>
To: Maxim Levitsky <maximlevitsky@gmail.com>
Cc: "linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
Philip Langdale <philipl@overt.org>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/2] mmc: fix mmc card disappearence on resume on ricoh mmc controllers
Date: Mon, 07 Jun 2010 01:47:00 -0400 [thread overview]
Message-ID: <m3bpbn1jjf.fsf@pullcord.laptop.org> (raw)
In-Reply-To: <1275870795.24091.4.camel@maxim-laptop> (Maxim Levitsky's message of "Mon, 07 Jun 2010 03:33:15 +0300")
Hi Maxim,
>> It looks like your editor is set to four-space instead of
>> eight-space tab characters, else you wouldn't be using so
>> many tabs here.
> Nope, I think indention is right here.
>
> the break is inside 'if' condition.
Please look again, I think you're mistaken. For example, why do you
use seven tab characters for the "& SDHCI_CARD_PRESENT" after the if
line? With eight-space tabs, it looks like this (converted to
spaces):
+ if (sdhci_readl(host, SDHCI_PRESENT_STATE)
+ & SDHCI_CARD_PRESENT) {
See http://lkml.org/lkml/2010/6/6/171 for an eight-space tabs
rendering of the patch.
--
Chris Ball <cjb@laptop.org>
One Laptop Per Child
WARNING: multiple messages have this Message-ID (diff)
From: Chris Ball <cjb@laptop.org>
To: Maxim Levitsky <maximlevitsky@gmail.com>
Cc: "linux-mmc\@vger.kernel.org" <linux-mmc@vger.kernel.org>,
Philip Langdale <philipl@overt.org>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/2] mmc: fix mmc card disappearence on resume on ricoh mmc controllers
Date: Mon, 07 Jun 2010 01:47:00 -0400 [thread overview]
Message-ID: <m3bpbn1jjf.fsf@pullcord.laptop.org> (raw)
In-Reply-To: <1275870795.24091.4.camel@maxim-laptop> (Maxim Levitsky's message of "Mon, 07 Jun 2010 03:33:15 +0300")
Hi Maxim,
>> It looks like your editor is set to four-space instead of
>> eight-space tab characters, else you wouldn't be using so
>> many tabs here.
> Nope, I think indention is right here.
>
> the break is inside 'if' condition.
Please look again, I think you're mistaken. For example, why do you
use seven tab characters for the "& SDHCI_CARD_PRESENT" after the if
line? With eight-space tabs, it looks like this (converted to
spaces):
+ if (sdhci_readl(host, SDHCI_PRESENT_STATE)
+ & SDHCI_CARD_PRESENT) {
See http://lkml.org/lkml/2010/6/6/171 for an eight-space tabs
rendering of the patch.
--
Chris Ball <cjb@laptop.org>
One Laptop Per Child
next prev parent reply other threads:[~2010-06-07 5:47 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-02 18:56 strange problem with ricoh-mmc Maxim Levitsky
2010-06-02 19:54 ` Philip Langdale
2010-06-02 20:19 ` Maxim Levitsky
2010-06-02 20:42 ` Philip Langdale
2010-06-02 22:03 ` Maxim Levitsky
2010-06-03 1:16 ` [PATCH] mmc: make sdhci work with ricoh mmc controller Maxim Levitsky
2010-06-03 16:11 ` Philip Langdale
2010-06-03 16:31 ` Maxim Levitsky
2010-06-03 16:39 ` Philip Langdale
2010-06-03 17:05 ` Philip Langdale
2010-06-03 17:35 ` Maxim Levitsky
2010-06-04 4:42 ` Philip Langdale
2010-06-04 10:07 ` Maxim Levitsky
2010-06-04 15:05 ` Philip Langdale
2010-06-04 15:33 ` Maxim Levitsky
2010-06-06 21:24 ` Maxim Levitsky
2010-06-06 21:28 ` [PATCH 1/2] " Maxim Levitsky
2010-06-06 21:28 ` Maxim Levitsky
2010-06-06 23:11 ` Philip Langdale
2010-06-06 23:11 ` Philip Langdale
2010-06-07 0:37 ` Maxim Levitsky
2010-06-07 1:41 ` Philip Langdale
2010-06-11 19:08 ` [PATCH v3] " Maxim Levitsky
2010-06-11 19:15 ` [PATCH v4] " maximlevitsky
2010-06-13 11:29 ` Maxim Levitsky
2010-06-13 16:06 ` Philip Langdale
2010-06-06 21:28 ` [PATCH 2/2] mmc: fix mmc card disappearence on resume on ricoh mmc controllers Maxim Levitsky
2010-06-06 23:22 ` Philip Langdale
2010-06-06 23:22 ` Philip Langdale
2010-06-08 8:57 ` Maxim Levitsky
2010-06-06 23:23 ` Chris Ball
2010-06-07 0:33 ` Maxim Levitsky
2010-06-07 5:47 ` Chris Ball [this message]
2010-06-07 5:47 ` Chris Ball
2010-06-08 8:52 ` Maxim Levitsky
2010-06-03 1:22 ` strange problem with ricoh-mmc Maxim Levitsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3bpbn1jjf.fsf@pullcord.laptop.org \
--to=cjb@laptop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=maximlevitsky@gmail.com \
--cc=philipl@overt.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.