From: Andreas Schwab <schwab@linux-m68k.org>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Linux/m68k <linux-m68k@lists.linux-m68k.org>,
Linux Kernel Development <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] m68k/atari: Do not use "/" in interrupt names
Date: Wed, 04 May 2011 17:00:00 +0200 [thread overview]
Message-ID: <m3d3jybjf3.fsf@linux-m68k.org> (raw)
In-Reply-To: <alpine.DEB.2.00.1105041629390.2629@ayla.of.borg> (Geert Uytterhoeven's message of "Wed, 4 May 2011 16:30:03 +0200 (CEST)")
Geert Uytterhoeven <geert@linux-m68k.org> writes:
> diff --git a/arch/m68k/atari/atakeyb.c b/arch/m68k/atari/atakeyb.c
> index e1ada31..779efdc 100644
> --- a/arch/m68k/atari/atakeyb.c
> +++ b/arch/m68k/atari/atakeyb.c
> @@ -572,7 +572,7 @@ int atari_keyb_init(void)
> kb_state.len = 0;
>
> error = request_irq(IRQ_MFP_ACIA, atari_keyboard_interrupt,
> - IRQ_TYPE_SLOW, "keyboard/mouse/MIDI",
> + IRQ_TYPE_SLOW, "keyboard:mouse:MIDI",
The name is not a path, but an enumeration, so the slash should probably
be changed to a comma instead.
> diff --git a/arch/m68k/atari/stdma.c b/arch/m68k/atari/stdma.c
> index 604329f..ad68fe9 100644
> --- a/arch/m68k/atari/stdma.c
> +++ b/arch/m68k/atari/stdma.c
> @@ -180,7 +180,7 @@ void __init stdma_init(void)
> {
> stdma_isr = NULL;
> if (request_irq(IRQ_MFP_FDC, stdma_int, IRQ_TYPE_SLOW | IRQF_SHARED,
> - "ST-DMA: floppy/ACSI/IDE/Falcon-SCSI", stdma_int))
> + "ST-DMA floppy:ACSI:IDE:Falcon-SCSI", stdma_int))
Likewise.
> diff --git a/drivers/net/atarilance.c b/drivers/net/atarilance.c
> index ce0091e..1833b12 100644
> --- a/drivers/net/atarilance.c
> +++ b/drivers/net/atarilance.c
> @@ -554,7 +554,7 @@ static unsigned long __init lance_probe1( struct net_device *dev,
> memaddr == (unsigned short *)0xffe00000) {
> /* PAMs card and Riebl on ST use level 5 autovector */
> if (request_irq(IRQ_AUTO_5, lance_interrupt, IRQ_TYPE_PRIO,
> - "PAM/Riebl-ST Ethernet", dev)) {
> + "PAM:Riebl-ST Ethernet", dev)) {
Likewise.
Andreas.
--
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."
WARNING: multiple messages have this Message-ID (diff)
From: Andreas Schwab <schwab@linux-m68k.org>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Linux/m68k <linux-m68k@vger.kernel.org>,
Linux Kernel Development <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] m68k/atari: Do not use "/" in interrupt names
Date: Wed, 04 May 2011 17:00:00 +0200 [thread overview]
Message-ID: <m3d3jybjf3.fsf@linux-m68k.org> (raw)
In-Reply-To: <alpine.DEB.2.00.1105041629390.2629@ayla.of.borg> (Geert Uytterhoeven's message of "Wed, 4 May 2011 16:30:03 +0200 (CEST)")
Geert Uytterhoeven <geert@linux-m68k.org> writes:
> diff --git a/arch/m68k/atari/atakeyb.c b/arch/m68k/atari/atakeyb.c
> index e1ada31..779efdc 100644
> --- a/arch/m68k/atari/atakeyb.c
> +++ b/arch/m68k/atari/atakeyb.c
> @@ -572,7 +572,7 @@ int atari_keyb_init(void)
> kb_state.len = 0;
>
> error = request_irq(IRQ_MFP_ACIA, atari_keyboard_interrupt,
> - IRQ_TYPE_SLOW, "keyboard/mouse/MIDI",
> + IRQ_TYPE_SLOW, "keyboard:mouse:MIDI",
The name is not a path, but an enumeration, so the slash should probably
be changed to a comma instead.
> diff --git a/arch/m68k/atari/stdma.c b/arch/m68k/atari/stdma.c
> index 604329f..ad68fe9 100644
> --- a/arch/m68k/atari/stdma.c
> +++ b/arch/m68k/atari/stdma.c
> @@ -180,7 +180,7 @@ void __init stdma_init(void)
> {
> stdma_isr = NULL;
> if (request_irq(IRQ_MFP_FDC, stdma_int, IRQ_TYPE_SLOW | IRQF_SHARED,
> - "ST-DMA: floppy/ACSI/IDE/Falcon-SCSI", stdma_int))
> + "ST-DMA floppy:ACSI:IDE:Falcon-SCSI", stdma_int))
Likewise.
> diff --git a/drivers/net/atarilance.c b/drivers/net/atarilance.c
> index ce0091e..1833b12 100644
> --- a/drivers/net/atarilance.c
> +++ b/drivers/net/atarilance.c
> @@ -554,7 +554,7 @@ static unsigned long __init lance_probe1( struct net_device *dev,
> memaddr == (unsigned short *)0xffe00000) {
> /* PAMs card and Riebl on ST use level 5 autovector */
> if (request_irq(IRQ_AUTO_5, lance_interrupt, IRQ_TYPE_PRIO,
> - "PAM/Riebl-ST Ethernet", dev)) {
> + "PAM:Riebl-ST Ethernet", dev)) {
Likewise.
Andreas.
--
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."
next prev parent reply other threads:[~2011-05-04 15:00 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-04 14:30 [PATCH] m68k/atari: Do not use "/" in interrupt names Geert Uytterhoeven
2011-05-04 14:30 ` Geert Uytterhoeven
2011-05-04 15:00 ` Andreas Schwab [this message]
2011-05-04 15:00 ` Andreas Schwab
2011-05-04 17:45 ` Geert Uytterhoeven
2011-05-05 4:33 ` Michael Schmitz
2011-05-08 8:41 ` Geert Uytterhoeven
2011-05-04 17:45 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3d3jybjf3.fsf@linux-m68k.org \
--to=schwab@linux-m68k.org \
--cc=geert@linux-m68k.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@lists.linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.