All of lore.kernel.org
 help / color / mirror / Atom feed
From: Markus Armbruster <armbru@redhat.com>
To: Jes.Sorensen@redhat.com
Cc: pbonzini@redhat.com, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v9 0/4] Introduce strtosz and make use of it
Date: Fri, 22 Oct 2010 09:59:45 +0200	[thread overview]
Message-ID: <m3d3r2ejym.fsf@blackfin.pond.sub.org> (raw)
In-Reply-To: <1287674149-25418-1-git-send-email-Jes.Sorensen@redhat.com> (Jes Sorensen's message of "Thu, 21 Oct 2010 17:15:45 +0200")

Jes.Sorensen@redhat.com writes:

> From: Jes Sorensen <Jes.Sorensen@redhat.com>
>
> This patch introduces cutils.c: strtosz() and gets rid of the
> multiple custom hacks for parsing byte sizes. In addition it adds
> supports for specifying human style sizes such as 1.5G. Last it
> eliminates the horrible abuse of a float to store the byte size for
> migrate_set_speed in the monitor.
>
> Note, this is tested on Linux and build tested for win32 using
> mingw32.
>
> v9: I worked through a couple of revisions directly with Markus and I
> think I got it right finally. 

I'd prefer to have strtosz() to match strtol() & friends and not
restrict suffixes.  But this code does what it claims to do, as far as I
can see, so:

ACK series

  parent reply	other threads:[~2010-10-22  8:14 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-21 15:15 [Qemu-devel] [PATCH v9 0/4] Introduce strtosz and make use of it Jes.Sorensen
2010-10-21 15:15 ` [Qemu-devel] [PATCH 1/4] Introduce strtosz() library function to convert a string to a byte count Jes.Sorensen
2010-11-03 18:27   ` [Qemu-devel] " Anthony Liguori
2010-10-21 15:15 ` [Qemu-devel] [PATCH 2/4] Add support for 'o' octet (bytes) format as monitor parameter Jes.Sorensen
2010-10-21 15:15 ` [Qemu-devel] [PATCH 3/4] Switch migrate_set_speed() to take an 'o' argument rather than a float Jes.Sorensen
2010-10-21 15:15 ` [Qemu-devel] [PATCH 4/4] Remove obsolete 'f' double parameter type Jes.Sorensen
2010-10-22  7:59 ` Markus Armbruster [this message]
2010-10-22  8:05   ` [Qemu-devel] [PATCH v9 0/4] Introduce strtosz and make use of it Jes Sorensen
2010-10-22  9:27     ` Markus Armbruster

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m3d3r2ejym.fsf@blackfin.pond.sub.org \
    --to=armbru@redhat.com \
    --cc=Jes.Sorensen@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.