From: Markus Armbruster <armbru@redhat.com>
To: Luiz Capitulino <lcapitulino@redhat.com>
Cc: kwolf@redhat.com, Eduardo Habkost <ehabkost@redhat.com>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] monitor: allow device to be ejected if no disk is inserted
Date: Mon, 07 Jun 2010 08:57:12 +0200 [thread overview]
Message-ID: <m3d3w349fb.fsf@blackfin.pond.sub.org> (raw)
In-Reply-To: <20100604150120.752571e8@redhat.com> (Luiz Capitulino's message of "Fri, 4 Jun 2010 15:01:20 -0300")
Luiz Capitulino <lcapitulino@redhat.com> writes:
> On Tue, 1 Jun 2010 19:12:19 -0300
> Eduardo Habkost <ehabkost@redhat.com> wrote:
>
>> I have no clue why the code had the is_inserted() check, as it doesn't matter
>> if there is a disk present at the host drive, when the user wants the virtual
>> device to be disconnected from the host device.
>
> Makes sense, although I have no idea if doing a bdrv_close() on a bs which
> doesn't have an image inserted has any side effect.
Should be a no-op.
> Basic testing works as expected, though.
>
> Anyway, I think this should go through the block queue.
Makes sense.
next prev parent reply other threads:[~2010-06-07 6:57 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-01 22:12 [Qemu-devel] [PATCH] monitor: allow device to be ejected if no disk is inserted Eduardo Habkost
2010-06-04 18:01 ` Luiz Capitulino
2010-06-07 6:57 ` Markus Armbruster [this message]
2010-06-07 11:18 ` Kevin Wolf
2010-06-07 12:19 ` Markus Armbruster
2010-06-07 12:43 ` Eduardo Habkost
2010-06-07 12:53 ` Kevin Wolf
2010-06-07 13:18 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3d3w349fb.fsf@blackfin.pond.sub.org \
--to=armbru@redhat.com \
--cc=ehabkost@redhat.com \
--cc=kwolf@redhat.com \
--cc=lcapitulino@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.