All of lore.kernel.org
 help / color / mirror / Atom feed
From: khalasa@piap.pl (Krzysztof Hałasa)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 08/11] ARM: ixp4xx: fix {in,out}s{bwl} data types
Date: Mon, 16 Feb 2015 15:16:46 +0100	[thread overview]
Message-ID: <m3fva6vt4h.fsf@t19.piap.pl> (raw)
In-Reply-To: <1423770163-583064-9-git-send-email-arnd@arndb.de> (Arnd Bergmann's message of "Thu, 12 Feb 2015 20:42:40 +0100")

Arnd Bergmann <arnd@arndb.de> writes:

> Most platforms use void pointer arguments in these functions, but
> ixp4xx does not, which triggers lots of warnings in device drivers like:
>
> net/ethernet/8390/ne2k-pci.c: In function 'ne2k_pci_get_8390_hdr':
> net/ethernet/8390/ne2k-pci.c:503:3: warning: passing argument 2 of 'insw' from incompatible pointer type
>    insw(NE_BASE + NE_DATAPORT, hdr, sizeof(struct e8390_pkt_hdr)>>1);
>    ^
> In file included from include/asm/io.h:214:0,
>                  from /git/arm-soc/include/linux/io.h:22,
>                  from /git/arm-soc/include/linux/pci.h:31,
>                  from net/ethernet/8390/ne2k-pci.c:48:
> mach-ixp4xx/include/mach/io.h:316:91: note: expected 'u16 *' but argument is of type 'struct e8390_pkt_hdr *'
>  static inline void insw(u32 io_addr, u16 *vaddr, u32 count)
>
> Fixing the drivers seems hopeless, so this changes the ixp4xx code
> to do the same as the others to avoid the warnings.

Acked-by: Krzysztof Halasa <khalasa@piap.pl>
-- 
Krzysztof Halasa

Research Institute for Automation and Measurements PIAP
Al. Jerozolimskie 202, 02-486 Warsaw, Poland

WARNING: multiple messages have this Message-ID (diff)
From: khalasa@piap.pl (Krzysztof Hałasa)
To: Arnd Bergmann <arnd@arndb.de>
Cc: linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, arm@kernel.org,
	Imre Kaloz <kaloz@openwrt.org>
Subject: Re: [PATCH 08/11] ARM: ixp4xx: fix {in,out}s{bwl} data types
Date: Mon, 16 Feb 2015 15:16:46 +0100	[thread overview]
Message-ID: <m3fva6vt4h.fsf@t19.piap.pl> (raw)
In-Reply-To: <1423770163-583064-9-git-send-email-arnd@arndb.de> (Arnd Bergmann's message of "Thu, 12 Feb 2015 20:42:40 +0100")

Arnd Bergmann <arnd@arndb.de> writes:

> Most platforms use void pointer arguments in these functions, but
> ixp4xx does not, which triggers lots of warnings in device drivers like:
>
> net/ethernet/8390/ne2k-pci.c: In function 'ne2k_pci_get_8390_hdr':
> net/ethernet/8390/ne2k-pci.c:503:3: warning: passing argument 2 of 'insw' from incompatible pointer type
>    insw(NE_BASE + NE_DATAPORT, hdr, sizeof(struct e8390_pkt_hdr)>>1);
>    ^
> In file included from include/asm/io.h:214:0,
>                  from /git/arm-soc/include/linux/io.h:22,
>                  from /git/arm-soc/include/linux/pci.h:31,
>                  from net/ethernet/8390/ne2k-pci.c:48:
> mach-ixp4xx/include/mach/io.h:316:91: note: expected 'u16 *' but argument is of type 'struct e8390_pkt_hdr *'
>  static inline void insw(u32 io_addr, u16 *vaddr, u32 count)
>
> Fixing the drivers seems hopeless, so this changes the ixp4xx code
> to do the same as the others to avoid the warnings.

Acked-by: Krzysztof Halasa <khalasa@piap.pl>
-- 
Krzysztof Halasa

Research Institute for Automation and Measurements PIAP
Al. Jerozolimskie 202, 02-486 Warsaw, Poland

  reply	other threads:[~2015-02-16 14:16 UTC|newest]

Thread overview: 72+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-12 19:42 [PATCH 00/11] ARM: random randconfig fixes, soc specific Arnd Bergmann
2015-02-12 19:42 ` Arnd Bergmann
2015-02-12 19:42 ` [PATCH 01/11] ARM: vexpress: use ARM_CPU_SUSPEND if needed Arnd Bergmann
2015-02-12 19:42   ` Arnd Bergmann
2015-02-13  1:31   ` Nicolas Pitre
2015-02-13  1:31     ` Nicolas Pitre
2015-02-13 10:37   ` Liviu Dudau
2015-02-13 10:37     ` Liviu Dudau
2015-02-13 10:57     ` Russell King - ARM Linux
2015-02-13 10:57       ` Russell King - ARM Linux
2015-02-13 11:01       ` Liviu Dudau
2015-02-13 11:01         ` Liviu Dudau
2015-02-13 11:16         ` Russell King - ARM Linux
2015-02-13 11:16           ` Russell King - ARM Linux
2015-02-13 11:22           ` Liviu Dudau
2015-02-13 11:22             ` Liviu Dudau
2015-02-13 23:03             ` Nicolas Pitre
2015-02-13 23:03               ` Nicolas Pitre
2015-02-13 22:55     ` Nicolas Pitre
2015-02-13 22:55       ` Nicolas Pitre
2015-02-14  1:34       ` Liviu Dudau
2015-02-14  1:34         ` Liviu Dudau
2015-02-14 20:42         ` Lorenzo Pieralisi
2015-02-14 20:42           ` Lorenzo Pieralisi
2015-02-12 19:42 ` [PATCH 02/11] ARM: sunxi: always select RESET_CONTROLLER Arnd Bergmann
2015-02-12 19:42   ` Arnd Bergmann
2015-02-13  9:09   ` Maxime Ripard
2015-02-13  9:09     ` Maxime Ripard
2015-02-16 20:47     ` Arnd Bergmann
2015-02-16 20:47       ` Arnd Bergmann
2015-02-12 19:42 ` [PATCH 03/11] ARM: BCM: put back ARCH_MULTI_V7 dependency for mobile Arnd Bergmann
2015-02-12 19:42   ` Arnd Bergmann
2015-02-12 20:02   ` Florian Fainelli
2015-02-12 20:02     ` Florian Fainelli
2015-02-12 20:08     ` arnd at arndb.de
2015-02-12 20:08       ` arnd
2015-02-12 21:57   ` Florian Fainelli
2015-02-12 21:57     ` Florian Fainelli
2015-02-12 22:07     ` Scott Branden
2015-02-12 22:07       ` Scott Branden
2015-02-12 19:42 ` [PATCH 04/11] ARM: davinci: davinci_cfg_reg cannot be init Arnd Bergmann
2015-02-12 19:42   ` Arnd Bergmann
2015-02-16 15:37   ` Sekhar Nori
2015-02-16 15:37     ` Sekhar Nori
2015-02-12 19:42 ` [PATCH 05/11] ARM: davinci: multi-soc kernels require AUTO_ZRELADDR Arnd Bergmann
2015-02-12 19:42   ` Arnd Bergmann
2015-02-16 15:50   ` Sekhar Nori
2015-02-16 15:50     ` Sekhar Nori
2015-02-12 19:42 ` [PATCH 06/11] ARM: at91: fix pm declarations Arnd Bergmann
2015-02-12 19:42   ` Arnd Bergmann
2015-02-13  8:37   ` Nicolas Ferre
2015-02-13  8:37     ` Nicolas Ferre
2015-02-12 19:42 ` [PATCH 07/11] ARM: prima2: do not select SMP_ON_UP Arnd Bergmann
2015-02-12 19:42   ` Arnd Bergmann
2015-02-13  3:05   ` Barry Song
2015-02-13  3:05     ` Barry Song
2015-02-12 19:42 ` [PATCH 08/11] ARM: ixp4xx: fix {in,out}s{bwl} data types Arnd Bergmann
2015-02-12 19:42   ` Arnd Bergmann
2015-02-16 14:16   ` Krzysztof Hałasa [this message]
2015-02-16 14:16     ` Krzysztof Hałasa
2015-02-12 19:42 ` [PATCH 09/11] ARM: rockchip: make rockchip_suspend_init conditional Arnd Bergmann
2015-02-12 19:42   ` Arnd Bergmann
2015-02-13 19:26   ` Heiko Stübner
2015-02-13 19:26     ` Heiko Stübner
2015-02-12 19:42 ` [PATCH 10/11] ARM: sti: always enable RESET_CONTROLLER Arnd Bergmann
2015-02-12 19:42   ` Arnd Bergmann
2015-02-13  7:28   ` Patrice Chotard
2015-02-13  7:28     ` Patrice Chotard
2015-02-13  8:09   ` Maxime Coquelin
2015-02-13  8:09     ` Maxime Coquelin
2015-02-12 19:42 ` [PATCH 11/11] ARM: mvebu: build armada375-smp code conditionally Arnd Bergmann
2015-02-12 19:42   ` Arnd Bergmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m3fva6vt4h.fsf@t19.piap.pl \
    --to=khalasa@piap.pl \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.