* [PATCH] pata_marvell: fix cable detection
@ 2006-11-17 18:04 Arnaud Patard
2006-11-17 23:40 ` Alan
0 siblings, 1 reply; 2+ messages in thread
From: Arnaud Patard @ 2006-11-17 18:04 UTC (permalink / raw)
To: linux-ide; +Cc: alan
[-- Attachment #1: Type: text/plain, Size: 171 bytes --]
A "break;" is missing in the cable detection switch() statement, leading
to a wrong detection of the cable type.
Signed-off-by: Arnaud Patard <apatard@mandriva.com>
---
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: pata_marvell_fix_cbl_detect.patch --]
[-- Type: text/x-patch, Size: 401 bytes --]
Index: libata-dev/drivers/ata/pata_marvell.c
===================================================================
--- libata-dev.orig/drivers/ata/pata_marvell.c
+++ libata-dev/drivers/ata/pata_marvell.c
@@ -62,6 +62,7 @@ static int marvell_pre_reset(struct ata_
ap->cbl = ATA_CBL_PATA80;
else
ap->cbl = ATA_CBL_PATA40;
+ break;
case 1: /* Legacy SATA port */
ap->cbl = ATA_CBL_SATA;
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] pata_marvell: fix cable detection
2006-11-17 18:04 [PATCH] pata_marvell: fix cable detection Arnaud Patard
@ 2006-11-17 23:40 ` Alan
0 siblings, 0 replies; 2+ messages in thread
From: Alan @ 2006-11-17 23:40 UTC (permalink / raw)
To: Arnaud Patard; +Cc: linux-ide, alan
On Fri, 17 Nov 2006 19:04:06 +0100
Arnaud Patard <apatard@mandriva.com> wrote:
>
> A "break;" is missing in the cable detection switch() statement, leading
> to a wrong detection of the cable type.
>
> Signed-off-by: Arnaud Patard <apatard@mandriva.com>
Acked-by: Alan Cox <alan@redhat.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2006-11-17 23:34 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-11-17 18:04 [PATCH] pata_marvell: fix cable detection Arnaud Patard
2006-11-17 23:40 ` Alan
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.