From: ebiederman@lnxi.com (Eric W. Biederman)
To: "Jörn Engel" <joern@wohnheim.fh-wedel.de>
Cc: joern@wh.fh-wedel.de, Amit Gud <amitg@calsoftinc.com>,
gud@eth.net, linux-mtd@lists.infradead.org,
kernel-janitors@lists.osdl.org,
David Woodhouse <dwmw2@infradead.org>
Subject: [KJ] Re: [PATCH 8/18] drivers/mtd/ remove pci_find_{device, subsys}
Date: Mon, 14 Feb 2005 18:41:22 +0000 [thread overview]
Message-ID: <m3fyzzx9v1.fsf@maxwell.lnxi.com> (raw)
In-Reply-To: <20050214175251.GA28755@wohnheim.fh-wedel.de>
Jörn Engel <joern@wohnheim.fh-wedel.de> writes:
> Looks fairly simple, but I've never dealt with pci_find_device(), so
> my voice doesn't count.
When switching from pci_find_device to pci_get_device
the corresponding call to pci_dev_put() needs to be added.
In addition we need an entry in compat.h
Beyond that ich2rom.c should just be deleted. It was renamed
ichxrom.c a while ago.
Eric
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors
WARNING: multiple messages have this Message-ID (diff)
From: ebiederman@lnxi.com (Eric W. Biederman)
To: "Jörn Engel" <joern@wohnheim.fh-wedel.de>
Cc: joern@wh.fh-wedel.de, Amit Gud <amitg@calsoftinc.com>,
gud@eth.net, linux-mtd@lists.infradead.org,
kernel-janitors@lists.osdl.org,
David Woodhouse <dwmw2@infradead.org>
Subject: Re: [PATCH 8/18] drivers/mtd/ remove pci_find_{device, subsys}
Date: 14 Feb 2005 11:41:22 -0700 [thread overview]
Message-ID: <m3fyzzx9v1.fsf@maxwell.lnxi.com> (raw)
In-Reply-To: <20050214175251.GA28755@wohnheim.fh-wedel.de>
Jörn Engel <joern@wohnheim.fh-wedel.de> writes:
> Looks fairly simple, but I've never dealt with pci_find_device(), so
> my voice doesn't count.
When switching from pci_find_device to pci_get_device
the corresponding call to pci_dev_put() needs to be added.
In addition we need an entry in compat.h
Beyond that ich2rom.c should just be deleted. It was renamed
ichxrom.c a while ago.
Eric
next prev parent reply other threads:[~2005-02-14 18:41 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-02-14 6:04 [KJ] [PATCH 8/18] drivers/mtd/ remove pci_find_{device, subsys} Amit Gud
2005-02-14 17:52 ` [KJ] " Jörn Engel
2005-02-14 17:52 ` Jörn Engel
2005-02-14 18:40 ` [KJ] Re: [PATCH 8/18] drivers/mtd/ remove pci_find_{device, Greg KH
2005-02-14 18:40 ` [KJ] Re: [PATCH 8/18] drivers/mtd/ remove pci_find_{device, subsys} Greg KH
2005-02-14 18:41 ` Eric W. Biederman [this message]
2005-02-14 18:41 ` Eric W. Biederman
2005-02-14 18:23 ` [KJ] " Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3fyzzx9v1.fsf@maxwell.lnxi.com \
--to=ebiederman@lnxi.com \
--cc=amitg@calsoftinc.com \
--cc=dwmw2@infradead.org \
--cc=gud@eth.net \
--cc=joern@wh.fh-wedel.de \
--cc=joern@wohnheim.fh-wedel.de \
--cc=kernel-janitors@lists.osdl.org \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.