* Re: [PATCH] staging: media: imx: make use devm_platform_ioremap_resource [not found] <1570515459-25609-1-git-send-email-hariprasad.kelam@gmail.com> @ 2019-10-08 8:54 ` Rui Miguel Silva 0 siblings, 0 replies; 2+ messages in thread From: Rui Miguel Silva @ 2019-10-08 8:54 UTC (permalink / raw) To: Hariprasad Kelam, Steve Longerbeam, Philipp Zabel, Mauro Carvalho Chehab, Greg Kroah-Hartman, Shawn Guo, Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam, NXP Linux Team, linux-media, devel, linux-arm-kernel, linux-kernel Hi Hariprasad, Thanks for the patch On Tue 08 Oct 2019 at 07:17, nobody wrote: > From: Hariprasad Kelam <hariprasad.kelam@gmail.com> > Something went wrong formating the patch email, no To: nor From: > > fix below issue reported by coccicheck > drivers/staging//media/imx/imx7-mipi-csis.c:973:1-12: WARNING: Use > devm_platform_ioremap_resource for state -> regs > Sorry, but someone else, Jeeeun, already sent a patch for this [0]. Thanks anyway. --- Cheers, Rui [0]: https://lore.kernel.org/linux-media/m3wodvgec4.fsf@gmail.com/ > > Signed-off-by: Hariprasad Kelam <hariprasad.kelam@gmail.com> > --- > drivers/staging/media/imx/imx7-mipi-csis.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/staging/media/imx/imx7-mipi-csis.c b/drivers/staging/media/imx/imx7-mipi-csis.c > index 73d8354..bf21db3 100644 > --- a/drivers/staging/media/imx/imx7-mipi-csis.c > +++ b/drivers/staging/media/imx/imx7-mipi-csis.c > @@ -947,7 +947,6 @@ static void mipi_csis_debugfs_exit(struct csi_state *state) > static int mipi_csis_probe(struct platform_device *pdev) > { > struct device *dev = &pdev->dev; > - struct resource *mem_res; > struct csi_state *state; > int ret; > > @@ -969,8 +968,7 @@ static int mipi_csis_probe(struct platform_device *pdev) > mipi_csis_phy_init(state); > mipi_csis_phy_reset(state); > > - mem_res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > - state->regs = devm_ioremap_resource(dev, mem_res); > + state->regs = devm_platform_ioremap_resource(pdev, 0); > if (IS_ERR(state->regs)) > return PTR_ERR(state->regs); _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] staging: media: imx: make use devm_platform_ioremap_resource @ 2019-10-08 8:54 ` Rui Miguel Silva 0 siblings, 0 replies; 2+ messages in thread From: Rui Miguel Silva @ 2019-10-08 8:54 UTC (permalink / raw) To: Hariprasad Kelam, Steve Longerbeam, Philipp Zabel, Mauro Carvalho Chehab, Greg Kroah-Hartman, Shawn Guo, Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam, NXP Linux Team, linux-media, devel, linux-arm-kernel, linux-kernel Hi Hariprasad, Thanks for the patch On Tue 08 Oct 2019 at 07:17, nobody wrote: > From: Hariprasad Kelam <hariprasad.kelam@gmail.com> > Something went wrong formating the patch email, no To: nor From: > > fix below issue reported by coccicheck > drivers/staging//media/imx/imx7-mipi-csis.c:973:1-12: WARNING: Use > devm_platform_ioremap_resource for state -> regs > Sorry, but someone else, Jeeeun, already sent a patch for this [0]. Thanks anyway. --- Cheers, Rui [0]: https://lore.kernel.org/linux-media/m3wodvgec4.fsf@gmail.com/ > > Signed-off-by: Hariprasad Kelam <hariprasad.kelam@gmail.com> > --- > drivers/staging/media/imx/imx7-mipi-csis.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/staging/media/imx/imx7-mipi-csis.c b/drivers/staging/media/imx/imx7-mipi-csis.c > index 73d8354..bf21db3 100644 > --- a/drivers/staging/media/imx/imx7-mipi-csis.c > +++ b/drivers/staging/media/imx/imx7-mipi-csis.c > @@ -947,7 +947,6 @@ static void mipi_csis_debugfs_exit(struct csi_state *state) > static int mipi_csis_probe(struct platform_device *pdev) > { > struct device *dev = &pdev->dev; > - struct resource *mem_res; > struct csi_state *state; > int ret; > > @@ -969,8 +968,7 @@ static int mipi_csis_probe(struct platform_device *pdev) > mipi_csis_phy_init(state); > mipi_csis_phy_reset(state); > > - mem_res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > - state->regs = devm_ioremap_resource(dev, mem_res); > + state->regs = devm_platform_ioremap_resource(pdev, 0); > if (IS_ERR(state->regs)) > return PTR_ERR(state->regs); ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-10-08 8:54 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1570515459-25609-1-git-send-email-hariprasad.kelam@gmail.com>
2019-10-08 8:54 ` [PATCH] staging: media: imx: make use devm_platform_ioremap_resource Rui Miguel Silva
2019-10-08 8:54 ` Rui Miguel Silva
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.