All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chris Ball <cjb@laptop.org>
To: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
	linux-next@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-sh@vger.kernel.org, linux-mmc@vger.kernel.org
Subject: Re: [PATCH] mmc: SDHI should depend on SUPERH || ARCH_SHMOBILE
Date: Mon, 28 Mar 2011 09:39:04 -0400	[thread overview]
Message-ID: <m3lizzicuf.fsf@pullcord.laptop.org> (raw)
In-Reply-To: <Pine.LNX.4.64.1103280913170.6625@axis700.grange> (Guennadi Liakhovetski's message of "Mon, 28 Mar 2011 09:16:33 +0200 (CEST)")

Hi,

On Mon, Mar 28 2011, Guennadi Liakhovetski wrote:
> Fix build breakage on platforms, not providing readsw and writesw
> functions, e.g., on x86(_64).
>
> Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
> Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
> ---
>
> Subject: Re: linux-next: build failure after merge of the mmc tree
>
> On Mon, 28 Mar 2011, Stephen Rothwell wrote:
>
>> Hi Chris,
>> 
>> After merging the mmc tree, today's linux-next build (x86_64 allmodconfig)
>> failed like this:
>> 
>> drivers/mmc/host/tmio_mmc_pio.c: In function 'sd_ctrl_read16_rep':
>> drivers/mmc/host/tmio_mmc_pio.c:56: error: implicit declaration of function 'readsw'
>> drivers/mmc/host/tmio_mmc_pio.c: In function 'sd_ctrl_write16_rep':
>> drivers/mmc/host/tmio_mmc_pio.c:73: error: implicit declaration of function 'writesw'
>> 
>> Presumably caused by commit b6147490e6aa ("mmc: tmio: split core
>> functionality, DMA and MFD glue").
>> 
>> I have used the mmc tree from next-20110325 for tdoay.
>
> Stephen, please verify, that this fixes your problem.

I've verified the fix and pushed it to mmc-next, so this should be fixed
tomorrow.  Thanks!

- Chris.
-- 
Chris Ball   <cjb@laptop.org>   <http://printf.net/>
One Laptop Per Child

WARNING: multiple messages have this Message-ID (diff)
From: Chris Ball <cjb@laptop.org>
To: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
	linux-next@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-sh@vger.kernel.org, linux-mmc@vger.kernel.org
Subject: Re: [PATCH] mmc: SDHI should depend on SUPERH || ARCH_SHMOBILE
Date: Mon, 28 Mar 2011 13:39:04 +0000	[thread overview]
Message-ID: <m3lizzicuf.fsf@pullcord.laptop.org> (raw)
In-Reply-To: <Pine.LNX.4.64.1103280913170.6625@axis700.grange> (Guennadi Liakhovetski's message of "Mon, 28 Mar 2011 09:16:33 +0200 (CEST)")

Hi,

On Mon, Mar 28 2011, Guennadi Liakhovetski wrote:
> Fix build breakage on platforms, not providing readsw and writesw
> functions, e.g., on x86(_64).
>
> Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
> Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
> ---
>
> Subject: Re: linux-next: build failure after merge of the mmc tree
>
> On Mon, 28 Mar 2011, Stephen Rothwell wrote:
>
>> Hi Chris,
>> 
>> After merging the mmc tree, today's linux-next build (x86_64 allmodconfig)
>> failed like this:
>> 
>> drivers/mmc/host/tmio_mmc_pio.c: In function 'sd_ctrl_read16_rep':
>> drivers/mmc/host/tmio_mmc_pio.c:56: error: implicit declaration of function 'readsw'
>> drivers/mmc/host/tmio_mmc_pio.c: In function 'sd_ctrl_write16_rep':
>> drivers/mmc/host/tmio_mmc_pio.c:73: error: implicit declaration of function 'writesw'
>> 
>> Presumably caused by commit b6147490e6aa ("mmc: tmio: split core
>> functionality, DMA and MFD glue").
>> 
>> I have used the mmc tree from next-20110325 for tdoay.
>
> Stephen, please verify, that this fixes your problem.

I've verified the fix and pushed it to mmc-next, so this should be fixed
tomorrow.  Thanks!

- Chris.
-- 
Chris Ball   <cjb@laptop.org>   <http://printf.net/>
One Laptop Per Child

  reply	other threads:[~2011-03-28 13:39 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-28  2:10 linux-next: build failure after merge of the mmc tree Stephen Rothwell
2011-03-28  7:16 ` [PATCH] mmc: SDHI should depend on SUPERH || ARCH_SHMOBILE Guennadi Liakhovetski
2011-03-28  7:16   ` Guennadi Liakhovetski
2011-03-28 13:39   ` Chris Ball [this message]
2011-03-28 13:39     ` Chris Ball

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m3lizzicuf.fsf@pullcord.laptop.org \
    --to=cjb@laptop.org \
    --cc=g.liakhovetski@gmx.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=linux-sh@vger.kernel.org \
    --cc=sfr@canb.auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.