[PATCH] fix checkpoint header exports

[PATCH] fix checkpoint header exports

[Nathan Lynch]

checkpoint_types.h is not useful to userspace.  Unexport it.

checkpoint.h contains definitions that userspace needs.  Export it.

user-cr can now be built against exported headers.

Signed-off-by: Nathan Lynch <ntl-e+AXbWqSrlAAvxtiuMwx3w@public.gmane.org>

---

(against ckpt-v16-x86 as of a couple days ago; git.ncl.cs.columbia.edu
appears unresponsive atm)

 include/linux/Kbuild |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/include/linux/Kbuild b/include/linux/Kbuild
index 25b7c0e..df43556 100644
--- a/include/linux/Kbuild
+++ b/include/linux/Kbuild
@@ -44,7 +44,7 @@ header-y += bpqether.h
 header-y += bsg.h
 header-y += can.h
 header-y += cdk.h
-header-y += checkpoint_types.h
+header-y += checkpoint.h
 header-y += checkpoint_hdr.h
 header-y += chio.h
 header-y += coda_psdev.h
-- 
1.6.0.6

Re: [PATCH] fix checkpoint header exports

[Oren Laadan]

Thanks, will apply.

git.ncl.cs.columbia.edu was down due to departmental network
issues. It's back to life.

Oren.

Nathan Lynch wrote:
> checkpoint_types.h is not useful to userspace.  Unexport it.
> 
> checkpoint.h contains definitions that userspace needs.  Export it.
> 
> user-cr can now be built against exported headers.
> 
> Signed-off-by: Nathan Lynch <ntl-e+AXbWqSrlAAvxtiuMwx3w@public.gmane.org>
> 
> ---
> 
> (against ckpt-v16-x86 as of a couple days ago; git.ncl.cs.columbia.edu
> appears unresponsive atm)
> 
>  include/linux/Kbuild |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/include/linux/Kbuild b/include/linux/Kbuild
> index 25b7c0e..df43556 100644
> --- a/include/linux/Kbuild
> +++ b/include/linux/Kbuild
> @@ -44,7 +44,7 @@ header-y += bpqether.h
>  header-y += bsg.h
>  header-y += can.h
>  header-y += cdk.h
> -header-y += checkpoint_types.h
> +header-y += checkpoint.h
>  header-y += checkpoint_hdr.h
>  header-y += chio.h
>  header-y += coda_psdev.h

Re: [PATCH] fix checkpoint header exports

[Sukadev Bhattiprolu]

Nathan Lynch [ntl-e+AXbWqSrlAAvxtiuMwx3w@public.gmane.org] wrote:
| checkpoint_types.h is not useful to userspace.  Unexport it.

Hmm, I get this error when compiling ckpt-v16-dev when compiling for x86

home/suka/containers/build/linux-cr/usr/include/linux/fs.h:11: included
file 'linux/checkpoint_types.h' is not exported

(did not get this error on another machine).

Re: [PATCH] fix checkpoint header exports

[Nathan Lynch]

Sukadev Bhattiprolu <sukadev-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org> writes:
> Nathan Lynch [ntl-e+AXbWqSrlAAvxtiuMwx3w@public.gmane.org] wrote:
> | checkpoint_types.h is not useful to userspace.  Unexport it.
>
> Hmm, I get this error when compiling ckpt-v16-dev when compiling for x86
>
> home/suka/containers/build/linux-cr/usr/include/linux/fs.h:11: included
> file 'linux/checkpoint_types.h' is not exported

Sorry.  I neglected to run make headers_check with this change, which
would have caught this.  Will fix this soon -- you can add
checkpoint_types.h back to headers-y to work around this, I think.