Re: [PATCH v5 1/2] media: ov2680: dt: Add bindings for OV2680

[Rui Miguel Silva <rui.silva@linaro.org>]

Hi Fabio,
On Tue 24 Apr 2018 at 15:53, Fabio Estevam wrote:
> Hi Rui,
>
> On Thu, Apr 19, 2018 at 8:00 AM, Rui Miguel Silva 
> <rui.silva@linaro.org> wrote:
>> Add device tree binding documentation for the OV2680 camera 
>> sensor.
>>
>> Reviewed-by: Rob Herring <robh@kernel.org>
>> CC: devicetree@vger.kernel.org
>> Signed-off-by: Rui Miguel Silva <rui.silva@linaro.org>
>> ---
>>  .../devicetree/bindings/media/i2c/ov2680.txt  | 40 
>>  +++++++++++++++++++
>>  1 file changed, 40 insertions(+)
>>  create mode 100644 
>>  Documentation/devicetree/bindings/media/i2c/ov2680.txt
>>
>> diff --git 
>> a/Documentation/devicetree/bindings/media/i2c/ov2680.txt 
>> b/Documentation/devicetree/bindings/media/i2c/ov2680.txt
>> new file mode 100644
>> index 000000000000..0e29f1a113c0
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/media/i2c/ov2680.txt
>> @@ -0,0 +1,40 @@
>> +* Omnivision OV2680 MIPI CSI-2 sensor
>> +
>> +Required Properties:
>> +- compatible: should be "ovti,ov2680".
>> +- clocks: reference to the xvclk input clock.
>> +- clock-names: should be "xvclk".
>
> You missed to pass the camera power supplies as required 
> properties:

Urgh, yes, you are right, I will add this.

---
Cheers,
	Rui

>
> DOVDD-supply
> AVDD-supply
> DVDD-supply