From: Markus Armbruster <armbru@redhat.com>
To: Pavel Borzenkov <pavel.borzenkov@gmail.com>
Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH] cmd: Fix potential NULL pointer dereference
Date: Mon, 31 Oct 2011 07:27:52 +0100 [thread overview]
Message-ID: <m3pqhdn09j.fsf@blackfin.pond.sub.org> (raw)
In-Reply-To: <1319838533-25405-1-git-send-email-pavel.borzenkov@gmail.com> (Pavel Borzenkov's message of "Sat, 29 Oct 2011 01:48:53 +0400")
Pavel Borzenkov <pavel.borzenkov@gmail.com> writes:
> Signed-off-by: Pavel Borzenkov <pavel.borzenkov@gmail.com>
> ---
> Note, that almost all code in the file violates CODING STYLE. The changed lines
> are written wrt CODING STYLE (like commits 7d7d975c and c32d766a).
>
> ---
>
> cmd.c | 11 +++--------
> 1 files changed, 3 insertions(+), 8 deletions(-)
>
> diff --git a/cmd.c b/cmd.c
> index f77897e..abcf206 100644
> --- a/cmd.c
> +++ b/cmd.c
> @@ -49,7 +49,7 @@ void
> add_command(
> const cmdinfo_t *ci)
> {
> - cmdtab = realloc((void *)cmdtab, ++ncmds * sizeof(*cmdtab));
> + cmdtab = g_realloc((void *)cmdtab, ++ncmds * sizeof(*cmdtab));
> cmdtab[ncmds - 1] = *ci;
> qsort(cmdtab, ncmds, sizeof(*cmdtab), compare);
> }
Inconsistent indentation.
Either stick to the original indentation, or reindent the whole
function.
[More of the same...]
WARNING: multiple messages have this Message-ID (diff)
From: Markus Armbruster <armbru@redhat.com>
To: Pavel Borzenkov <pavel.borzenkov@gmail.com>
Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] cmd: Fix potential NULL pointer dereference
Date: Mon, 31 Oct 2011 07:27:52 +0100 [thread overview]
Message-ID: <m3pqhdn09j.fsf@blackfin.pond.sub.org> (raw)
In-Reply-To: <1319838533-25405-1-git-send-email-pavel.borzenkov@gmail.com> (Pavel Borzenkov's message of "Sat, 29 Oct 2011 01:48:53 +0400")
Pavel Borzenkov <pavel.borzenkov@gmail.com> writes:
> Signed-off-by: Pavel Borzenkov <pavel.borzenkov@gmail.com>
> ---
> Note, that almost all code in the file violates CODING STYLE. The changed lines
> are written wrt CODING STYLE (like commits 7d7d975c and c32d766a).
>
> ---
>
> cmd.c | 11 +++--------
> 1 files changed, 3 insertions(+), 8 deletions(-)
>
> diff --git a/cmd.c b/cmd.c
> index f77897e..abcf206 100644
> --- a/cmd.c
> +++ b/cmd.c
> @@ -49,7 +49,7 @@ void
> add_command(
> const cmdinfo_t *ci)
> {
> - cmdtab = realloc((void *)cmdtab, ++ncmds * sizeof(*cmdtab));
> + cmdtab = g_realloc((void *)cmdtab, ++ncmds * sizeof(*cmdtab));
> cmdtab[ncmds - 1] = *ci;
> qsort(cmdtab, ncmds, sizeof(*cmdtab), compare);
> }
Inconsistent indentation.
Either stick to the original indentation, or reindent the whole
function.
[More of the same...]
next prev parent reply other threads:[~2011-10-31 6:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-28 21:48 [Qemu-trivial] [PATCH] cmd: Fix potential NULL pointer dereference Pavel Borzenkov
2011-10-28 21:48 ` [Qemu-devel] " Pavel Borzenkov
2011-10-31 6:27 ` Markus Armbruster [this message]
2011-10-31 6:27 ` Markus Armbruster
2011-10-31 7:18 ` [Qemu-trivial] " Pavel Borzenkov
2011-10-31 7:18 ` Pavel Borzenkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3pqhdn09j.fsf@blackfin.pond.sub.org \
--to=armbru@redhat.com \
--cc=pavel.borzenkov@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.