From: Markus Armbruster <armbru@redhat.com>
To: Luiz Capitulino <lcapitulino@redhat.com>
Cc: kwolf@redhat.com, hch@lst.de, qemu-devel@nongnu.org, kraxel@redhat.com
Subject: Re: [Qemu-devel] [PATCH v3 3/6] block QMP: Drop query-block member "type" (type= in info block)
Date: Thu, 12 May 2011 19:12:56 +0200 [thread overview]
Message-ID: <m3pqnnetbb.fsf@blackfin.pond.sub.org> (raw)
In-Reply-To: <20110512140143.1ffb7eeb@doriath> (Luiz Capitulino's message of "Thu, 12 May 2011 14:01:43 -0300")
Luiz Capitulino <lcapitulino@redhat.com> writes:
> On Thu, 12 May 2011 17:05:12 +0200
> Markus Armbruster <armbru@redhat.com> wrote:
>
>> Its value is unreliable: a block device used as floppy has type
>> "floppy" if created with if=floppy, but type "hd" if created with
>> if=none.
>>
>> That's because with if=none, the type is at best a declaration of
>> intent: the drive can be connected to any guest device. Its type is
>> really the guest device's business. Reporting it here is wrong.
>
> It reports how the guest is using the device, right? I'd say that's what
> users/clients are interested in knowing.
The value is *unreliable*. It may or may not match how the guest is
using the device. I doubt users are interested in unreliable
information.
> Also, we can't just drop it from QMP. We should first note it's deprecated.
Would you accept a change to the more honest value "unknown" for the
deprecation period?
next prev parent reply other threads:[~2011-05-12 17:13 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-12 15:05 [Qemu-devel] [PATCH v2 0/5] Split ide-drive and scsi-disk qdevs, and more Markus Armbruster
2011-05-12 15:05 ` [Qemu-devel] [PATCH v3 1/6] ide: Split qdev "ide-drive" into "ide-hd" and "ide-cd" Markus Armbruster
2011-05-12 15:05 ` [Qemu-devel] [PATCH v3 2/6] scsi: Split qdev "scsi-disk" into "scsi-hd" and "scsi-cd" Markus Armbruster
2011-05-12 15:05 ` [Qemu-devel] [PATCH v3 3/6] block QMP: Drop query-block member "type" (type= in info block) Markus Armbruster
2011-05-12 17:01 ` Luiz Capitulino
2011-05-12 17:12 ` Markus Armbruster [this message]
2011-05-12 17:22 ` Luiz Capitulino
2011-05-12 17:54 ` Markus Armbruster
2011-05-12 18:36 ` Luiz Capitulino
2011-05-13 8:26 ` Markus Armbruster
2011-05-13 13:39 ` Luiz Capitulino
2011-05-13 14:13 ` Markus Armbruster
2011-05-13 15:09 ` Luiz Capitulino
2011-05-12 15:05 ` [Qemu-devel] [PATCH v3 4/6] blockdev: Store -drive option media in DriveInfo Markus Armbruster
2011-05-12 15:05 ` [Qemu-devel] [PATCH v3 5/6] block: Remove type hint, it's guest matter, doesn't belong here Markus Armbruster
2011-05-12 15:05 ` [Qemu-devel] [PATCH v3 6/6] defaults: ide-cd and scsi-cd devices suppress default CD-ROM Markus Armbruster
2011-05-12 15:56 ` [Qemu-devel] [PATCH v2 0/5] Split ide-drive and scsi-disk qdevs, and more Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3pqnnetbb.fsf@blackfin.pond.sub.org \
--to=armbru@redhat.com \
--cc=hch@lst.de \
--cc=kraxel@redhat.com \
--cc=kwolf@redhat.com \
--cc=lcapitulino@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.