All of lore.kernel.org
 help / color / mirror / Atom feed
From: Juan Quintela <quintela@redhat.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: Shahar Havivi <shaharh@redhat.com>, qemu-devel@nongnu.org
Subject: [Qemu-devel] Re: [PATCH 2/2] Added monitor commands: 'keyboard_set' and 'info keybaord'
Date: Wed, 31 Mar 2010 18:58:14 +0200	[thread overview]
Message-ID: <m3pr2k1l95.fsf@trasno.mitica> (raw)
In-Reply-To: <m3oci4o6ca.fsf@blackfin.pond.sub.org> (Markus Armbruster's message of "Wed, 31 Mar 2010 17:31:49 +0200")

Markus Armbruster <armbru@redhat.com> wrote:
> Juan Quintela <quintela@redhat.com> writes:
>> I still think that adding an "id" property as in markus proposal would
>> be neat.  Otherwise I don't know how you are going to distinguish
>> between two keyboards with the same name.
>
> If I understand the patch correctly (only time for a quick skim today),
> the keyboard receives a numeric ID when it is created, and keyboard_set
> identifies it by that ID.  Yes, a user-defined ID would be nicer, and
> consistent with how similar things work.  But the numeric ID isn't
> *wrong*, as far as I can see.

my problem is that if you add two keyboards of the same type, they will
receive random index (different ones), now you do info keyboard, and you
see two keyboard with the same names and different numbers, how do you
know which of the two given you want to choose?

And no, I don't have magic bullet to make multimonitor/keyboard/mouse
behave as expected out of given them right id's.

Later, Juan.

  parent reply	other threads:[~2010-03-31 16:58 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-31  8:15 [Qemu-devel] [PATCH 0/2 v3] Qemu support for multiple keyboard devices Shahar Havivi
2010-03-31  8:16 ` [Qemu-devel] [PATCH 1/2] Support " Shahar Havivi
2010-03-31 10:12   ` [Qemu-devel] " Juan Quintela
2010-03-31 15:11     ` Shahar Havivi
2010-03-31 15:23   ` [Qemu-devel] " Markus Armbruster
2010-03-31 15:36     ` Shahar Havivi
2010-03-31  8:16 ` [Qemu-devel] [PATCH 2/2] Added monitor commands: 'keyboard_set' and 'info keybaord' Shahar Havivi
2010-03-31 10:20   ` [Qemu-devel] " Juan Quintela
2010-03-31 15:31     ` Markus Armbruster
2010-03-31 15:42       ` Shahar Havivi
2010-03-31 16:58       ` Juan Quintela [this message]
2010-03-31 19:37         ` Shahar Havivi
2010-03-31 19:52           ` Anthony Liguori
2010-03-31 20:16             ` Juan Quintela
2010-03-31 17:04     ` Anthony Liguori
2010-03-31 20:55       ` Shahar Havivi
  -- strict thread matches above, loose matches on Subject: below --
2010-03-23 19:57 [Qemu-devel] [PATCH 0/2] Qemu support for multiple keyboard devices - v2 Shahar Havivi
2010-03-23 19:58 ` [Qemu-devel] [PATCH 2/2] Added monitor commands: 'keyboard_set' and 'info keybaord' Shahar Havivi
2010-03-26  9:57   ` Markus Armbruster
2010-03-26 18:40     ` Shahar Havivi
2010-03-31 15:10       ` Markus Armbruster
2010-03-31 15:19         ` [Qemu-devel] " Juan Quintela

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m3pr2k1l95.fsf@trasno.mitica \
    --to=quintela@redhat.com \
    --cc=armbru@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=shaharh@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.