Re: [Qemu-devel] [PATCH v2 1/8] monitor: Document argument type 'M'

[Markus Armbruster <armbru@redhat.com>]

"Krumme, Chris" <Chris.Krumme@windriver.com> writes:

> Hello Markus,
>
> Not sure of the best answer, but thought there should be some
> discussion.
>
> You mention Mebibyte, which according to the all knowing Wikipedia, is
> abbreviated Mi.
>
> I understand that if you will only support one, then maybe you don't
> need to differentiate from Megabyte, but then in a later patch you use
> m, u, and n for powers of 10. This causes your new double format to use
> powers of 2 above one and powers of 10 below.

Really?

Argument types M and b use powers of 2.

Argument type T uses powers of 10.

> Maybe this is just one of those geek things, powers of 2 for integers,
> and powers of 10 for fractions.
>
> Good luck.

I merely reimplemented existing usage in a way that does the right thing
for QMP.  Can't say I like the ad-hocery there, but improving the
(non-QMP) monitor is not my objective right now.