All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Krzysztof Hałasa" <khalasa@piap.pl>
To: Corentin Labbe <clabbe.montjoie@gmail.com>
Cc: linusw@kernel.org,  kaloz@openwrt.org,  linux@armlinux.org.uk,
	linux-arm-kernel@lists.infradead.org,
	 linux-kernel@vger.kernel.org
Subject: Re: intel-ixp42x-welltech-epbx100 no longer boot due to 463dbba4d189 ("ARM: 9104/2: Fix Keystone 2 kernel mapping regression")
Date: Tue, 28 Sep 2021 12:32:13 +0200	[thread overview]
Message-ID: <m3r1d9ng7m.fsf@t19.piap.pl> (raw)
In-Reply-To: <YVLD/UMRYA55WiGI@Red> (Corentin Labbe's message of "Tue, 28 Sep 2021 09:27:57 +0200")

Hello Corentin,

Corentin Labbe <clabbe.montjoie@gmail.com> writes:

> I am working on puting my ixp4xx board on kernelCI.
> But it no longer boot since 4.14.
> It only prints "Starting kernelUncompressing Linux... done, booting the kernel." then nothing.
>
> I bisected the break to 463dbba4d189 ("ARM: 9104/2: Fix Keystone 2 kernel mapping regression")

I guess you build your kernel as big-endian.

These parts seem suspicious to me:

-    str r8, [r5]            @ Save physical start of kernel
+#ifdef CONFIG_CPU_ENDIAN_BE8
+    str r8, [r5, #4]            @ Save physical start of kernel (BE)
+#else
+    str r8, [r5]            @ Save physical start of kernel (LE)
+#endif

and

-    str r3, [r5]            @ Save physical end of kernel
+#ifdef CONFIG_CPU_ENDIAN_BE8
+    str r3, [r5, #4]            @ Save physical end of kernel (BE)
+#else
+    str r3, [r5]            @ Save physical end of kernel (LE)
+#endif

IXP4xx, being ARMv5, uses CONFIG_CPU_ENDIAN_BE32 (when configured as
BE), but it needs the ", #4" as well.

I'd test with: #if defined CONFIG_CPU_ENDIAN_BE8 || defined CONFIG_CPU_ENDIAN_BE32
--
Krzysztof "Chris" Hałasa

Sieć Badawcza Łukasiewicz
Przemysłowy Instytut Automatyki i Pomiarów PIAP
Al. Jerozolimskie 202, 02-486 Warszawa

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: "Krzysztof Hałasa" <khalasa@piap.pl>
To: Corentin Labbe <clabbe.montjoie@gmail.com>
Cc: linusw@kernel.org, kaloz@openwrt.org, linux@armlinux.org.uk,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: intel-ixp42x-welltech-epbx100 no longer boot due to 463dbba4d189 ("ARM: 9104/2: Fix Keystone 2 kernel mapping regression")
Date: Tue, 28 Sep 2021 12:32:13 +0200	[thread overview]
Message-ID: <m3r1d9ng7m.fsf@t19.piap.pl> (raw)
In-Reply-To: <YVLD/UMRYA55WiGI@Red> (Corentin Labbe's message of "Tue, 28 Sep 2021 09:27:57 +0200")

Hello Corentin,

Corentin Labbe <clabbe.montjoie@gmail.com> writes:

> I am working on puting my ixp4xx board on kernelCI.
> But it no longer boot since 4.14.
> It only prints "Starting kernelUncompressing Linux... done, booting the kernel." then nothing.
>
> I bisected the break to 463dbba4d189 ("ARM: 9104/2: Fix Keystone 2 kernel mapping regression")

I guess you build your kernel as big-endian.

These parts seem suspicious to me:

-    str r8, [r5]            @ Save physical start of kernel
+#ifdef CONFIG_CPU_ENDIAN_BE8
+    str r8, [r5, #4]            @ Save physical start of kernel (BE)
+#else
+    str r8, [r5]            @ Save physical start of kernel (LE)
+#endif

and

-    str r3, [r5]            @ Save physical end of kernel
+#ifdef CONFIG_CPU_ENDIAN_BE8
+    str r3, [r5, #4]            @ Save physical end of kernel (BE)
+#else
+    str r3, [r5]            @ Save physical end of kernel (LE)
+#endif

IXP4xx, being ARMv5, uses CONFIG_CPU_ENDIAN_BE32 (when configured as
BE), but it needs the ", #4" as well.

I'd test with: #if defined CONFIG_CPU_ENDIAN_BE8 || defined CONFIG_CPU_ENDIAN_BE32
--
Krzysztof "Chris" Hałasa

Sieć Badawcza Łukasiewicz
Przemysłowy Instytut Automatyki i Pomiarów PIAP
Al. Jerozolimskie 202, 02-486 Warszawa

  reply	other threads:[~2021-09-28 10:34 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-28  7:27 intel-ixp42x-welltech-epbx100 no longer boot due to 463dbba4d189 ("ARM: 9104/2: Fix Keystone 2 kernel mapping regression") Corentin Labbe
2021-09-28  7:27 ` Corentin Labbe
2021-09-28 10:32 ` Krzysztof Hałasa [this message]
2021-09-28 10:32   ` Krzysztof Hałasa
2021-09-28 11:38   ` Corentin Labbe
2021-09-28 11:38     ` Corentin Labbe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m3r1d9ng7m.fsf@t19.piap.pl \
    --to=khalasa@piap.pl \
    --cc=clabbe.montjoie@gmail.com \
    --cc=kaloz@openwrt.org \
    --cc=linusw@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.