From: Juan Quintela <quintela@redhat.com>
To: Jes.Sorensen@redhat.com
Cc: qemu-devel@nongnu.org, armbru@redhat.com
Subject: [Qemu-devel] Re: [PATCH 2/5] Support human unit formats in strtobytes, eg. 1.0G
Date: Wed, 15 Sep 2010 16:50:40 +0200 [thread overview]
Message-ID: <m3sk1bdprz.fsf@trasno.org> (raw)
In-Reply-To: <1284553440-17985-3-git-send-email-Jes.Sorensen@redhat.com> (Jes Sorensen's message of "Wed, 15 Sep 2010 14:23:57 +0200")
Jes.Sorensen@redhat.com wrote:
> From: Jes Sorensen <Jes.Sorensen@redhat.com>
> value <<= 10;
> break;
> case 0:
> + if (divider) {
> + value = 0;
> + break;
changing break by goto fail here?
1.5G and 1.0G is ok, but using 1024.00 or similar should be one error,
no?
nice cleanup for the rest of the patch series.
Later, Juan.
> + }
> case 'M':
> case 'm':
> value <<= 20;
next prev parent reply other threads:[~2010-09-15 14:53 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-15 12:23 [Qemu-devel] [PATCH 0/5] Introduce strtobytes and make use of it Jes.Sorensen
2010-09-15 12:23 ` [Qemu-devel] [PATCH 1/5] Introduce strtobytes() library function to convert string to byte count Jes.Sorensen
2010-09-15 18:46 ` Andreas Färber
2010-09-15 20:50 ` Stefan Weil
2010-09-15 12:23 ` [Qemu-devel] [PATCH 2/5] Support human unit formats in strtobytes, eg. 1.0G Jes.Sorensen
2010-09-15 14:50 ` Juan Quintela [this message]
2010-09-15 19:29 ` [Qemu-devel] " Jes Sorensen
2010-09-15 15:45 ` Paolo Bonzini
2010-09-15 15:50 ` Anthony Liguori
2010-09-15 19:31 ` Jes Sorensen
2010-09-16 7:19 ` Paolo Bonzini
2010-09-16 10:14 ` Jes Sorensen
2010-09-16 10:40 ` Avi Kivity
2010-09-16 10:42 ` Jes Sorensen
2010-09-16 10:46 ` Avi Kivity
2010-09-16 11:09 ` Paolo Bonzini
2010-09-15 12:23 ` [Qemu-devel] [PATCH 3/5] Add support for 'o' octet (bytes) format as monitor parameter Jes.Sorensen
2010-09-15 12:23 ` [Qemu-devel] [PATCH 4/5] Switch migrate_set_speed() to take an 'o' argument rather than a float Jes.Sorensen
2010-09-15 12:24 ` [Qemu-devel] [PATCH 5/5] Remove obsolete 'f' double parameter type Jes.Sorensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3sk1bdprz.fsf@trasno.org \
--to=quintela@redhat.com \
--cc=Jes.Sorensen@redhat.com \
--cc=armbru@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.