All of lore.kernel.org
 help / color / mirror / Atom feed
From: khc@pm.waw.pl (Krzysztof Halasa)
To: linux-arm-kernel@lists.infradead.org
Subject: ARM: 2.6.3[45] PCI regression (IXP4xx and PXA?)
Date: Tue, 10 Aug 2010 22:36:21 +0200	[thread overview]
Message-ID: <m3sk2m433u.fsf@intrepid.localdomain> (raw)

Hi,

Noticed this problem a bit late :-(

6fee48cd330c68332f9712bc968d934a1a84a32a broke
pci_set_consistent_dma_mask() on IXP4xx and most probably PXA. Affected
devices are e.g. IDE controller (CS5536-based: disk inaccessible) and
e1000 ethernet ("Detected Tx Unit Hang").

The attached patch makes it work again, though I'm not sure it's the
best solution.

Ideas?

Signed-off-by: Krzysztof Ha?asa <khc@pm.waw.pl>

diff --git a/include/linux/dma-mapping.h b/include/linux/dma-mapping.h
index ca32ed7..bd2a7d3 100644
--- a/include/linux/dma-mapping.h
+++ b/include/linux/dma-mapping.h
@@ -129,6 +129,14 @@ static inline u64 dma_get_mask(struct device *dev)
 
 static inline int dma_set_coherent_mask(struct device *dev, u64 mask)
 {
+#ifdef CONFIG_DMABOUNCE
+	if (dev->archdata.dmabounce) {
+		if (mask >= ISA_DMA_THRESHOLD)
+			return 0;
+		else
+			return -EIO;
+	}
+#endif
 	if (!dma_supported(dev, mask))
 		return -EIO;
 	dev->coherent_dma_mask = mask;

WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Halasa <khc@pm.waw.pl>
To: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
Cc: linux-arm-kernel@lists.infradead.org,
	lkml <linux-kernel@vger.kernel.org>
Subject: ARM: 2.6.3[45] PCI regression (IXP4xx and PXA?)
Date: Tue, 10 Aug 2010 22:36:21 +0200	[thread overview]
Message-ID: <m3sk2m433u.fsf@intrepid.localdomain> (raw)

Hi,

Noticed this problem a bit late :-(

6fee48cd330c68332f9712bc968d934a1a84a32a broke
pci_set_consistent_dma_mask() on IXP4xx and most probably PXA. Affected
devices are e.g. IDE controller (CS5536-based: disk inaccessible) and
e1000 ethernet ("Detected Tx Unit Hang").

The attached patch makes it work again, though I'm not sure it's the
best solution.

Ideas?

Signed-off-by: Krzysztof Hałasa <khc@pm.waw.pl>

diff --git a/include/linux/dma-mapping.h b/include/linux/dma-mapping.h
index ca32ed7..bd2a7d3 100644
--- a/include/linux/dma-mapping.h
+++ b/include/linux/dma-mapping.h
@@ -129,6 +129,14 @@ static inline u64 dma_get_mask(struct device *dev)
 
 static inline int dma_set_coherent_mask(struct device *dev, u64 mask)
 {
+#ifdef CONFIG_DMABOUNCE
+	if (dev->archdata.dmabounce) {
+		if (mask >= ISA_DMA_THRESHOLD)
+			return 0;
+		else
+			return -EIO;
+	}
+#endif
 	if (!dma_supported(dev, mask))
 		return -EIO;
 	dev->coherent_dma_mask = mask;

             reply	other threads:[~2010-08-10 20:36 UTC|newest]

Thread overview: 51+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-10 20:36 Krzysztof Halasa [this message]
2010-08-10 20:36 ` ARM: 2.6.3[45] PCI regression (IXP4xx and PXA?) Krzysztof Halasa
2010-08-11  2:06 ` FUJITA Tomonori
2010-08-11  2:06   ` FUJITA Tomonori
2010-08-11  7:25   ` Russell King - ARM Linux
2010-08-11  7:25     ` Russell King - ARM Linux
2010-08-13  6:23     ` FUJITA Tomonori
2010-08-13  6:23       ` FUJITA Tomonori
2010-08-13 21:54       ` Russell King - ARM Linux
2010-08-13 21:54         ` Russell King - ARM Linux
2010-08-14  9:30         ` FUJITA Tomonori
2010-08-14  9:30           ` FUJITA Tomonori
2010-08-14 18:46           ` Russell King - ARM Linux
2010-08-14 18:46             ` Russell King - ARM Linux
2010-08-15  5:42             ` FUJITA Tomonori
2010-08-15  5:42               ` FUJITA Tomonori
2010-08-15  8:23               ` Russell King - ARM Linux
2010-08-15  8:23                 ` Russell King - ARM Linux
2010-08-15  8:23                 ` Russell King - ARM Linux
2010-08-15 15:55                 ` FUJITA Tomonori
2010-08-15 15:55                   ` FUJITA Tomonori
2010-08-16 23:29           ` Krzysztof Halasa
2010-08-16 23:29             ` Krzysztof Halasa
2010-08-19  8:51             ` FUJITA Tomonori
2010-08-19  8:51               ` FUJITA Tomonori
2010-08-19 16:56               ` Krzysztof Halasa
2010-08-19 16:56                 ` Krzysztof Halasa
2010-08-19 10:31           ` Benjamin Herrenschmidt
2010-08-19 10:31             ` Benjamin Herrenschmidt
2010-08-19 14:50             ` FUJITA Tomonori
2010-08-19 14:50               ` FUJITA Tomonori
2010-08-19 16:53               ` Krzysztof Halasa
2010-08-19 16:53                 ` Krzysztof Halasa
2010-08-19 17:20                 ` FUJITA Tomonori
2010-08-19 17:20                   ` FUJITA Tomonori
2010-08-19 21:54                   ` Benjamin Herrenschmidt
2010-08-19 21:54                     ` Benjamin Herrenschmidt
2010-08-19 21:51               ` Benjamin Herrenschmidt
2010-08-19 21:51                 ` Benjamin Herrenschmidt
2010-08-26 11:55                 ` FUJITA Tomonori
2010-08-26 11:55                   ` FUJITA Tomonori
2010-08-26 13:54                   ` FUJITA Tomonori
2010-08-26 13:54                     ` FUJITA Tomonori
2010-08-26 17:57                     ` Russell King - ARM Linux
2010-08-26 17:57                       ` Russell King - ARM Linux
2010-08-27  6:54                       ` FUJITA Tomonori
2010-08-27  6:54                         ` FUJITA Tomonori
2010-08-26 16:02                   ` Krzysztof Halasa
2010-08-26 16:02                     ` Krzysztof Halasa
2010-08-27  0:26                     ` FUJITA Tomonori
2010-08-27  0:26                       ` FUJITA Tomonori

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m3sk2m433u.fsf@intrepid.localdomain \
    --to=khc@pm.waw.pl \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.