From: Markus Armbruster <armbru@redhat.com>
To: Paul Brook <paul@codesourcery.com>
Cc: Anthony Liguori <aliguori@us.ibm.com>,
Juan Quintela <quintela@redhat.com>,
Jan Kiszka <jan.kiszka@siemens.com>,
qemu-devel@nongnu.org, Luiz Capitulino <lcapitulino@redhat.com>,
Blue Swirl <blauwirbel@gmail.com>, Jan Kiszka <jan.kiszka@web.de>,
Gerd Hoffmann <kraxel@redhat.com>, Avi Kivity <avi@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] qdev: Reject duplicate and anti-social device IDs
Date: Tue, 08 Jun 2010 14:06:04 +0200 [thread overview]
Message-ID: <m3typdg24z.fsf@blackfin.pond.sub.org> (raw)
In-Reply-To: <201006041628.30920.paul@codesourcery.com> (Paul Brook's message of "Fri, 4 Jun 2010 16:28:29 +0100")
Paul Brook <paul@codesourcery.com> writes:
>> Paul Brook <paul@codesourcery.com> writes:
>> >> Also require IDs to start with a letter to provide for possible future
>> >> extensions.
>> >
>> > I'd go further than that, and require that user specified IDs match
>> > [A-Za-z][A-Za-z0-9_-]*
>>
>> I talked with Dan (cc'ed) to make sure we don't trample on existing
>> libvirt usage without need. What about
>>
>> [A-Za-z][A-Za-z0-9_-:.]*
>>
>> i.e. your regexp plus ':' and '.' in the second bracket?
>
> I was deliberately avoiding those as they're often used as separators - we
> already use ':' in other contexts so there's potential ambiguity and
> parsing/quoting issues. I'm not aware of any current issues with '.'.
I checked with Dan, and we can outlaw ':'. I just posted a new patch
that covers all qemu-option IDs, not just qdev.
[...]
next prev parent reply other threads:[~2010-06-08 12:06 UTC|newest]
Thread overview: 59+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-23 10:59 [Qemu-devel] [PATCH v3 00/17] Basic device state visualization Jan Kiszka
2010-05-23 10:59 ` [Qemu-devel] [PATCH v3 01/17] Add dependency of JSON unit tests on config-host.h Jan Kiszka
2010-05-23 10:59 ` [Qemu-devel] [PATCH v3 02/17] qdev: Fix scanning across single-bus devices Jan Kiszka
2010-06-03 5:58 ` Paul Brook
2010-06-03 6:12 ` Jan Kiszka
2010-05-23 10:59 ` [Qemu-devel] [PATCH v3 03/17] qdev: Allow device addressing via 'driver.instance' Jan Kiszka
2010-05-23 10:59 ` [Qemu-devel] [PATCH v3 04/17] qdev: Give qtree names precedence over user-assigned IDs Jan Kiszka
2010-05-29 8:01 ` Markus Armbruster
2010-05-30 8:16 ` Avi Kivity
2010-05-31 8:26 ` Markus Armbruster
2010-05-31 9:59 ` Gerd Hoffmann
2010-05-31 11:12 ` Markus Armbruster
2010-05-31 14:13 ` [Qemu-devel] [PATCH] qdev: Reject duplicate and anti-social device IDs Markus Armbruster
2010-05-31 18:55 ` [Qemu-devel] " Gerd Hoffmann
2010-06-01 13:04 ` Luiz Capitulino
2010-06-01 13:09 ` Jan Kiszka
2010-06-01 13:13 ` Luiz Capitulino
2010-06-01 13:19 ` Jan Kiszka
2010-06-01 13:21 ` Avi Kivity
2010-06-01 13:23 ` Luiz Capitulino
2010-06-01 14:44 ` Markus Armbruster
2010-06-01 14:49 ` Luiz Capitulino
2010-06-01 18:35 ` Markus Armbruster
2010-06-01 18:54 ` Anthony Liguori
2010-06-03 6:26 ` Jan Kiszka
2010-06-03 6:51 ` [Qemu-devel] " Paul Brook
2010-06-04 14:27 ` Markus Armbruster
2010-06-04 15:28 ` Paul Brook
2010-06-08 12:06 ` Markus Armbruster [this message]
2010-05-23 10:59 ` [Qemu-devel] [PATCH v3 05/17] qdev: Convert device and bus lists to QTAILQ Jan Kiszka
2010-05-23 10:59 ` [Qemu-devel] [PATCH v3 06/17] qdev: Allow device specification by qtree path for device_del Jan Kiszka
2010-05-27 19:36 ` [Qemu-devel] " Luiz Capitulino
2010-05-27 22:19 ` Jan Kiszka
2010-05-28 13:43 ` Luiz Capitulino
2010-05-28 14:16 ` Jan Kiszka
2010-05-28 14:40 ` Markus Armbruster
2010-05-28 14:56 ` Jan Kiszka
2010-05-29 8:05 ` Markus Armbruster
2010-05-29 8:16 ` Jan Kiszka
2010-05-23 10:59 ` [Qemu-devel] [PATCH v3 07/17] qdev: Push QMP mode checks into qbus_list_bus/dev Jan Kiszka
2010-05-23 10:59 ` [Qemu-devel] [PATCH v3 08/17] monitor: Add completion for qdev paths Jan Kiszka
2010-05-23 10:59 ` [Qemu-devel] [PATCH v3 09/17] Add base64 encoder/decoder Jan Kiszka
2010-05-23 10:59 ` [Qemu-devel] [PATCH v3 10/17] QMP: Reserve namespace for complex object classes Jan Kiszka
2010-05-27 20:08 ` [Qemu-devel] " Luiz Capitulino
2010-05-27 22:20 ` Jan Kiszka
2010-05-23 10:59 ` [Qemu-devel] [PATCH v3 11/17] Add QBuffer Jan Kiszka
2010-05-23 10:59 ` [Qemu-devel] [PATCH v3 12/17] monitor: return length of printed string via monitor_[v]printf Jan Kiszka
2010-05-29 8:09 ` Markus Armbruster
2010-05-23 10:59 ` [Qemu-devel] [PATCH v3 13/17] monitor: Allow to exclude commands from QMP Jan Kiszka
2010-05-27 20:31 ` [Qemu-devel] " Luiz Capitulino
2010-05-27 22:20 ` Jan Kiszka
2010-05-28 13:45 ` Luiz Capitulino
2010-05-29 8:15 ` Markus Armbruster
2010-05-29 8:33 ` Jan Kiszka
2010-05-23 10:59 ` [Qemu-devel] [PATCH v3 14/17] monitor: Add basic device state visualization Jan Kiszka
2010-05-23 10:59 ` [Qemu-devel] [PATCH v3 15/17] QMP: Teach basic capability negotiation to python example Jan Kiszka
2010-05-23 10:59 ` [Qemu-devel] [PATCH v3 16/17] QMP: Fix python helper /wrt long return strings Jan Kiszka
2010-05-27 20:35 ` [Qemu-devel] " Luiz Capitulino
2010-05-23 10:59 ` [Qemu-devel] [PATCH v3 17/17] QMP: Add support for buffer class to qmp python helper Jan Kiszka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3typdg24z.fsf@blackfin.pond.sub.org \
--to=armbru@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=avi@redhat.com \
--cc=blauwirbel@gmail.com \
--cc=jan.kiszka@siemens.com \
--cc=jan.kiszka@web.de \
--cc=kraxel@redhat.com \
--cc=lcapitulino@redhat.com \
--cc=paul@codesourcery.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.