From: Markus Armbruster <armbru@redhat.com>
To: Kevin Wolf <kwolf@redhat.com>
Cc: qemu-devel@nongnu.org, kraxel@redhat.com
Subject: Re: [Qemu-devel] [PATCH] Fix QEMU_WARN_UNUSED_RESULT
Date: Fri, 15 Jan 2010 17:45:25 +0100 [thread overview]
Message-ID: <m3tyungvve.fsf@blackfin.pond.sub.org> (raw)
In-Reply-To: <1263556601-15351-1-git-send-email-kwolf@redhat.com> (Kevin Wolf's message of "Fri, 15 Jan 2010 12:56:41 +0100")
Kevin Wolf <kwolf@redhat.com> writes:
> Since commit 747bbdf7 QEMU_WARN_UNUSED_RESULT is never defined as it is
> conditional on a define from config-host.h which is included only later.
> Include that file earlier to get the warnings back.
>
> Reactivating it unfortunately leads to some warnings about unused qdev_init
> results. These calls are changed to qdev_init_nofail to avoid build failures.
>
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
The use of qdev_init_nofail() is correct, because the relevant device
init methods can't fail.
Acked-by: Markus Armbruster <armbru@redhat.com>
next prev parent reply other threads:[~2010-01-15 16:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-15 11:56 [Qemu-devel] [PATCH] Fix QEMU_WARN_UNUSED_RESULT Kevin Wolf
2010-01-15 16:45 ` Markus Armbruster [this message]
2010-01-19 22:40 ` Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3tyungvve.fsf@blackfin.pond.sub.org \
--to=armbru@redhat.com \
--cc=kraxel@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.