All of lore.kernel.org
 help / color / mirror / Atom feed
From: khalasa@piap.pl (Krzysztof Hałasa)
To: Arnd Bergmann <arnd@arndb.de>
Cc: linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org,
	Bjorn Helgaas <bhelgaas@google.com>
Subject: Re: [PATCH v2] ARM: cns3xxx: pci: avoid potential stack overflow
Date: Thu, 08 Oct 2015 12:03:18 +0200	[thread overview]
Message-ID: <m3vbahy8wp.fsf@t19.piap.pl> (raw)
In-Reply-To: <12713701.B4epxIQJNF@wuerfel> (Arnd Bergmann's message of "Wed, 07 Oct 2015 22:05:49 +0200")

Hi,

Arnd Bergmann <arnd@arndb.de> writes:

> With those two changes in place, we no longer need the fake
> pci_sys_data/pci_bus structures for faking config space writes,
> and the stack usage goes down as well.

>  arch/arm/mach-cns3xxx/pcie.c | 71 +++++++++++++++++++++++++++++----------------------------------------

I'm ATM unable to test this change, but will do that at some point.
Meanwhile, I guess there is nothing I can say against this patch.
Thanks.

Acked-by: Krzysztof Hałasa <khalasa@piap.pl>
-- 
Krzysztof Halasa

Industrial Research Institute for Automation and Measurements PIAP
Al. Jerozolimskie 202, 02-486 Warsaw, Poland

WARNING: multiple messages have this Message-ID (diff)
From: khalasa@piap.pl (Krzysztof Hałasa)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] ARM: cns3xxx: pci: avoid potential stack overflow
Date: Thu, 08 Oct 2015 12:03:18 +0200	[thread overview]
Message-ID: <m3vbahy8wp.fsf@t19.piap.pl> (raw)
In-Reply-To: <12713701.B4epxIQJNF@wuerfel> (Arnd Bergmann's message of "Wed, 07 Oct 2015 22:05:49 +0200")

Hi,

Arnd Bergmann <arnd@arndb.de> writes:

> With those two changes in place, we no longer need the fake
> pci_sys_data/pci_bus structures for faking config space writes,
> and the stack usage goes down as well.

>  arch/arm/mach-cns3xxx/pcie.c | 71 +++++++++++++++++++++++++++++----------------------------------------

I'm ATM unable to test this change, but will do that at some point.
Meanwhile, I guess there is nothing I can say against this patch.
Thanks.

Acked-by: Krzysztof Ha?asa <khalasa@piap.pl>
-- 
Krzysztof Halasa

Industrial Research Institute for Automation and Measurements PIAP
Al. Jerozolimskie 202, 02-486 Warsaw, Poland

  reply	other threads:[~2015-10-08 10:03 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-19 15:14 [PATCH] ARM: cns3xxx: pci: avoid potential stack overflow Arnd Bergmann
2015-05-19 15:14 ` Arnd Bergmann
2015-05-27  6:45 ` Krzysztof Hałasa
2015-05-27  6:45   ` Krzysztof Hałasa
2015-10-07 20:01   ` Arnd Bergmann
2015-10-07 20:01     ` Arnd Bergmann
2015-10-07 20:05     ` [PATCH v2] " Arnd Bergmann
2015-10-07 20:05       ` Arnd Bergmann
2015-10-08 10:03       ` Krzysztof Hałasa [this message]
2015-10-08 10:03         ` Krzysztof Hałasa
2015-10-08 14:38         ` Arnd Bergmann
2015-10-08 14:38           ` Arnd Bergmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m3vbahy8wp.fsf@t19.piap.pl \
    --to=khalasa@piap.pl \
    --cc=arnd@arndb.de \
    --cc=bhelgaas@google.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.