All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rui Miguel Silva <rui.silva@linaro.org>
To: Rob Herring <robh@kernel.org>
Cc: Rui Miguel Silva <rui.silva@linaro.org>,
	mchehab@kernel.org, sakari.ailus@linux.intel.com,
	Steve Longerbeam <slongerbeam@gmail.com>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	linux-media@vger.kernel.org, devel@driverdev.osuosl.org,
	Shawn Guo <shawnguo@kernel.org>,
	Fabio Estevam <fabio.estevam@nxp.com>,
	devicetree@vger.kernel.org,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Ryan Harkin <ryan.harkin@linaro.org>,
	linux-clk@vger.kernel.org
Subject: Re: [PATCH v5 07/12] ARM: dts: imx7s: add mipi phy power domain
Date: Fri, 18 May 2018 22:54:17 +0100	[thread overview]
Message-ID: <m3y3ggd3zq.fsf@linaro.org> (raw)
In-Reply-To: <20180518165022.GB21131@rob-hp-laptop>

Hi Rob,
On Fri 18 May 2018 at 16:50, Rob Herring wrote:
> On Fri, May 18, 2018 at 10:28:01AM +0100, Rui Miguel Silva 
> wrote:
>> Add power domain index 0 related with mipi-phy to imx7s.
>> 
>> Signed-off-by: Rui Miguel Silva <rui.silva@linaro.org>
>> ---
>>  arch/arm/boot/dts/imx7s.dtsi | 6 ++++++
>>  1 file changed, 6 insertions(+)
>> 
>> diff --git a/arch/arm/boot/dts/imx7s.dtsi 
>> b/arch/arm/boot/dts/imx7s.dtsi
>> index 4d42335c0dee..67450ad89940 100644
>> --- a/arch/arm/boot/dts/imx7s.dtsi
>> +++ b/arch/arm/boot/dts/imx7s.dtsi
>> @@ -636,6 +636,12 @@
>>  					#address-cells = <1>;
>>  					#size-cells = <0>;
>>  
>> +					pgc_mipi_phy: 
>> pgc-power-domain@0 {
>
> power-domain@0

I can change it, but...
>
>> + 
>> #power-domain-cells = <0>;
>> +						reg = <0>;
>> +						power-supply = 
>> <&reg_1p0d>;
>> +					};
>> +
>>  					pgc_pcie_phy: 
>>  pgc-power-domain@1 {
>
> ditto.

This was not introduced by my patch, it is already there and I was
trying to be coherent with the existing naming.
but let me know if you like me to change it also.

---
Cheers,
	Rui


WARNING: multiple messages have this Message-ID (diff)
From: Rui Miguel Silva <rui.silva@linaro.org>
To: Rob Herring <robh@kernel.org>
Cc: devel@driverdev.osuosl.org, devicetree@vger.kernel.org,
	sakari.ailus@linux.intel.com,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Ryan Harkin <ryan.harkin@linaro.org>,
	Rui Miguel Silva <rui.silva@linaro.org>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	Steve Longerbeam <slongerbeam@gmail.com>,
	Fabio Estevam <fabio.estevam@nxp.com>,
	mchehab@kernel.org, Shawn Guo <shawnguo@kernel.org>,
	linux-clk@vger.kernel.org, linux-media@vger.kernel.org
Subject: Re: [PATCH v5 07/12] ARM: dts: imx7s: add mipi phy power domain
Date: Fri, 18 May 2018 22:54:17 +0100	[thread overview]
Message-ID: <m3y3ggd3zq.fsf@linaro.org> (raw)
In-Reply-To: <20180518165022.GB21131@rob-hp-laptop>

Hi Rob,
On Fri 18 May 2018 at 16:50, Rob Herring wrote:
> On Fri, May 18, 2018 at 10:28:01AM +0100, Rui Miguel Silva 
> wrote:
>> Add power domain index 0 related with mipi-phy to imx7s.
>> 
>> Signed-off-by: Rui Miguel Silva <rui.silva@linaro.org>
>> ---
>>  arch/arm/boot/dts/imx7s.dtsi | 6 ++++++
>>  1 file changed, 6 insertions(+)
>> 
>> diff --git a/arch/arm/boot/dts/imx7s.dtsi 
>> b/arch/arm/boot/dts/imx7s.dtsi
>> index 4d42335c0dee..67450ad89940 100644
>> --- a/arch/arm/boot/dts/imx7s.dtsi
>> +++ b/arch/arm/boot/dts/imx7s.dtsi
>> @@ -636,6 +636,12 @@
>>  					#address-cells = <1>;
>>  					#size-cells = <0>;
>>  
>> +					pgc_mipi_phy: 
>> pgc-power-domain@0 {
>
> power-domain@0

I can change it, but...
>
>> + 
>> #power-domain-cells = <0>;
>> +						reg = <0>;
>> +						power-supply = 
>> <&reg_1p0d>;
>> +					};
>> +
>>  					pgc_pcie_phy: 
>>  pgc-power-domain@1 {
>
> ditto.

This was not introduced by my patch, it is already there and I was
trying to be coherent with the existing naming.
but let me know if you like me to change it also.

---
Cheers,
	Rui

  reply	other threads:[~2018-05-18 21:54 UTC|newest]

Thread overview: 48+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-18  9:27 [PATCH v5 00/12] media: staging/imx7: add i.MX7 media driver Rui Miguel Silva
2018-05-18  9:27 ` Rui Miguel Silva
2018-05-18  9:27 ` [PATCH v5 01/12] media: staging/imx: refactor imx media device probe Rui Miguel Silva
2018-05-18  9:27   ` Rui Miguel Silva
2018-05-18 10:32   ` Philipp Zabel
2018-05-18 10:32     ` Philipp Zabel
2018-05-18 14:18     ` Rui Miguel Silva
2018-05-18 14:18       ` Rui Miguel Silva
2018-05-18  9:27 ` [PATCH v5 02/12] media: staging/imx7: add imx7 CSI subdev driver Rui Miguel Silva
2018-05-18  9:27   ` Rui Miguel Silva
2018-05-18 10:33   ` Philipp Zabel
2018-05-18 10:33     ` Philipp Zabel
2018-05-18  9:27 ` [PATCH v5 03/12] clk: imx7d: fix mipi dphy div parent Rui Miguel Silva
2018-05-18  9:27   ` Rui Miguel Silva
2018-05-18  9:27 ` [PATCH v5 04/12] clk: imx7d: reset parent for mipi csi root Rui Miguel Silva
2018-05-18  9:27   ` Rui Miguel Silva
2018-05-18  9:27 ` [PATCH v5 05/12] media: staging/imx7: add MIPI CSI-2 receiver subdev for i.MX7 Rui Miguel Silva
2018-05-18  9:27   ` Rui Miguel Silva
2018-05-18  9:28 ` [PATCH v5 06/12] media: dt-bindings: add bindings for i.MX7 media driver Rui Miguel Silva
2018-05-18  9:28   ` Rui Miguel Silva
2018-05-18 16:08   ` Philipp Zabel
2018-05-18 16:08     ` Philipp Zabel
2018-05-18 16:49   ` Rob Herring
2018-05-18 16:49     ` Rob Herring
2018-05-18 21:52     ` Rui Miguel Silva
2018-05-18 21:52       ` Rui Miguel Silva
2018-05-18 22:05   ` Sakari Ailus
2018-05-18 22:05     ` Sakari Ailus
2018-05-18  9:28 ` [PATCH v5 07/12] ARM: dts: imx7s: add mipi phy power domain Rui Miguel Silva
2018-05-18  9:28   ` Rui Miguel Silva
2018-05-18 16:50   ` Rob Herring
2018-05-18 16:50     ` Rob Herring
2018-05-18 21:54     ` Rui Miguel Silva [this message]
2018-05-18 21:54       ` Rui Miguel Silva
2018-05-18  9:28 ` [PATCH v5 08/12] ARM: dts: imx7s: add multiplexer controls Rui Miguel Silva
2018-05-18  9:28   ` Rui Miguel Silva
2018-05-18 16:51   ` Rob Herring
2018-05-18 16:51     ` Rob Herring
2018-05-18 21:54     ` Rui Miguel Silva
2018-05-18 21:54       ` Rui Miguel Silva
2018-05-18  9:28 ` [PATCH v5 09/12] ARM: dts: imx7: Add video mux, csi and mipi_csi and connections Rui Miguel Silva
2018-05-18  9:28   ` Rui Miguel Silva
2018-05-18  9:28 ` [PATCH v5 10/12] ARM: dts: imx7s-warp: add ov2680 sensor node Rui Miguel Silva
2018-05-18  9:28   ` Rui Miguel Silva
2018-05-18  9:28 ` [PATCH v5 11/12] media: imx7.rst: add documentation for i.MX7 media driver Rui Miguel Silva
2018-05-18  9:28   ` Rui Miguel Silva
2018-05-18  9:28 ` [PATCH v5 12/12] media: staging/imx: add i.MX7 entries to TODO file Rui Miguel Silva
2018-05-18  9:28   ` Rui Miguel Silva

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m3y3ggd3zq.fsf@linaro.org \
    --to=rui.silva@linaro.org \
    --cc=devel@driverdev.osuosl.org \
    --cc=devicetree@vger.kernel.org \
    --cc=fabio.estevam@nxp.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=p.zabel@pengutronix.de \
    --cc=robh@kernel.org \
    --cc=ryan.harkin@linaro.org \
    --cc=sakari.ailus@linux.intel.com \
    --cc=shawnguo@kernel.org \
    --cc=slongerbeam@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.