From: Nikola Pajkovsky <n.pajkovsky@gmail.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Gary Zambrano <zambrano@broadcom.com>,
netdev@vger.kernel.org, kernel-janitors@vger.kernel.org,
Nikola Pajkovsky <n.pajkovsky@gmail.com>
Subject: Re: [PATCH] b44: fix section mismatch warnings in b44.c
Date: Sun, 19 Feb 2012 20:28:02 +0000 [thread overview]
Message-ID: <m5sji6zhyl.fsf@redhat.com> (raw)
In-Reply-To: <20120219201332.GF2855@mwanda> (Dan Carpenter's message of "Sun, 19 Feb 2012 23:13:32 +0300")
Dan Carpenter <dan.carpenter@oracle.com> writes:
> On Sun, Feb 19, 2012 at 03:45:54PM +0100, Nikola Pajkovsky wrote:
>> From: Nikola Pajkovsky <n.pajkovsky@gmail.com>
>>
>
> This changelog is not really helpful.
>
> Why did you remove an __exit anotation instead changing the callers?
> Obviously I looked at the code, so I can answer that question, but I
> shouldn't have to. It should be explained in the changelog.
I will rephrase comment
> Sometimes I add in information about when the error message was
> introduced.
>
> It might also be nice to mention what the bad effects of this
> problem are.
>
>> Signed-off-by: Nikola Pajkovsky <n.pajkovsky@gmail.com>
> ^^^^^^^^^^^^^^^^^^^^^
> You're sending the patch from your redhat address; it's best to sign
> it with the redhat address as well.
oops, it should be from gmail
--
Nikola
WARNING: multiple messages have this Message-ID (diff)
From: Nikola Pajkovsky <n.pajkovsky@gmail.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Gary Zambrano <zambrano@broadcom.com>,
netdev@vger.kernel.org, kernel-janitors@vger.kernel.org,
Nikola Pajkovsky <n.pajkovsky@gmail.com>
Subject: Re: [PATCH] b44: fix section mismatch warnings in b44.c
Date: Sun, 19 Feb 2012 21:28:02 +0100 [thread overview]
Message-ID: <m5sji6zhyl.fsf@redhat.com> (raw)
In-Reply-To: <20120219201332.GF2855@mwanda> (Dan Carpenter's message of "Sun, 19 Feb 2012 23:13:32 +0300")
Dan Carpenter <dan.carpenter@oracle.com> writes:
> On Sun, Feb 19, 2012 at 03:45:54PM +0100, Nikola Pajkovsky wrote:
>> From: Nikola Pajkovsky <n.pajkovsky@gmail.com>
>>
>
> This changelog is not really helpful.
>
> Why did you remove an __exit anotation instead changing the callers?
> Obviously I looked at the code, so I can answer that question, but I
> shouldn't have to. It should be explained in the changelog.
I will rephrase comment
> Sometimes I add in information about when the error message was
> introduced.
>
> It might also be nice to mention what the bad effects of this
> problem are.
>
>> Signed-off-by: Nikola Pajkovsky <n.pajkovsky@gmail.com>
> ^^^^^^^^^^^^^^^^^^^^^
> You're sending the patch from your redhat address; it's best to sign
> it with the redhat address as well.
oops, it should be from gmail
--
Nikola
next prev parent reply other threads:[~2012-02-19 20:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-19 14:45 [PATCH] b44: fix section mismatch warnings in b44.c Nikola Pajkovsky
2012-02-19 14:45 ` Nikola Pajkovsky
2012-02-19 20:13 ` Dan Carpenter
2012-02-19 20:13 ` Dan Carpenter
2012-02-19 20:28 ` Nikola Pajkovsky [this message]
2012-02-19 20:28 ` Nikola Pajkovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m5sji6zhyl.fsf@redhat.com \
--to=n.pajkovsky@gmail.com \
--cc=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=zambrano@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.