All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pratyush Yadav <pratyush@kernel.org>
To: Santhosh Kumar K <s-k6@ti.com>
Cc: <miquel.raynal@bootlin.com>,  <richard@nod.at>,
	 <vigneshr@ti.com>, <tudor.ambarus@linaro.org>,
	 <pratyush@kernel.org>,  <mwalle@kernel.org>,
	<linux-mtd@lists.infradead.org>,  <linux-kernel@vger.kernel.org>,
	<praneeth@ti.com>,  <p-mantena@ti.com>,  <a-dutta@ti.com>,
	<u-kumar1@ti.com>
Subject: Re: [PATCH] mtd: spi-nor: spansion: Modify addr_mode_nbytes for DTR mode
Date: Thu, 04 Sep 2025 16:28:17 +0200	[thread overview]
Message-ID: <mafs03492uwam.fsf@kernel.org> (raw)
In-Reply-To: <20250904131309.3095165-1-s-k6@ti.com>

On Thu, Sep 04 2025, Santhosh Kumar K wrote:

> The nor->params->addr_mode_nbytes parameter defines the address byte
> count for the current addressing mode. When transitioning between SDR
> and DDR modes, this parameter must be properly updated to maintain the
> correct addressing behavior. So, implement the necessary updates to
> nor->params->addr_mode_nbytes during both DDR mode enablement and
> disablement operations to ensure address byte counts remain consistent
> with the active transfer mode.

Doesn't spi_nor_set_4byte_addr_mode() do this already? What is the
difference here? Are we missing a call to it after
spi_nor_set_octal_dtr() in some path?

Also, do you see a real bug with this or is this purely theoretical?

[...]

-- 
Regards,
Pratyush Yadav

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

WARNING: multiple messages have this Message-ID (diff)
From: Pratyush Yadav <pratyush@kernel.org>
To: Santhosh Kumar K <s-k6@ti.com>
Cc: <miquel.raynal@bootlin.com>,  <richard@nod.at>,
	 <vigneshr@ti.com>, <tudor.ambarus@linaro.org>,
	 <pratyush@kernel.org>,  <mwalle@kernel.org>,
	<linux-mtd@lists.infradead.org>,  <linux-kernel@vger.kernel.org>,
	<praneeth@ti.com>,  <p-mantena@ti.com>,  <a-dutta@ti.com>,
	<u-kumar1@ti.com>
Subject: Re: [PATCH] mtd: spi-nor: spansion: Modify addr_mode_nbytes for DTR mode
Date: Thu, 04 Sep 2025 16:28:17 +0200	[thread overview]
Message-ID: <mafs03492uwam.fsf@kernel.org> (raw)
In-Reply-To: <20250904131309.3095165-1-s-k6@ti.com>

On Thu, Sep 04 2025, Santhosh Kumar K wrote:

> The nor->params->addr_mode_nbytes parameter defines the address byte
> count for the current addressing mode. When transitioning between SDR
> and DDR modes, this parameter must be properly updated to maintain the
> correct addressing behavior. So, implement the necessary updates to
> nor->params->addr_mode_nbytes during both DDR mode enablement and
> disablement operations to ensure address byte counts remain consistent
> with the active transfer mode.

Doesn't spi_nor_set_4byte_addr_mode() do this already? What is the
difference here? Are we missing a call to it after
spi_nor_set_octal_dtr() in some path?

Also, do you see a real bug with this or is this purely theoretical?

[...]

-- 
Regards,
Pratyush Yadav

  parent reply	other threads:[~2025-09-04 19:51 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-04 13:13 [PATCH] mtd: spi-nor: spansion: Modify addr_mode_nbytes for DTR mode Santhosh Kumar K
2025-09-04 13:13 ` Santhosh Kumar K
2025-09-04 13:35 ` Tudor Ambarus
2025-09-04 13:35   ` Tudor Ambarus
2025-09-04 14:28 ` Pratyush Yadav [this message]
2025-09-04 14:28   ` Pratyush Yadav
2025-09-08  9:28 ` Takahiro Kuwano
2025-09-08  9:28   ` Takahiro Kuwano
2025-09-15  7:41 ` Santhosh Kumar K
2025-09-15  7:41   ` Santhosh Kumar K

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=mafs03492uwam.fsf@kernel.org \
    --to=pratyush@kernel.org \
    --cc=a-dutta@ti.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=miquel.raynal@bootlin.com \
    --cc=mwalle@kernel.org \
    --cc=p-mantena@ti.com \
    --cc=praneeth@ti.com \
    --cc=richard@nod.at \
    --cc=s-k6@ti.com \
    --cc=tudor.ambarus@linaro.org \
    --cc=u-kumar1@ti.com \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.