All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pratyush Yadav <pratyush@kernel.org>
To: Tudor Ambarus <tudor.ambarus@linaro.org>
Cc: pratyush@kernel.org,  michael@walle.cc,
	 miquel.raynal@bootlin.com, richard@nod.at,
	 jaimeliao@mxic.com.tw,  linux-mtd@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/4] mtd: spi-nor: print flash ID instead of name
Date: Mon, 29 Jan 2024 14:12:43 +0100	[thread overview]
Message-ID: <mafs0bk94th9w.fsf@kernel.org> (raw)
In-Reply-To: <20231215082138.16063-2-tudor.ambarus@linaro.org> (Tudor Ambarus's message of "Fri, 15 Dec 2023 10:21:35 +0200")

On Fri, Dec 15 2023, Tudor Ambarus wrote:

> We saw flash ID collisions which make the flash name unreliable. Print
> the manufacgturer and device ID instead of the flash name.

Typo. s/manufacgturer/manufacturer/

>
> Lower the print to dev_dbg to stop polluting the kernel log.

FWIW, I find these prints to be somewhat useful. they serve to
"announce" that the kernel probed a device successfully. This can be
somewhat helpful when reading logs from customers trying to figure out
why something doesn't work.

I don't have any strong opinions of course since it is not such a big
deal but I wanted to point out that these prints _are_ somewhat useful.

Acked-by: Pratyush Yadav <pratyush@kernel.org>

> Suggested-by: Miquel Raynal <miquel.raynal@bootlin.com>
> Signed-off-by: Tudor Ambarus <tudor.ambarus@linaro.org>

-- 
Regards,
Pratyush Yadav

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

WARNING: multiple messages have this Message-ID (diff)
From: Pratyush Yadav <pratyush@kernel.org>
To: Tudor Ambarus <tudor.ambarus@linaro.org>
Cc: pratyush@kernel.org,  michael@walle.cc,
	 miquel.raynal@bootlin.com, richard@nod.at,
	 jaimeliao@mxic.com.tw,  linux-mtd@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/4] mtd: spi-nor: print flash ID instead of name
Date: Mon, 29 Jan 2024 14:12:43 +0100	[thread overview]
Message-ID: <mafs0bk94th9w.fsf@kernel.org> (raw)
In-Reply-To: <20231215082138.16063-2-tudor.ambarus@linaro.org> (Tudor Ambarus's message of "Fri, 15 Dec 2023 10:21:35 +0200")

On Fri, Dec 15 2023, Tudor Ambarus wrote:

> We saw flash ID collisions which make the flash name unreliable. Print
> the manufacgturer and device ID instead of the flash name.

Typo. s/manufacgturer/manufacturer/

>
> Lower the print to dev_dbg to stop polluting the kernel log.

FWIW, I find these prints to be somewhat useful. they serve to
"announce" that the kernel probed a device successfully. This can be
somewhat helpful when reading logs from customers trying to figure out
why something doesn't work.

I don't have any strong opinions of course since it is not such a big
deal but I wanted to point out that these prints _are_ somewhat useful.

Acked-by: Pratyush Yadav <pratyush@kernel.org>

> Suggested-by: Miquel Raynal <miquel.raynal@bootlin.com>
> Signed-off-by: Tudor Ambarus <tudor.ambarus@linaro.org>

-- 
Regards,
Pratyush Yadav

  parent reply	other threads:[~2024-01-29 13:12 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-15  8:21 [PATCH 0/4] mtd: spi-nor: mark the flash name as obsolete Tudor Ambarus
2023-12-15  8:21 ` Tudor Ambarus
2023-12-15  8:21 ` [PATCH 1/4] mtd: spi-nor: print flash ID instead of name Tudor Ambarus
2023-12-15  8:21   ` Tudor Ambarus
2023-12-18 12:07   ` Michael Walle
2023-12-18 12:07     ` Michael Walle
2024-01-29 13:12   ` Pratyush Yadav [this message]
2024-01-29 13:12     ` Pratyush Yadav
2023-12-15  8:21 ` [PATCH 2/4] mtd: spi-nor: mark the flash name as obsolete Tudor Ambarus
2023-12-15  8:21   ` Tudor Ambarus
2023-12-18 12:08   ` Michael Walle
2023-12-18 12:08     ` Michael Walle
2024-01-29 13:13   ` Pratyush Yadav
2024-01-29 13:13     ` Pratyush Yadav
2023-12-15  8:21 ` [PATCH 3/4] mtd: spi-nor: sysfs: hide the flash name if not set Tudor Ambarus
2023-12-15  8:21   ` Tudor Ambarus
2023-12-18 12:11   ` Michael Walle
2023-12-18 12:11     ` Michael Walle
2024-01-29 13:24   ` Pratyush Yadav
2024-01-29 13:24     ` Pratyush Yadav
2023-12-15  8:21 ` [PATCH 4/4] mtd: spi-nor: drop superfluous debug prints Tudor Ambarus
2023-12-15  8:21   ` Tudor Ambarus
2023-12-15  8:24   ` Tudor Ambarus
2023-12-15  8:24     ` Tudor Ambarus
2024-01-29 13:26     ` Pratyush Yadav
2024-01-29 13:26       ` Pratyush Yadav
2024-01-29 13:27       ` Tudor Ambarus
2024-01-29 13:27         ` Tudor Ambarus
2024-01-29 13:34         ` Pratyush Yadav
2024-01-29 13:34           ` Pratyush Yadav
2023-12-18 12:14   ` Michael Walle
2023-12-18 12:14     ` Michael Walle
2023-12-19  2:47 ` [PATCH 0/4] mtd: spi-nor: mark the flash name as obsolete Tudor Ambarus
2023-12-19  2:47   ` Tudor Ambarus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=mafs0bk94th9w.fsf@kernel.org \
    --to=pratyush@kernel.org \
    --cc=jaimeliao@mxic.com.tw \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=michael@walle.cc \
    --cc=miquel.raynal@bootlin.com \
    --cc=richard@nod.at \
    --cc=tudor.ambarus@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.