All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pratyush Yadav <pratyush@kernel.org>
To: Flaviu Nistor <flaviu.nistor@gmail.com>
Cc: Tudor Ambarus <tudor.ambarus@linaro.org>,
	 Pratyush Yadav <pratyush@kernel.org>,
	 Michael Walle <mwalle@kernel.org>,
	 Miquel Raynal <miquel.raynal@bootlin.com>,
	 Richard Weinberger <richard@nod.at>,
	Vignesh Raghavendra <vigneshr@ti.com>,
	 linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mtd: spi-nor: issi: Add support for is25wx01g
Date: Mon, 01 Sep 2025 19:13:12 +0200	[thread overview]
Message-ID: <mafs0cy8aw0yf.fsf@kernel.org> (raw)
In-Reply-To: <20250901164218.11165-1-flaviu.nistor@gmail.com>

Hi Flaviu,

On Mon, Sep 01 2025, Flaviu Nistor wrote:

> Add support for the IS25WX01G 128MB (1Gb) ISSI Serial Flash Memory.
>
> Signed-off-by: Flaviu Nistor <flaviu.nistor@gmail.com>
> ---
>  drivers/mtd/spi-nor/issi.c | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/drivers/mtd/spi-nor/issi.c b/drivers/mtd/spi-nor/issi.c
> index 18d9a00aa22e..e4997f9bd557 100644
> --- a/drivers/mtd/spi-nor/issi.c
> +++ b/drivers/mtd/spi-nor/issi.c
> @@ -126,6 +126,9 @@ static const struct flash_info issi_nor_parts[] = {
>  		.flags = SPI_NOR_QUAD_PP,
>  		.fixups = &is25lp256_fixups,
>  		.fixup_flags = SPI_NOR_4B_OPCODES,
> +	}, {
> +		/* IS25WX01G */
> +		.id = SNOR_ID(0x9d, 0x5b, 0x1b),

It seems the flash needs no special configuration. IIUC it can be driven
entirely based on SFDP data. In that case, I don't think there is a need
for an entry at all. The generic SFDP-based driver should already be
enough for your flash. Just add a "jedec,spi-nor" node to your DT and it
should work.

>  	}
>  };

-- 
Regards,
Pratyush Yadav

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

WARNING: multiple messages have this Message-ID (diff)
From: Pratyush Yadav <pratyush@kernel.org>
To: Flaviu Nistor <flaviu.nistor@gmail.com>
Cc: Tudor Ambarus <tudor.ambarus@linaro.org>,
	 Pratyush Yadav <pratyush@kernel.org>,
	 Michael Walle <mwalle@kernel.org>,
	 Miquel Raynal <miquel.raynal@bootlin.com>,
	 Richard Weinberger <richard@nod.at>,
	Vignesh Raghavendra <vigneshr@ti.com>,
	 linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mtd: spi-nor: issi: Add support for is25wx01g
Date: Mon, 01 Sep 2025 19:13:12 +0200	[thread overview]
Message-ID: <mafs0cy8aw0yf.fsf@kernel.org> (raw)
In-Reply-To: <20250901164218.11165-1-flaviu.nistor@gmail.com>

Hi Flaviu,

On Mon, Sep 01 2025, Flaviu Nistor wrote:

> Add support for the IS25WX01G 128MB (1Gb) ISSI Serial Flash Memory.
>
> Signed-off-by: Flaviu Nistor <flaviu.nistor@gmail.com>
> ---
>  drivers/mtd/spi-nor/issi.c | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/drivers/mtd/spi-nor/issi.c b/drivers/mtd/spi-nor/issi.c
> index 18d9a00aa22e..e4997f9bd557 100644
> --- a/drivers/mtd/spi-nor/issi.c
> +++ b/drivers/mtd/spi-nor/issi.c
> @@ -126,6 +126,9 @@ static const struct flash_info issi_nor_parts[] = {
>  		.flags = SPI_NOR_QUAD_PP,
>  		.fixups = &is25lp256_fixups,
>  		.fixup_flags = SPI_NOR_4B_OPCODES,
> +	}, {
> +		/* IS25WX01G */
> +		.id = SNOR_ID(0x9d, 0x5b, 0x1b),

It seems the flash needs no special configuration. IIUC it can be driven
entirely based on SFDP data. In that case, I don't think there is a need
for an entry at all. The generic SFDP-based driver should already be
enough for your flash. Just add a "jedec,spi-nor" node to your DT and it
should work.

>  	}
>  };

-- 
Regards,
Pratyush Yadav

  reply	other threads:[~2025-09-01 23:18 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-01 16:42 [PATCH] mtd: spi-nor: issi: Add support for is25wx01g Flaviu Nistor
2025-09-01 16:42 ` Flaviu Nistor
2025-09-01 17:13 ` Pratyush Yadav [this message]
2025-09-01 17:13   ` Pratyush Yadav
2025-09-02 18:38   ` Flaviu Nistor
2025-09-02 18:38     ` Flaviu Nistor

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=mafs0cy8aw0yf.fsf@kernel.org \
    --to=pratyush@kernel.org \
    --cc=flaviu.nistor@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=miquel.raynal@bootlin.com \
    --cc=mwalle@kernel.org \
    --cc=richard@nod.at \
    --cc=tudor.ambarus@linaro.org \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.