Re: [PATCH] spi: spi-mem: Add missing kdoc argument

[Pratyush Yadav <pratyush@kernel.org>]

On Mon, Aug 04 2025, Miquel Raynal wrote:

> The "*mem" pointer has been added without description, describe it in
> the kdoc comment in order to fix the following W=1 warning:

Hmm, this warning does not show up for me with W=1, but does with W=2. I
am running:

   make drivers/spi/spi-mem.o LLVM=1 ARCH=arm W=1

Am I doing something wrong? I usually test with W=1 for SPI NOR patches
to make sure no new warnings are added.

Anyway,

Acked-by: Pratyush Yadav <pratyush@kernel.org>

>
> Warning: drivers/spi/spi-mem.c:594 function parameter 'mem' not
> described in 'spi_mem_calc_op_duration'
>
> Fixes: a11a51896572 ("spi: spi-mem: Take into account the actual maximum frequency")
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202507310409.fnuQ21qb-lkp@intel.com/
> Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
> ---
>  drivers/spi/spi-mem.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/spi/spi-mem.c b/drivers/spi/spi-mem.c
> index d3b7e857b377..841b0995c8ea 100644
> --- a/drivers/spi/spi-mem.c
> +++ b/drivers/spi/spi-mem.c
> @@ -577,6 +577,7 @@ EXPORT_SYMBOL_GPL(spi_mem_adjust_op_freq);
>   * spi_mem_calc_op_duration() - Derives the theoretical length (in ns) of an
>   *			        operation. This helps finding the best variant
>   *			        among a list of possible choices.
> + * @mem: the SPI memory
>   * @op: the operation to benchmark
>   *
>   * Some chips have per-op frequency limitations, PCBs usually have their own

-- 
Regards,
Pratyush Yadav

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/