From: Pratyush Yadav <pratyush@kernel.org>
To: Michael Walle <mwalle@kernel.org>
Cc: Tudor Ambarus <tudor.ambarus@linaro.org>,
Pratyush Yadav <pratyush@kernel.org>,
Miquel Raynal <miquel.raynal@bootlin.com>,
Richard Weinberger <richard@nod.at>,
Vignesh Raghavendra <vigneshr@ti.com>,
linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org
Subject: Re: [PATCH v1 5/6] mtd: spi-nor: simplify spi_nor_get_flash_info()
Date: Wed, 17 Apr 2024 16:18:55 +0200 [thread overview]
Message-ID: <mafs0o7a86pio.fsf@kernel.org> (raw)
In-Reply-To: <20240412134405.381832-6-mwalle@kernel.org> (Michael Walle's message of "Fri, 12 Apr 2024 15:44:04 +0200")
Hi,
On Fri, Apr 12 2024, Michael Walle wrote:
> Rework spi_nor_get_flash_info() to make it look more straight forward
> and esp. don't return early. The latter is a preparation to check for
> deprecated flashes.
Looks much nicer now! Though I did spend around 15 minutes wondering if
it can be made even simpler, but I can't come up with anything better.
Reviewed-by: Pratyush Yadav <pratyush@kernel.org>
[...]
--
Regards,
Pratyush Yadav
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
WARNING: multiple messages have this Message-ID (diff)
From: Pratyush Yadav <pratyush@kernel.org>
To: Michael Walle <mwalle@kernel.org>
Cc: Tudor Ambarus <tudor.ambarus@linaro.org>,
Pratyush Yadav <pratyush@kernel.org>,
Miquel Raynal <miquel.raynal@bootlin.com>,
Richard Weinberger <richard@nod.at>,
Vignesh Raghavendra <vigneshr@ti.com>,
linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org
Subject: Re: [PATCH v1 5/6] mtd: spi-nor: simplify spi_nor_get_flash_info()
Date: Wed, 17 Apr 2024 16:18:55 +0200 [thread overview]
Message-ID: <mafs0o7a86pio.fsf@kernel.org> (raw)
In-Reply-To: <20240412134405.381832-6-mwalle@kernel.org> (Michael Walle's message of "Fri, 12 Apr 2024 15:44:04 +0200")
Hi,
On Fri, Apr 12 2024, Michael Walle wrote:
> Rework spi_nor_get_flash_info() to make it look more straight forward
> and esp. don't return early. The latter is a preparation to check for
> deprecated flashes.
Looks much nicer now! Though I did spend around 15 minutes wondering if
it can be made even simpler, but I can't come up with anything better.
Reviewed-by: Pratyush Yadav <pratyush@kernel.org>
[...]
--
Regards,
Pratyush Yadav
next prev parent reply other threads:[~2024-04-17 14:19 UTC|newest]
Thread overview: 62+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-12 13:43 [PATCH v1 0/6] mtd: spi-nor: spring cleaning Michael Walle
2024-04-12 13:43 ` Michael Walle
2024-04-12 13:44 ` [PATCH v1 1/6] mtd: spi-nor: Remove support for Xilinx S3AN flashes Michael Walle
2024-04-12 13:44 ` Michael Walle
2024-04-12 13:53 ` Tudor Ambarus
2024-04-12 13:53 ` Tudor Ambarus
2024-04-12 14:01 ` Michael Walle
2024-04-12 14:01 ` Michael Walle
2024-04-15 15:26 ` Pratyush Yadav
2024-04-15 15:26 ` Pratyush Yadav
2024-04-16 4:45 ` Tudor Ambarus
2024-04-16 4:45 ` Tudor Ambarus
2024-04-12 13:44 ` [PATCH v1 2/6] mtd: spi-nor: get rid of non-power-of-2 page size handling Michael Walle
2024-04-12 13:44 ` Michael Walle
2024-04-12 13:58 ` Tudor Ambarus
2024-04-12 13:58 ` Tudor Ambarus
2024-04-15 15:49 ` Pratyush Yadav
2024-04-15 15:49 ` Pratyush Yadav
2024-04-12 13:44 ` [PATCH v1 3/6] mtd: spi-nor: get rid of SPI_NOR_NO_FR Michael Walle
2024-04-12 13:44 ` Michael Walle
2024-04-12 14:00 ` Tudor Ambarus
2024-04-12 14:00 ` Tudor Ambarus
2024-04-12 14:03 ` Michael Walle
2024-04-12 14:03 ` Michael Walle
2024-04-16 4:47 ` Tudor Ambarus
2024-04-16 4:47 ` Tudor Ambarus
2024-04-17 13:39 ` Pratyush Yadav
2024-04-17 13:39 ` Pratyush Yadav
2024-04-17 14:43 ` Michael Walle
2024-04-17 14:43 ` Michael Walle
2024-04-17 15:37 ` Pratyush Yadav
2024-04-17 15:37 ` Pratyush Yadav
2024-04-17 15:45 ` Michael Walle
2024-04-17 15:45 ` Michael Walle
2024-04-17 15:54 ` Pratyush Yadav
2024-04-17 15:54 ` Pratyush Yadav
2024-04-12 13:44 ` [PATCH v1 4/6] mtd: spi-nor: remove .setup() callback Michael Walle
2024-04-12 13:44 ` Michael Walle
2024-04-12 14:02 ` Tudor Ambarus
2024-04-12 14:02 ` Tudor Ambarus
2024-04-12 13:44 ` [PATCH v1 5/6] mtd: spi-nor: simplify spi_nor_get_flash_info() Michael Walle
2024-04-12 13:44 ` Michael Walle
2024-04-17 14:18 ` Pratyush Yadav [this message]
2024-04-17 14:18 ` Pratyush Yadav
2024-04-12 13:44 ` [RFC PATCH v1 6/6] mtd: spi-nor: introduce support for displaying deprecation message Michael Walle
2024-04-12 13:44 ` Michael Walle
2024-04-12 14:10 ` Tudor Ambarus
2024-04-12 14:10 ` Tudor Ambarus
2024-04-17 14:36 ` Pratyush Yadav
2024-04-17 14:36 ` Pratyush Yadav
2024-04-17 14:52 ` Michael Walle
2024-04-17 14:52 ` Michael Walle
2024-04-17 15:52 ` Pratyush Yadav
2024-04-17 15:52 ` Pratyush Yadav
2024-04-18 9:57 ` Michael Walle
2024-04-18 9:57 ` Michael Walle
2024-04-18 11:20 ` Pratyush Yadav
2024-04-18 11:20 ` Pratyush Yadav
2024-04-16 4:57 ` [PATCH v1 0/6] mtd: spi-nor: spring cleaning Tudor Ambarus
2024-04-16 4:57 ` Tudor Ambarus
2024-04-17 15:02 ` Michael Walle
2024-04-17 15:02 ` Michael Walle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=mafs0o7a86pio.fsf@kernel.org \
--to=pratyush@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=miquel.raynal@bootlin.com \
--cc=mwalle@kernel.org \
--cc=richard@nod.at \
--cc=tudor.ambarus@linaro.org \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.