All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pratyush Yadav <pratyush@kernel.org>
To: Frank Li <Frank.li@nxp.com>
Cc: Pratyush Yadav <pratyush@kernel.org>,
	 Tudor Ambarus <tudor.ambarus@linaro.org>,
	 Michael Walle <mwalle@kernel.org>,
	 Miquel Raynal <miquel.raynal@bootlin.com>,
	 Richard Weinberger <richard@nod.at>,
	Vignesh Raghavendra <vigneshr@ti.com>,
	 Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	 Conor Dooley <conor+dt@kernel.org>,
	 "open list:SPI NOR SUBSYSTEM" <linux-mtd@lists.infradead.org>,
	 "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
	<devicetree@vger.kernel.org>,
	 open list <linux-kernel@vger.kernel.org>,
	 imx@lists.linux.dev
Subject: Re: [PATCH 1/1] dt-bindings: mtd: jedec,spi-nor: Add atmel,at26* compatible string
Date: Wed, 28 May 2025 20:57:35 +0200	[thread overview]
Message-ID: <mafs0tt54r2ao.fsf@kernel.org> (raw)
In-Reply-To: <aDcscr4pF5vC4kNq@lizhi-Precision-Tower-5810>

On Wed, May 28 2025, Frank Li wrote:

> On Tue, May 27, 2025 at 06:13:22PM +0200, Pratyush Yadav wrote:
>> On Fri, May 23 2025, Frank Li wrote:
>>
>> > Add atmel,at26* compatible string to fix below CHECK_DTB warning:
>> >
>> > arch/arm/boot/dts/nxp/vf/vf610-twr.dtb: /soc/bus@40000000/spi@4002c000/at26df081a@0:
>> >     failed to match any schema with compatible: ['atmel,at26df081a']
>>
>> Is there any problem with setting the compatible to "jedec,spi-nor" in
>> the DTS instead? If not, it would better to do that instead.
>
> I suppose it should work. But it is quite old legancy boards. I have not
> board to test it.  And dt also prefer add chip specific compatible string
> before common failback compatible string in case need workaround some chip
> issues.

Hmm, poking around with old DTs is probably not a good idea. Anyway, the
flash is listed in spi_nor_dev_ids just like the others in this yaml, so
this patch looks fine.

Acked-by: Pratyush Yadav <pratyush@kernel.org>

-- 
Regards,
Pratyush Yadav

WARNING: multiple messages have this Message-ID (diff)
From: Pratyush Yadav <pratyush@kernel.org>
To: Frank Li <Frank.li@nxp.com>
Cc: Pratyush Yadav <pratyush@kernel.org>,
	 Tudor Ambarus <tudor.ambarus@linaro.org>,
	 Michael Walle <mwalle@kernel.org>,
	 Miquel Raynal <miquel.raynal@bootlin.com>,
	 Richard Weinberger <richard@nod.at>,
	Vignesh Raghavendra <vigneshr@ti.com>,
	 Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	 Conor Dooley <conor+dt@kernel.org>,
	 "open list:SPI NOR SUBSYSTEM" <linux-mtd@lists.infradead.org>,
	 "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
	<devicetree@vger.kernel.org>,
	 open list <linux-kernel@vger.kernel.org>,
	 imx@lists.linux.dev
Subject: Re: [PATCH 1/1] dt-bindings: mtd: jedec,spi-nor: Add atmel,at26* compatible string
Date: Wed, 28 May 2025 20:57:35 +0200	[thread overview]
Message-ID: <mafs0tt54r2ao.fsf@kernel.org> (raw)
In-Reply-To: <aDcscr4pF5vC4kNq@lizhi-Precision-Tower-5810>

On Wed, May 28 2025, Frank Li wrote:

> On Tue, May 27, 2025 at 06:13:22PM +0200, Pratyush Yadav wrote:
>> On Fri, May 23 2025, Frank Li wrote:
>>
>> > Add atmel,at26* compatible string to fix below CHECK_DTB warning:
>> >
>> > arch/arm/boot/dts/nxp/vf/vf610-twr.dtb: /soc/bus@40000000/spi@4002c000/at26df081a@0:
>> >     failed to match any schema with compatible: ['atmel,at26df081a']
>>
>> Is there any problem with setting the compatible to "jedec,spi-nor" in
>> the DTS instead? If not, it would better to do that instead.
>
> I suppose it should work. But it is quite old legancy boards. I have not
> board to test it.  And dt also prefer add chip specific compatible string
> before common failback compatible string in case need workaround some chip
> issues.

Hmm, poking around with old DTs is probably not a good idea. Anyway, the
flash is listed in spi_nor_dev_ids just like the others in this yaml, so
this patch looks fine.

Acked-by: Pratyush Yadav <pratyush@kernel.org>

-- 
Regards,
Pratyush Yadav

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

  reply	other threads:[~2025-05-28 18:57 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-23 15:52 [PATCH 1/1] dt-bindings: mtd: jedec,spi-nor: Add atmel,at26* compatible string Frank Li
2025-05-23 15:52 ` Frank Li
2025-05-26 15:37 ` Conor Dooley
2025-05-26 15:37   ` Conor Dooley
2025-05-27 16:13 ` Pratyush Yadav
2025-05-27 16:13   ` Pratyush Yadav
2025-05-28 15:32   ` Frank Li
2025-05-28 15:32     ` Frank Li
2025-05-28 18:57     ` Pratyush Yadav [this message]
2025-05-28 18:57       ` Pratyush Yadav
2025-07-03 15:08 ` Pratyush Yadav
2025-07-03 15:08   ` Pratyush Yadav

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=mafs0tt54r2ao.fsf@kernel.org \
    --to=pratyush@kernel.org \
    --cc=Frank.li@nxp.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=imx@lists.linux.dev \
    --cc=krzk+dt@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=miquel.raynal@bootlin.com \
    --cc=mwalle@kernel.org \
    --cc=richard@nod.at \
    --cc=robh@kernel.org \
    --cc=tudor.ambarus@linaro.org \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.