From: Pratyush Yadav <pratyush@kernel.org>
To: Michael Walle <mwalle@kernel.org>
Cc: Tudor Ambarus <tudor.ambarus@linaro.org>,
Pratyush Yadav <pratyush@kernel.org>,
Miquel Raynal <miquel.raynal@bootlin.com>,
Richard Weinberger <richard@nod.at>,
Vignesh Raghavendra <vigneshr@ti.com>,
Linus Walleij <linus.walleij@linaro.org>,
linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org,
Esben Haabendal <esben@geanix.com>,
Hartmut Birr <e9hack@gmail.com>
Subject: Re: [PATCH v2] mtd: spi-nor: winbond: fix w25q128 regression
Date: Fri, 21 Jun 2024 17:50:45 +0200 [thread overview]
Message-ID: <mafs0v822e1m2.fsf@kernel.org> (raw)
In-Reply-To: <20240621120929.2670185-1-mwalle@kernel.org> (Michael Walle's message of "Fri, 21 Jun 2024 14:09:29 +0200")
On Fri, Jun 21 2024, Michael Walle wrote:
> Commit 83e824a4a595 ("mtd: spi-nor: Correct flags for Winbond w25q128")
> removed the flags for non-SFDP devices. It was assumed that it wasn't in
> use anymore. This wasn't true. Add the no_sfdp_flags as well as the size
> again.
>
> We add the additional flags for dual and quad read because they have
> been reported to work properly by Hartmut using both older and newer
> versions of this flash, the similar flashes with 64Mbit and 256Mbit
> already have these flags and because it will (luckily) trigger our
> legacy SFDP parsing, so newer versions with SFDP support will still get
> the parameters from the SFDP tables.
>
> Reported-by: Hartmut Birr <e9hack@gmail.com>
> Closes: https://lore.kernel.org/r/CALxbwRo_-9CaJmt7r7ELgu+vOcgk=xZcGHobnKf=oT2=u4d4aA@mail.gmail.com/
> Fixes: 83e824a4a595 ("mtd: spi-nor: Correct flags for Winbond w25q128")
> Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
> Signed-off-by: Michael Walle <mwalle@kernel.org>
Reviewed-by: Pratyush Yadav <pratyush@kernel.org>
Applied to spi-nor/next. Thanks!
--
Regards,
Pratyush Yadav
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
WARNING: multiple messages have this Message-ID (diff)
From: Pratyush Yadav <pratyush@kernel.org>
To: Michael Walle <mwalle@kernel.org>
Cc: Tudor Ambarus <tudor.ambarus@linaro.org>,
Pratyush Yadav <pratyush@kernel.org>,
Miquel Raynal <miquel.raynal@bootlin.com>,
Richard Weinberger <richard@nod.at>,
Vignesh Raghavendra <vigneshr@ti.com>,
Linus Walleij <linus.walleij@linaro.org>,
linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org,
Esben Haabendal <esben@geanix.com>,
Hartmut Birr <e9hack@gmail.com>
Subject: Re: [PATCH v2] mtd: spi-nor: winbond: fix w25q128 regression
Date: Fri, 21 Jun 2024 17:50:45 +0200 [thread overview]
Message-ID: <mafs0v822e1m2.fsf@kernel.org> (raw)
In-Reply-To: <20240621120929.2670185-1-mwalle@kernel.org> (Michael Walle's message of "Fri, 21 Jun 2024 14:09:29 +0200")
On Fri, Jun 21 2024, Michael Walle wrote:
> Commit 83e824a4a595 ("mtd: spi-nor: Correct flags for Winbond w25q128")
> removed the flags for non-SFDP devices. It was assumed that it wasn't in
> use anymore. This wasn't true. Add the no_sfdp_flags as well as the size
> again.
>
> We add the additional flags for dual and quad read because they have
> been reported to work properly by Hartmut using both older and newer
> versions of this flash, the similar flashes with 64Mbit and 256Mbit
> already have these flags and because it will (luckily) trigger our
> legacy SFDP parsing, so newer versions with SFDP support will still get
> the parameters from the SFDP tables.
>
> Reported-by: Hartmut Birr <e9hack@gmail.com>
> Closes: https://lore.kernel.org/r/CALxbwRo_-9CaJmt7r7ELgu+vOcgk=xZcGHobnKf=oT2=u4d4aA@mail.gmail.com/
> Fixes: 83e824a4a595 ("mtd: spi-nor: Correct flags for Winbond w25q128")
> Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
> Signed-off-by: Michael Walle <mwalle@kernel.org>
Reviewed-by: Pratyush Yadav <pratyush@kernel.org>
Applied to spi-nor/next. Thanks!
--
Regards,
Pratyush Yadav
next prev parent reply other threads:[~2024-06-21 15:51 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-21 12:09 [PATCH v2] mtd: spi-nor: winbond: fix w25q128 regression Michael Walle
2024-06-21 12:09 ` Michael Walle
2024-06-21 12:43 ` Tudor Ambarus
2024-06-21 12:43 ` Tudor Ambarus
2024-06-21 12:45 ` Esben Haabendal
2024-06-21 12:45 ` Esben Haabendal
2024-06-21 15:50 ` Pratyush Yadav [this message]
2024-06-21 15:50 ` Pratyush Yadav
-- strict thread matches above, loose matches on Subject: below --
2024-10-29 10:01 Linus Walleij
2024-11-06 7:29 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=mafs0v822e1m2.fsf@kernel.org \
--to=pratyush@kernel.org \
--cc=e9hack@gmail.com \
--cc=esben@geanix.com \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=miquel.raynal@bootlin.com \
--cc=mwalle@kernel.org \
--cc=richard@nod.at \
--cc=tudor.ambarus@linaro.org \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.