[LARTC] a question about q_tbf.c of TC

[LARTC] a question about q_tbf.c of TC

[Mebius Huang]

TEFSVEOjrGhlbGxvo6ENCg0KoaGhoSBJIHdhbnQgdG8gc2VuZCBhIGNvbW1hbmQgInRjIHFkaXNj
IGFkZCBkZXYgZXRoMCByb290IHRiZiByYXRlIDIyMGtiaXQgbGF0ZW5jeSA1MG1zIGJ1cnN0IDE1
NDAiIGZyb20gVEMsDQpJIGZvdW5kIHRoYXQgYSBhdHRyaWJ1dGUgd2l0aCB0eXBlIG9mIDEgaXMg
YWRkZWQgdG8gdGhlIG5sbXNnIHR3aWNlOg0KDQogICAgZmlyc3QgdGltZSBpbiB0aGUgZnVuY3Rp
b24gb2YgdGNfcWRpc2NfbW9kaWZ5KCkgaW4gZmlsZSBvZiB0Y19xZGlzYy5jOg0KCSJpZiAoa1sw
XSkNCgkJYWRkYXR0cl9sKCZyZXEubiwgc2l6ZW9mKHJlcSksIFRDQV9LSU5ELCBrLCBzdHJsZW4o
aykrMSk7Ig0KDQoJc2Vjb25kIHRpbWUgaW4gdGhlIGZ1bmN0aW9uIG9mIHRiZl9wYXJzZV9vcHQo
KSBpbiBmaWxlIG9mIHFfdGJmLmM6DQogICAgImFkZGF0dHJfbChuLCAyMDI0LCBUQ0FfVEJGX1BB
Uk1TLCAmb3B0LCBzaXplb2Yob3B0KSk7Ig0KDQoJdGhlIHZhbHVlIG9mIFRDQV9LSU5EIGFuZCBU
Q0FfVEJGX1BBUkFNUyBpcyBib3RoIDEsc28gdGhlIG5sbXNnIGNvbnNpc3RzIHR3byBhdHRyaWJ1
dGUgd2l0aCB0eXBlIG9mIDEuDQoNCiAgICB3aGVuIHRoaXMgbmxtc2cgaXMgZGVhbGVkIHdpdGgg
aW4gdGhlIGtlcm5lbCxJIGZvdW5kIGEgcHJvYmxlbToNCg0KICAgIGluIHRoZSBuZXQvY29yZS9y
dG5ldGxpbmsuYywgZnVuY3Rpb24gcnRuZXRsaW5rX3Jldl9tc2coKSx3aGVuOg0KDQoJImlmIChu
bGgtPm5sbXNnX2xlbiA+IG1pbl9sZW4pIHsNCgkJaW50IGF0dHJsZW4gPSBubGgtPm5sbXNnX2xl
biAtIE5MTVNHX0FMSUdOKG1pbl9sZW4pOw0KCQlzdHJ1Y3QgcnRhdHRyICphdHRyID0gKHZvaWQq
KW5saCArIE5MTVNHX0FMSUdOKG1pbl9sZW4pOw0KDQoJCXdoaWxlIChSVEFfT0soYXR0ciwgYXR0
cmxlbikpIHsNCgkJCXVuc2lnbmVkIGZsYXZvciA9IGF0dHItPnJ0YV90eXBlOw0KCQkJaWYgKGZs
YXZvcikgew0KCQkJCWlmIChmbGF2b3IgPiBydGFfbWF4W3N6X2lkeF0pDQoJCQkJCWdvdG8gZXJy
X2ludmFsOw0KCQkJCXJ0YVtmbGF2b3ItMV0gPSBhdHRyOw0KCQkJfQ0KCQkJYXR0ciA9IFJUQV9O
RVhUKGF0dHIsIGF0dHJsZW4pOw0KCQl9DQoJfSINCg0KCWF0IHRoZSBiZWdpbmluZyBvZiB0aGVz
ZSBsaW5lcywgdGhlIGZpcnN0IGF0dHJpYnV0ZShUQ0FfS0lORCkgY2FuIGJlIHN0b3JlZCBpbiBy
dGFbMV0sIGJ1dCB3aGVuIGhhbmRsaW5nDQp0aGUgc2Vjb25kIGF0dHJpYnV0ZSwgaXQgaXMgc3Rv
cmVkIGluIHRoZSBzYW1lIHJ0YVsxXSEgc28gdGhlIGZpcnN0IGF0dHJpYnV0ZSBkaXNhcHBlYXJl
ZCEhDQogICAgb2YgY291cnNlIHRoZSB0cmVhdG1lbnQgZm9sbG93ZWQgd2lsbCBtYWtlIGEgbWlz
dGFrZS4NCiAgICB3aG8gY2FuIHRlbGwgbWUgd2h5Pw0KDQoNCqGhoaGhoWJlc3QgcmVnYXJkcyEN
Cg0KIAkJCQkNCqGhoaGhoaGhoaGhoaGhoaGhoaGhoaGhoaGhoaFNZWJpdXMgSHVhbmcNCqGhoaGh
oaGhoaGhoaGhoaGhoaGhoaGhoaGhoaFoeGdhbmdAY3NuZXQ0LmNzLnRzaW5naHVhLmVkdS5jbg0K
oaGhoaGhoaGhoaGhoaGhoaGhoaGhoaGhoaGhoaGhoaGhoTIwMDAtMDItMjENCg=


_______________________________________________
LARTC mailing list / LARTC@mailman.ds9a.nl
http://mailman.ds9a.nl/mailman/listinfo/lartc HOWTO: http://lartc.org/

Re: [LARTC] a question about q_tbf.c of TC

[Martin Devera]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="windows-1254", Size: 2346 bytes --]

Hello,

IIRC it is ok. The TCA_KIND is used as upper level ID. TCA_TBF_PARAMS
is in second level, it is contained as data of TBF kind. Take dump
of whole NL message and study carefully.
It is like:
TCA_KIND  "TBF"
TCA_XXXX {
  TCA_TBF_PARAMS ....
  TCA_TBF_XXXX .....
}
TCA_YYY ...

So that when rtnetlink_rev_msg parses message first time it skips
all occurences of TCA_TBF_*. q_tbf is given data part of TCA_XXXX
(can't remember name) and it calls rt parse function again on the
data.
devik

> ¡¡¡¡ I want to send a command "tc qdisc add dev eth0 root tbf rate 220kbit latency 50ms burst 1540" from TC,
> I found that a attribute with type of 1 is added to the nlmsg twice:
> 
>     first time in the function of tc_qdisc_modify() in file of tc_qdisc.c:
> 	"if (k[0])
> 		addattr_l(&req.n, sizeof(req), TCA_KIND, k, strlen(k)+1);"
> 
> 	second time in the function of tbf_parse_opt() in file of q_tbf.c:
>     "addattr_l(n, 2024, TCA_TBF_PARMS, &opt, sizeof(opt));"
> 
> 	the value of TCA_KIND and TCA_TBF_PARAMS is both 1,so the nlmsg consists two attribute with type of 1.
> 
>     when this nlmsg is dealed with in the kernel,I found a problem:
> 
>     in the net/core/rtnetlink.c, function rtnetlink_rev_msg(),when:
> 
> 	"if (nlh->nlmsg_len > min_len) {
> 		int attrlen = nlh->nlmsg_len - NLMSG_ALIGN(min_len);
> 		struct rtattr *attr = (void*)nlh + NLMSG_ALIGN(min_len);
> 
> 		while (RTA_OK(attr, attrlen)) {
> 			unsigned flavor = attr->rta_type;
> 			if (flavor) {
> 				if (flavor > rta_max[sz_idx])
> 					goto err_inval;
> 				rta[flavor-1] = attr;
> 			}
> 			attr = RTA_NEXT(attr, attrlen);
> 		}
> 	}"
> 
> 	at the begining of these lines, the first attribute(TCA_KIND) can be stored in rta[1], but when handling
> the second attribute, it is stored in the same rta[1]! so the first attribute disappeared!!
>     of course the treatment followed will make a mistake.
>     who can tell me why?
> 
> 
> ¡¡¡¡¡¡best regards!
> 
>  				
> ¡¡¡¡¡¡¡¡¡¡¡¡¡¡¡¡¡¡¡¡¡¡¡¡¡¡¡¡Mebius Huang
> ¡¡¡¡¡¡¡¡¡¡¡¡¡¡¡¡¡¡¡¡¡¡¡¡¡¡¡¡hxgang@csnet4.cs.tsinghua.edu.cn
> ¡¡¡¡¡¡¡¡¡¡¡¡¡¡¡¡¡¡¡¡¡¡¡¡¡¡¡¡¡¡¡¡¡¡2000-02-21
> ,\x04S
> f¢–)à–+-ü°\x11L)šŠYšÛ=jya¶Ú~ÿùšŠYšÛ=jy\x7f™¨¥™©ÿ–+-ŠwèþV«µÁÎY3¾†Ûiûÿåj»\¢¸?

_______________________________________________
LARTC mailing list / LARTC@mailman.ds9a.nl
http://mailman.ds9a.nl/mailman/listinfo/lartc HOWTO: http://lartc.org/